Skip to content

integration_tests: Check if BuildContext is mounted in display_cutout_test #169008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
srawlins merged 1 commit into from
May 29, 2025
Merged

integration_tests: Check if BuildContext is mounted in display_cutout_test #169008

srawlins merged 1 commit into from
May 29, 2025

Conversation

@srawlins
Copy link
Contributor

@srawlins srawlins commented May 16, 2025 •
edited
Loading

These changes highlight where code was not safely checking whether the BuildContext was mounted before using it.

The use_build_context_synchronously lint rule is changing to catch these cases.

Pre-launch Checklist

@srawlins srawlins enabled auto-merge May 16, 2025 20:55
@srawlins
Copy link
Contributor Author

srawlins commented May 27, 2025

Is there a process for getting a PR reviewed?

@srawlins srawlins added this pull request to the merge queue May 28, 2025
auto-merge was automatically disabled May 28, 2025 22:29

Pull Request is not mergeable

Merged via the queue into master with commit 1ce59f4 May 29, 2025
154 checks passed
@srawlins srawlins deleted the ubcs-integration-tests branch May 29, 2025 03:15
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
706b179 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
b471fe7 
…y_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
3dafb46 
…y_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
9bde403 
…y_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
52ad8f7 
…y_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
75a7604 
…y_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
70681c2 
…y_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
4326c62 
…y_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
835e3ab 
…y_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
37ecc13 
…y_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
db903c8 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
7859dee 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
20ced9c 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
cd75adb 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
141b123 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
ec4154c 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
d1e73f0 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
53e55ba 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
39f56a3 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
25c1836 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
fdbdc34 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
a2cc8f2 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
4d3681c 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
3242980 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
6da278b 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
04a0789 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
a963022 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
cee1116 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
3f03e63 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
a83a25c 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
06f1fb5 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
27fe6dc 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
dbb32a1 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
cb6b530 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
dec8eb7 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
91ab20d 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
834271e 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
199a146 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
de84406 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
8e238c1 
…y_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
1ce59f4 integration_tests: Check if BuildContext is mounted in displa…
92dca07 
…y_cutout_test (flutter/flutter#169008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srawlins @matanlurey