Normalize BottomAppBarTheme (continue) #168966

huycozy · 2025-05-16T07:18:02Z

This is following #168586:

See #168586 (comment) for the context of this.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2025-05-16T07:18:06Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

stuartmorgan-g · 2025-05-16T12:16:12Z

test-exempt: code refactor with no semantic change

QuncCccccc

LGTM. Thank you for the help!

Created cl/760817863 to fix g3 breakages that this PR may cause. Once it's landed, we are good to go here with a migration guide:)

huycozy · 2025-05-21T04:54:39Z

@QuncCccccc I see Google testing has failed. Could you please take a look?

QuncCccccc · 2025-05-21T17:26:06Z

cl/760817863 has been submitted, so the google testing should be fixed:) Rerunning tests!

auto-submit · 2025-05-21T17:37:02Z

autosubmit label was removed for flutter/flutter/168966, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…llowing BottomAppBarTheme's normalization Signed-off-by: huycozy <huy@nevercode.io>

Roll Flutter from 33cdd8e to 85564cb (39 revisions) flutter/flutter@33cdd8e...85564cb 2025-05-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#169276)" (flutter/flutter#169347) 2025-05-23 engine-flutter-autoroll@skia.org Roll Skia from a01ea49f53a4 to 956fd8b14e22 (1 revision) (flutter/flutter#169334) 2025-05-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 4de10a11ceb9 to 085f110ecf33 (1 revision) (flutter/flutter#169333) 2025-05-23 engine-flutter-autoroll@skia.org Roll Skia from bcc7e7fce10e to a01ea49f53a4 (1 revision) (flutter/flutter#169329) 2025-05-23 engine-flutter-autoroll@skia.org Roll Skia from 18b85aced9b7 to bcc7e7fce10e (3 revisions) (flutter/flutter#169323) 2025-05-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 2a45b2f88a4f to 4de10a11ceb9 (2 revisions) (flutter/flutter#169322) 2025-05-23 matanlurey@users.noreply.github.com Remove patching of `package_config.json` from Flutter Pub wrapper. (flutter/flutter#169306) 2025-05-23 jsimionato@google.com Add missing dart_dynamic_modules flag for iOS DDM simulator builds (flutter/flutter#169254) 2025-05-23 engine-flutter-autoroll@skia.org Roll Skia from ea73ccdc1417 to 18b85aced9b7 (6 revisions) (flutter/flutter#169315) 2025-05-23 simonhadenius@gmail.com Add flag to exclude focus for hidden children in Visibility, maintainFocusability. Set maintainFocusability to false in IndexedStack (flutter/flutter#159133) 2025-05-23 30870216+gaaclarke@users.noreply.github.com [Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#169276) 2025-05-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 8f85d89fdc23 to 2a45b2f88a4f (6 revisions) (flutter/flutter#169312) 2025-05-23 52160996+FMorschel@users.noreply.github.com Removes unnecessary parentheses (flutter/flutter#169015) 2025-05-22 danny@tuppeny.com Unpin test/test_core/test_api packages (flutter/flutter#169198) 2025-05-22 dkwingsmt@users.noreply.github.com [Engine] Fix an edge case of RoundSuperellipseParam::Contains with sharp corners (flutter/flutter#167977) 2025-05-22 victorsanniay@gmail.com Replace goldens in test/cupertino/nav_bar_transition_test.dart (flutter/flutter#169172) 2025-05-22 engine-flutter-autoroll@skia.org Roll Skia from 13a299964c9f to ea73ccdc1417 (35 revisions) (flutter/flutter#169303) 2025-05-22 danny@tuppeny.com Increase sub-task timeout for Mac web_tool_tests (flutter/flutter#169307) 2025-05-22 rmolivares@renzo-olivares.dev Fix crash on two finger selection gesture (flutter/flutter#168598) 2025-05-22 matanlurey@users.noreply.github.com Disable the ability to opt-out of `explicit-package-dependencies`. (flutter/flutter#169283) 2025-05-22 47866232+chunhtai@users.noreply.github.com Fixes tab semantics gets dropped if the child produce a semantics node (flutter/flutter#169233) 2025-05-22 matanlurey@users.noreply.github.com Skip `{PLAT}_web_tools_test#expression_evaluation_*_test.dart`, turning tree 🔴 (flutter/flutter#169305) 2025-05-22 matanlurey@users.noreply.github.com Update tool-internal `generateLocalizations...()` to never use synthetic (`flutter_gen`) packages (flutter/flutter#169285) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `build_android_host_app_with_module_aar` build using an aar (#169171)" (flutter/flutter#169287) 2025-05-22 mdebbar@google.com Increase sub-task timeout for `web_tool_tests_1_2` (flutter/flutter#169277) 2025-05-22 mohellebiabdessalem@gmail.com refactor the usage of `MediaQuery.sizeOf(context).height` to use the new `.heightOf(context)` (flutter/flutter#168894) 2025-05-22 kevmoo@users.noreply.github.com [tool] Add --no-minify flag to JS Compiler (flutter/flutter#169102) 2025-05-22 bruno.leroux@gmail.com Update ButtonStyle documentation (flutter/flutter#168062) 2025-05-22 ybz975218925@live.com Fix the issue where DropdownMenu disposes of the controller. (flutter/flutter#168541) 2025-05-22 alex.medinsh@gmail.com Add bottomSheetScrimBuilder to Scaffold (flutter/flutter#167335) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (#168914)" (flutter/flutter#169250) 2025-05-21 engine-flutter-autoroll@skia.org Roll Dart SDK from 56940edd099d to 8f85d89fdc23 (6 revisions) (flutter/flutter#169237) 2025-05-21 kyle.finlinson@verygood.ventures Use gestureSettings.touchSlop in PrimaryPointerGestureRecognizer (flutter/flutter#161549) 2025-05-21 huy@nevercode.io Normalize BottomAppBarTheme (continue) (flutter/flutter#168966) 2025-05-21 30870216+gaaclarke@users.noreply.github.com [Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (flutter/flutter#168914) 2025-05-21 sarbagyastha@gmail.com Respect `calendarDelegate` in `showDateRangePicker` (flutter/flutter#168290) 2025-05-21 34871572+gmackall@users.noreply.github.com Make `build_android_host_app_with_module_aar` build using an aar (flutter/flutter#169171) 2025-05-21 jason-simmons@users.noreply.github.com Roll Dart SDK from 7c40eba6bf77 to 56940edd099d (flutter/flutter#169135) 2025-05-21 34465683+rkishan516@users.noreply.github.com Feat: Add full screen dialog support for dialog routes (flutter/flutter#167794) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. ...

huycozy self-assigned this May 16, 2025

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 16, 2025

huycozy mentioned this pull request May 16, 2025

Normalize BottomAppBarTheme #168586

Merged

9 tasks

huycozy requested a review from QuncCccccc May 16, 2025 08:15

QuncCccccc approved these changes May 20, 2025

View reviewed changes

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025

Change Object? to BottomAppBarThemeData type for bottomAppBarTheme fo…

748eaa5

…llowing BottomAppBarTheme's normalization Signed-off-by: huycozy <huy@nevercode.io>

QuncCccccc force-pushed the bottom-appbar-theme-normalization-continue branch from 500cd84 to 748eaa5 Compare May 21, 2025 20:44

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025

auto-submit bot added this pull request to the merge queue May 21, 2025

Merged via the queue into flutter:master with commit 7bfcb2f May 21, 2025
76 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025

huycozy deleted the bottom-appbar-theme-normalization-continue branch May 22, 2025 00:25

engine-flutter-autoroll mentioned this pull request May 22, 2025

Roll Flutter from 33cdd8ef31dc to e78b434e8f08 (12 revisions) flutter/packages#9307

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 22, 2025

7bfcb2f Normalize BottomAppBarTheme (continue) (flutter/flutter#168966)

b3b7646

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 22, 2025

7bfcb2f Normalize BottomAppBarTheme (continue) (flutter/flutter#168966)

3404ffa

engine-flutter-autoroll mentioned this pull request May 22, 2025

Roll Flutter from 33cdd8ef31dc to cb3150f99848 (13 revisions) flutter/packages#9308

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 22, 2025

7bfcb2f Normalize BottomAppBarTheme (continue) (flutter/flutter#168966)

c259841

engine-flutter-autoroll mentioned this pull request May 22, 2025

Roll Flutter from 33cdd8ef31dc to 5fd7aa2ed70d (16 revisions) flutter/packages#9309

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2025

7bfcb2f Normalize BottomAppBarTheme (continue) (flutter/flutter#168966)

8186361

engine-flutter-autoroll mentioned this pull request May 23, 2025

Roll Flutter from 33cdd8ef31dc to d5ae7839620b (38 revisions) flutter/packages#9314

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2025

7bfcb2f Normalize BottomAppBarTheme (continue) (flutter/flutter#168966)

61203cb

engine-flutter-autoroll mentioned this pull request May 23, 2025

Roll Flutter from 33cdd8ef31dc to 85564cbba9e7 (39 revisions) flutter/packages#9315

Merged

Piinks mentioned this pull request May 23, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

7bfcb2f Normalize BottomAppBarTheme (continue) (flutter/flutter#168966)

a66d150

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

7bfcb2f Normalize BottomAppBarTheme (continue) (flutter/flutter#168966)

dce3c83

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

7bfcb2f Normalize BottomAppBarTheme (continue) (flutter/flutter#168966)

b8a3f66

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

7bfcb2f Normalize BottomAppBarTheme (continue) (flutter/flutter#168966)

4bdc3bb

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

7bfcb2f Normalize BottomAppBarTheme (continue) (flutter/flutter#168966)

e6556d1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Normalize BottomAppBarTheme (continue) #168966

Normalize BottomAppBarTheme (continue) #168966

Uh oh!

huycozy commented May 16, 2025

Uh oh!

flutter-dashboard bot commented May 16, 2025

Uh oh!

stuartmorgan-g commented May 16, 2025

Uh oh!

QuncCccccc left a comment

Uh oh!

huycozy commented May 21, 2025

Uh oh!

QuncCccccc commented May 21, 2025

Uh oh!

auto-submit bot commented May 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Normalize BottomAppBarTheme (continue) #168966

Normalize BottomAppBarTheme (continue) #168966

Uh oh!

Conversation

huycozy commented May 16, 2025

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented May 16, 2025

Uh oh!

stuartmorgan-g commented May 16, 2025

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

huycozy commented May 21, 2025

Uh oh!

QuncCccccc commented May 21, 2025

Uh oh!

auto-submit bot commented May 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants