[Widget Inspector] Clean-up changes in PR #167677 #168488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
commented
May 7, 2025
| import 'scrollbar.dart'; | ||
| import 'theme.dart'; | ||
| import 'theme_data.dart'; | ||
| import 'theme_data.dart' show MaterialTapTargetSize; |
Member
Author
There was a problem hiding this comment.
Although theme.dart exports ThemeData, it doesn't export the MaterialTapTargetSize (which is the reason for the added import to theme_data.dart)
Contributor
There was a problem hiding this comment.
Ah, I see! Maybe it should then. I looked around and noticed it is used multiple times like this. Can you change theme.dart to also export MaterialTapTargetSize as well instead?
Piinks
approved these changes
May 7, 2025
Contributor
Piinks
left a comment
There was a problem hiding this comment.
LGTM! Thank you for following up on this. 🙏 💙
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 9, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 9, 2025
flutter/flutter@02d8c1a...83082c1 2025-05-08 21270878+elliette@users.noreply.github.com [Widget Inspector] Clean-up changes in PR #167677 (flutter/flutter#168488) 2025-05-08 30870216+gaaclarke@users.noreply.github.com Increased the limit where we start chopping off the end of blurs (flutter/flutter#168109) 2025-05-08 aam@google.com Roll to Dart SDK 3.9 Beta 1 (flutter/flutter#168559) 2025-05-08 chris@bracken.jp Rename apple -> darwin across our buildroot (flutter/flutter#168558) 2025-05-08 jessiewong401@gmail.com Update Engine to Android 16 (API 36) (flutter/flutter#166796) 2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from 43ae814d2d95 to efccaeb08b8d (5 revisions) (flutter/flutter#168554) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
flutter/flutter@02d8c1a...83082c1 2025-05-08 21270878+elliette@users.noreply.github.com [Widget Inspector] Clean-up changes in PR #167677 (flutter/flutter#168488) 2025-05-08 30870216+gaaclarke@users.noreply.github.com Increased the limit where we start chopping off the end of blurs (flutter/flutter#168109) 2025-05-08 aam@google.com Roll to Dart SDK 3.9 Beta 1 (flutter/flutter#168559) 2025-05-08 chris@bracken.jp Rename apple -> darwin across our buildroot (flutter/flutter#168558) 2025-05-08 jessiewong401@gmail.com Update Engine to Android 16 (API 36) (flutter/flutter#166796) 2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from 43ae814d2d95 to efccaeb08b8d (5 revisions) (flutter/flutter#168554) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
flutter/flutter@02d8c1a...83082c1 2025-05-08 21270878+elliette@users.noreply.github.com [Widget Inspector] Clean-up changes in PR #167677 (flutter/flutter#168488) 2025-05-08 30870216+gaaclarke@users.noreply.github.com Increased the limit where we start chopping off the end of blurs (flutter/flutter#168109) 2025-05-08 aam@google.com Roll to Dart SDK 3.9 Beta 1 (flutter/flutter#168559) 2025-05-08 chris@bracken.jp Rename apple -> darwin across our buildroot (flutter/flutter#168558) 2025-05-08 jessiewong401@gmail.com Update Engine to Android 16 (API 36) (flutter/flutter#166796) 2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from 43ae814d2d95 to efccaeb08b8d (5 revisions) (flutter/flutter#168554) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #167677
Addresses clean-up comments in cherry-pick: #168386