Skip to content

Revert "Changes the offset computation to first item for RenderSliverMainAxisGroup" (#154688) #168450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Jun 3, 2025
Merged

Revert "Changes the offset computation to first item for RenderSliverMainAxisGroup" (#154688) #168450

auto-submit merged 3 commits into from
Jun 3, 2025

Conversation

@navaronbracke
Copy link
Contributor

@navaronbracke navaronbracke commented May 7, 2025

This PR reverts commit 8cc862c

I also added a regression test for #167801 so that we do not break that again when revisiting the issue that is reopened.

Fixes #167801
Reopens #154615

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels May 7, 2025
@navaronbracke navaronbracke mentioned this pull request May 7, 2025
Closed
@navaronbracke navaronbracke force-pushed the sliver_group_revert branch from 6c64457 to 76b75c1 Compare May 7, 2025 07:59
@justinmc justinmc requested a review from victorsanni May 13, 2025 22:13
victorsanni
victorsanni approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@victorsanni victorsanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@navaronbracke
Copy link
Contributor Author

navaronbracke commented May 14, 2025 •
edited
Loading

@victorsanni Does this need a rebase? Google Testing seems to fail for some reason.

Edit: rebased to see if this fixes that.
Edit 2: It seems to not have been fixed after a rebase. Can you take a look?

@navaronbracke navaronbracke force-pushed the sliver_group_revert branch from 76b75c1 to 463612d Compare May 15, 2025 08:05
@justinmc
Copy link
Contributor

justinmc commented May 20, 2025

Google test failures may be related to: #169159. I'll try a rerun but we might have to wait until that is resolved.

justinmc
justinmc approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert LGTM 👍 . Looks like Google tests are good now.

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 3, 2025
Merged via the queue into flutter:master with commit 2eeb6af Jun 3, 2025
75 of 76 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2025
@navaronbracke navaronbracke deleted the sliver_group_revert branch June 4, 2025 06:36
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
3bcff75 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
242a46a 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
b20e867 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
6309a23 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
a5c4ee0 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
ea5a915 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
cb7549e 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
ecfeb63 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
79e1045 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
48167f3 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
592de90 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
bbe026c 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
f923f4a 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
@navaronbracke
Copy link
Contributor Author

navaronbracke commented Jun 7, 2025

@justinmc With the revert having landed, #154615 should be reopened, but that thread is locked by the bot it seems.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
89fce89 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
c505e30 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
04e6b2c 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
2dcc660 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
2eeb6af Revert "Changes the offset computation to first item for Rend…
66e8efa 
…erSliverMainAxisGroup" (#154688) (flutter/flutter#168450)
@huycozy huycozy mentioned this pull request Oct 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@victorsanni victorsanni victorsanni approved these changes

Assignees

No one assigned

Labels

f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

Google Testing Queue
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nesting SliverMainAxisGroups breaks Scrollable.ensureVisible

3 participants

@navaronbracke @justinmc @victorsanni