Add test for stack trace mapping and test expression eval tests using DDC library bundle format #168017

srujzs · 2025-04-29T21:43:38Z

The bootstrap script utilizes a DDC utility function that maps paths to their module name in order for the stack traces to show the Dart paths and not the JS paths. This gets utilized in some stack tracing functionalities like StackTrace.current. We should test that the mapping is correct and we expect the correct stack traces.

These tests should be run with the DDC library bundle format as well, so refactors them into shared code.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

Once we have the CL to emit inlined source maps for the DDC library bundle format landed, we can fork this test and run it with that format as well.

The bootstrap script utilizes a DDC utility function that maps paths to their module name in order for the stack traces to show the Dart paths and not the JS paths. This gets utilized in some stack tracing functionalities like StackTrace.current. We should test that the mapping is correct and we expect the correct stack traces.

nshahan

LGTM with one question about the stack frames.

packages/flutter_tools/test/web.shard/expression_evaluation_web_test.dart

srujzs · 2025-05-01T23:53:35Z

I updated the test to use a regex to check for the SDK stack frame so we know we're getting a Dart file and not a JS file (as get current appears in both stack traces).

…ibrary bundle formats test it

flutter-dashboard · 2025-05-09T01:37:06Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #168017 at sha c0baa3e

auto-submit · 2025-05-09T02:47:26Z

autosubmit label was removed for flutter/flutter/168017, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…ts using DDC library bundle format (flutter/flutter#168017)

flutter/flutter@54de32d...336a7ec 2025-05-13 sokolovskyi.konstantin@gmail.com Add assert for index parameter in IndexedStack. (flutter/flutter#167757) 2025-05-13 jessiewong401@gmail.com Fixed Android Lint Errors (flutter/flutter#168613) 2025-05-13 bruno.leroux@gmail.com Tab bar theme and dialog theme documentation cleanup (flutter/flutter#168724) 2025-05-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 6vjKe0bfYDVaECqBL... to 6J81agNhuK4q255Jj... (flutter/flutter#168712) 2025-05-12 romanejaquez@gmail.com Make the barrier panel on the Material Drawer non-dismissible (flutter/flutter#164810) 2025-05-12 engine-flutter-autoroll@skia.org Roll ICU from c9fb4b3a6fb5 to b929596baebf (5 revisions) (flutter/flutter#168691) 2025-05-12 bruno.leroux@gmail.com Fix DropdownButtonFormField icon not vertically centered (flutter/flutter#163205) 2025-05-12 jmccandless@google.com Android home/end keyboard shortcut support (flutter/flutter#168184) 2025-05-12 matanlurey@users.noreply.github.com Update `TESTOWNERS` for Android PV tests (flutter/flutter#168694) 2025-05-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 0bea6379f654 to 645d04a7a964 (14 revisions) (flutter/flutter#168679) 2025-05-12 chinmaygarde@google.com [Impeller] libImpeller: Allow setting text decorations. (flutter/flutter#168408) 2025-05-12 34871572+gmackall@users.noreply.github.com Error when trying to use old HC mode when HCPP is enabled (flutter/flutter#168027) 2025-05-12 victorsanniay@gmail.com Nav bar back label is not clipped mid-transition (flutter/flutter#168194) 2025-05-12 58529443+srujzs@users.noreply.github.com Add test for stack trace mapping and test expression eval tests using DDC library bundle format (flutter/flutter#168017) 2025-05-12 victorsanniay@gmail.com Remove CupertinoSliverNavigationBar background box when large title is extended (flutter/flutter#168407) 2025-05-12 1063596+reidbaker@users.noreply.github.com Label platform view modes using the unified naming scheme (flutter/flutter#168670) 2025-05-12 engine-flutter-autoroll@skia.org Roll Packages from 7814fab to 6a28ad9 (2 revisions) (flutter/flutter#168669) 2025-05-12 matanlurey@users.noreply.github.com Update `Engine-artifacts.md` to reflect the new `engine.version` verifier (flutter/flutter#168413) 2025-05-12 engine-flutter-autoroll@skia.org Roll Skia from 9f9e1f37917e to c97451da059f (1 revision) (flutter/flutter#168671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ts using DDC library bundle format (flutter/flutter#168017)

srujzs requested a review from nshahan April 29, 2025 21:43

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 29, 2025

nshahan approved these changes May 1, 2025

View reviewed changes

packages/flutter_tools/test/web.shard/expression_evaluation_web_test.dart Outdated Show resolved Hide resolved

Check stack traces using regex for get current instead

f9fb593

srujzs added 2 commits May 8, 2025 17:19

Merge remote-tracking branch 'upstream/main' into stacktracetest

f320b14

Move expression evaluation test to common and have both AMD and DDC l…

c0baa3e

…ibrary bundle formats test it

srujzs changed the title ~~Add test for stack trace mapping~~ Add test for stack trace mapping and test expression eval tests using DDC library bundle format May 9, 2025

srujzs added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2025

flutter-dashboard bot added the will affect goldens Changes to golden files label May 9, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2025

srujzs added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2025

Merge remote-tracking branch 'upstream/main' into stacktracetest

8c6728f

auto-submit bot added this pull request to the merge queue May 12, 2025

Merged via the queue into flutter:master with commit 2871340 May 12, 2025
141 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2025

2871340 Add test for stack trace mapping and test expression eval tes…

5a4e08b

…ts using DDC library bundle format (flutter/flutter#168017)

engine-flutter-autoroll mentioned this pull request May 13, 2025

Roll Flutter from 54de32d6e159 to 358b07268828 (18 revisions) flutter/packages#9244

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2025

2871340 Add test for stack trace mapping and test expression eval tes…

c94b9ba

…ts using DDC library bundle format (flutter/flutter#168017)

engine-flutter-autoroll mentioned this pull request May 13, 2025

Roll Flutter from 54de32d6e159 to 336a7ecf7b40 (19 revisions) flutter/packages#9246

Merged

matanlurey mentioned this pull request May 22, 2025

Restore DDC Expression Evaluation tests (#168017): Causing suite timeouts #169304

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

2871340 Add test for stack trace mapping and test expression eval tes…

6650d0b

…ts using DDC library bundle format (flutter/flutter#168017)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

2871340 Add test for stack trace mapping and test expression eval tes…

1d1abd4

…ts using DDC library bundle format (flutter/flutter#168017)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

2871340 Add test for stack trace mapping and test expression eval tes…

583e983

…ts using DDC library bundle format (flutter/flutter#168017)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

2871340 Add test for stack trace mapping and test expression eval tes…

7d7629b

…ts using DDC library bundle format (flutter/flutter#168017)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

2871340 Add test for stack trace mapping and test expression eval tes…

0aed3df

…ts using DDC library bundle format (flutter/flutter#168017)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add test for stack trace mapping and test expression eval tests using DDC library bundle format #168017

Add test for stack trace mapping and test expression eval tests using DDC library bundle format #168017

srujzs commented Apr 29, 2025 •

edited

Loading

Uh oh!

nshahan left a comment

Uh oh!

Uh oh!

srujzs commented May 1, 2025

Uh oh!

flutter-dashboard bot commented May 9, 2025

Uh oh!

auto-submit bot commented May 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add test for stack trace mapping and test expression eval tests using DDC library bundle format #168017

Add test for stack trace mapping and test expression eval tests using DDC library bundle format #168017

Conversation

srujzs commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

nshahan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

srujzs commented May 1, 2025

Uh oh!

flutter-dashboard bot commented May 9, 2025

Uh oh!

auto-submit bot commented May 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

srujzs commented Apr 29, 2025 •

edited

Loading