Revert "[Impeller] Make incremental builds faster when tinkering on the compiler." by chinmaygarde · Pull Request #167965 · flutter/flutter

chinmaygarde · 2025-04-28T22:46:44Z

Makes things slower if the sources are newer than the outputs.

…he compi…" This reverts commit 5896cef.

flar

RSLGTM

auto-submit · 2025-04-28T23:31:11Z

autosubmit label was removed for flutter/flutter/167965, because - The status or check suite Windows build_tests_6_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

…ing on the compiler." (flutter/flutter#167965)

…he compiler." (flutter#167965) Reverts flutter#167492 Makes things slower if the sources are newer than the outputs.

…ing on the compiler." (flutter/flutter#167965)

Revert "[Impeller] Make incremental builds faster when tinkering on t…

0c4cedc

…he compi…" This reverts commit 5896cef.

github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Apr 28, 2025

flar approved these changes Apr 28, 2025

View reviewed changes

chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025

chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2025

auto-submit Bot added this pull request to the merge queue Apr 29, 2025

Merged via the queue into master with commit f9f6953 Apr 29, 2025

auto-submit Bot deleted the revert-167492-fasterincbuilds branch April 29, 2025 04:59

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2025

engine-flutter-autoroll mentioned this pull request Apr 29, 2025

Roll Flutter from cfb887cd5f41 to 04616f8dde3f (137 revisions) flutter/packages#9172

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

9c8f0db

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll mentioned this pull request Apr 29, 2025

Roll Flutter from cfb887cd5f41 to a46bf190ef7d (138 revisions) flutter/packages#9173

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

40bf589

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll mentioned this pull request Apr 29, 2025

Roll Flutter from cfb887cd5f41 to a46bf190ef7d (138 revisions) flutter/packages#9174

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

3b16b8f

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll mentioned this pull request Apr 30, 2025

Roll Flutter from cfb887cd5f41 to fffe394cdd2d (158 revisions) flutter/packages#9179

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

0064dec

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll mentioned this pull request Apr 30, 2025

Roll Flutter from cfb887cd5f41 to fffe394cdd2d (158 revisions) flutter/packages#9180

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

d3c1337

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

a03ac46

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

6fec97c

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

02614df

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

2c708ce

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

5586eab

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

3eccd6d

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

2f09eea

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

fa34324

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

4bd33c2

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

661d6c0

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

5a187f7

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

407f320

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

e5bee3a

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

c19b1c8

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

6a97b39

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

f84ca85

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

5c67d46

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

9cae59b

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

bddb2ae

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

faf17b2

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

365aba2

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

d8cfbd0

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

9395ad2

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

2ea9a6b

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

c27e54a

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

c198b22

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

a6ff339

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

a1f4dda

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

d2ec229

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

5187d6e

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

1e689ce

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

2e88e5e

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

8475c08

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

3050b58

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

58ead15

…ing on the compiler." (flutter/flutter#167965)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

f9f6953 Revert "[Impeller] Make incremental builds faster when tinker…

dacd394

…ing on the compiler." (flutter/flutter#167965)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert "[Impeller] Make incremental builds faster when tinkering on the compiler."#167965

Revert "[Impeller] Make incremental builds faster when tinkering on the compiler."#167965
auto-submit[bot] merged 1 commit into
masterfrom
revert-167492-fasterincbuilds

chinmaygarde commented Apr 28, 2025

Uh oh!

flar left a comment

Uh oh!

auto-submit Bot commented Apr 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

chinmaygarde commented Apr 28, 2025

Uh oh!

flar left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Apr 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants