Add ConnectionCollection and Swift test by cbracken · Pull Request #167962 · flutter/flutter

cbracken · 2025-04-28T22:13:46Z

This rewrites the ConnectionCollection C++ class and its test to Swift. This ensures we're successfully able to write/run XCTests written in Swift.

It also adds new tests for ConnectionCollection:

Verifies connection IDs are > 0.
Verifies connection IDs are unique.
Verifies the IDs of error connections are as specified.

Issue: #144791
Issue: #167592

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

cbracken · 2025-04-28T22:14:08Z

This is currently stacked on top of #167958. The second commit is the commit to review.

cbracken · 2025-04-28T22:19:46Z

-class ConnectionCollection {
- public:
-  typedef int64_t Connection;
-  static const Connection kInvalidConnection = 0;


IsValidConnection below was unused, which makes this transitively unused.

cbracken · 2025-04-28T22:20:39Z

-#define FLUTTER_SHELL_PLATFORM_DARWIN_IOS_FRAMEWORK_SOURCE_CONNECTION_COLLECTION_H_
-
-#include <cstdint>
-#include <map>


We should have been using std::unordered_map which has lower overhead when ordering is not required.

This rewrites the ConnectionCollection C++ class and its test to Swift. This is to ensure we're successfully able to write/run XCTests written in Swift. It also adds a new test for ConnectionCollection that verifies the IDs of error connections. Issue: flutter#167592

auto-submit · 2025-04-29T00:52:26Z

autosubmit label was removed for flutter/flutter/167962, because - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label.

This rewrites the ConnectionCollection C++ class and its test to Swift. This ensures we're successfully able to write/run XCTests written in Swift. It also adds new tests for ConnectionCollection: * Verifies connection IDs are > 0. * Verifies connection IDs are unique. * Verifies the IDs of error connections are as specified. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

cbracken requested review from LouiseHsu, hellohuanlin and vashworth April 28, 2025 22:13

cbracken requested a review from a team as a code owner April 28, 2025 22:13

github-actions Bot added platform-ios iOS applications specifically engine flutter/engine related. See also e: labels. team-ios Owned by iOS platform team labels Apr 28, 2025

cbracken force-pushed the connection_collection branch 3 times, most recently from e6cf0e3 to 0eacd5b Compare April 28, 2025 22:18

cbracken commented Apr 28, 2025

View reviewed changes

LouiseHsu reviewed Apr 28, 2025

View reviewed changes

Comment thread engine/src/flutter/shell/platform/darwin/ios/framework/Source/ConnectionCollection.swift Outdated

cbracken force-pushed the connection_collection branch from 0eacd5b to 2e4144f Compare April 28, 2025 22:33

LouiseHsu approved these changes Apr 28, 2025

View reviewed changes

hellohuanlin approved these changes Apr 28, 2025

View reviewed changes

cbracken added 3 commits April 28, 2025 16:44

review: use abs()

6a11887

Review: cleanups

4b946bc

cbracken force-pushed the connection_collection branch from 4994b0e to 4b946bc Compare April 28, 2025 23:44

cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025

Add test for unique IDs

004a6b0

cbracken force-pushed the connection_collection branch from f5fcdb7 to 004a6b0 Compare April 28, 2025 23:57

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2025

Licences

2843844

cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2025

auto-submit Bot added this pull request to the merge queue Apr 29, 2025

Merged via the queue into flutter:master with commit b0e52e5 Apr 29, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

97022df

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

aca9a7f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

9b32f1e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

aa5d43e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

e3d85cc

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

cd52b9c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

20dac7d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

e46638b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

3ba7c2a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

51adde6

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

7c8790e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

ea98d4a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

d7896f0

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

6dc2e6f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

7fc7113

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

83d280b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

06e8ec2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

cec1a6b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

00d0084

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

335eb7c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

f012df2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

d7bee01

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

025008e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

39a7934

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

17c7563

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

9ae3f03

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

fe8bbe1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

24c6e87

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

b0e52e5 Add ConnectionCollection and Swift test (flutter/flutter#167962)

b4fc52f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add ConnectionCollection and Swift test#167962

Add ConnectionCollection and Swift test#167962
auto-submit[bot] merged 5 commits into
flutter:masterfrom
cbracken:connection_collection

cbracken commented Apr 28, 2025 •

edited

Loading

Uh oh!

cbracken commented Apr 28, 2025

Uh oh!

cbracken Apr 28, 2025

Uh oh!

cbracken Apr 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

auto-submit Bot commented Apr 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

cbracken commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

cbracken commented Apr 28, 2025

Uh oh!

cbracken Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

cbracken Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

auto-submit Bot commented Apr 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cbracken commented Apr 28, 2025 •

edited

Loading