Skip to content

Fix late variable non-assignment when WASM is enabled#167954

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
matanlurey:fix-late-vars-wasm-build
Apr 29, 2025
Merged

Fix late variable non-assignment when WASM is enabled#167954
auto-submit[bot] merged 4 commits into
flutter:masterfrom
matanlurey:fix-late-vars-wasm-build

Conversation

@matanlurey

@matanlurey matanlurey commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

Closes #167887.

Appears to be a regression as of #165006. Might be worth CPing?

@matanlurey matanlurey requested review from bkonyi and srujzs April 28, 2025 19:59
@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 28, 2025
@srujzs

srujzs commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

Ouch, thanks for catching that. If I understand correctly, these logs occur every time the app is run with Wasm? If so, I agree we should cherry-pick this (or just the relevant resident_web_runner.dart changes if the change is too large).

@matanlurey

matanlurey commented Apr 28, 2025

Copy link
Copy Markdown
Contributor Author

Ah mistaken branch point, my bad, the change is quite small. Will fix.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025
@auto-submit auto-submit Bot added this pull request to the merge queue Apr 29, 2025
Merged via the queue into flutter:master with commit f7d7633 Apr 29, 2025
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2025
@matanlurey matanlurey added the cp: beta cherry pick this pull request to beta release candidate branch label Apr 29, 2025
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull request Apr 29, 2025
@matanlurey
Fix late variable non-assignment when WASM is enabled (flutter#167954)
9e7c11e 
Closes flutter#167887.

Appears to be a regression as of
flutter#165006. Might be worth CPing?
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
56014c1 
…ter/flutter#167954)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
6d62373 
…ter/flutter#167954)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
aa7f5b0 
…ter/flutter#167954)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
c3a688c 
…ter/flutter#167954)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
ed50150 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
83ab61d 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
c220359 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
b8a49a6 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
c4cbf67 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
f52c6c5 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
a8712be 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
266afaf 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
0e6eae7 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
48371a2 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
6190e1e 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
fc7e385 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
22805af 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
bc002f7 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
9150d4c 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
8d147b8 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
36d416c 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
af52b86 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
01065d7 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
ff2847a 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
108ea00 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
ff315ec 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
5257bb3 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
1b7c313 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
57314e8 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
d59699d 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
1134637 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
9789750 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
740a3cf 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
2d0c10f 
…ter/flutter#167954)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@matanlurey @romanejaquez
Fix late variable non-assignment when WASM is enabled (flutter#167954)
137f213 
Closes flutter#167887.

Appears to be a regression as of
flutter#165006. Might be worth CPing?
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
70e9845 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
6c52396 
…ter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
f7d7633 Fix late variable non-assignment when WASM is enabled (flut…
4bced17 
…ter/flutter#167954)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srujzs srujzs srujzs approved these changes
@bkonyi bkonyi Awaiting requested review from bkonyi

Assignees

No one assigned

Labels

cp: beta cherry pick this pull request to beta release candidate branch tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[tool_crash] LateError: (#0 LateError._throwLocalNotInitialized (dart:_internal-patch/internal_patch.dart:214:5))

2 participants

@matanlurey @srujzs