Skip to content

--use-existing-app defaults to --keep-app-running if not specified.#167742

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
matanlurey:fix-use-existing-app-driver
Apr 28, 2025
Merged

--use-existing-app defaults to --keep-app-running if not specified.#167742
auto-submit[bot] merged 1 commit into
flutter:masterfrom
matanlurey:fix-use-existing-app-driver

Conversation

@matanlurey

@matanlurey matanlurey commented Apr 24, 2025

Copy link
Copy Markdown
Contributor

Closes #166755.

@matanlurey matanlurey requested a review from bkonyi April 24, 2025 18:29
@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 24, 2025
bkonyi
bkonyi approved these changes Apr 28, 2025
View reviewed changes
Comment thread packages/flutter_tools/lib/src/commands/drive.dart
);
}

static const String _kKeepAppRunning = 'keep-app-running';

@bkonyi bkonyi Apr 28, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making constants for flag names!

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025
@auto-submit auto-submit Bot added this pull request to the merge queue Apr 28, 2025
Merged via the queue into flutter:master with commit 90d18c6 Apr 28, 2025
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
e32c89c 
…specified. (flutter/flutter#167742)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
390e97e 
…specified. (flutter/flutter#167742)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
9be307a 
…specified. (flutter/flutter#167742)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
77611a0 
…specified. (flutter/flutter#167742)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
6a134d9 
…specified. (flutter/flutter#167742)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
dfaa51a 
…specified. (flutter/flutter#167742)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
035db96 
…specified. (flutter/flutter#167742)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
cb5a671 
…specified. (flutter/flutter#167742)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
43a922c 
…specified. (flutter/flutter#167742)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
22d9434 
…specified. (flutter/flutter#167742)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
7f99371 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
bb29c41 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
db61dff 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
512e2d8 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
b104660 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
9f87582 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
38b0657 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
0739de1 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
6fe31d5 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
eed5da0 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
58c8704 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
7ddbdf8 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
278f4f9 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
e22952e 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
801206e 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
05d89ad 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
b98a227 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
56ab06b 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
8f93a6d 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
12a6086 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
78b7747 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
7912815 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
d848acd 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
14c3036 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
51976bf 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
c7337d3 
…specified. (flutter/flutter#167742)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@matanlurey @romanejaquez
--use-existing-app defaults to --keep-app-running if not specifie…
51a0c56 
…d. (flutter#167742)

Closes flutter#166755.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
716a07c 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
59eb3c6 
…specified. (flutter/flutter#167742)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
90d18c6 --use-existing-app defaults to --keep-app-running if not …
da8cd37 
…specified. (flutter/flutter#167742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flutter drive --use-existing-app exits application (contrary to documentation)

2 participants

@matanlurey @bkonyi