Adding support for macrobenchmarking with "flutter run" by Markzipan · Pull Request #167692 · flutter/flutter

Markzipan · 2025-04-23T22:53:57Z

Notable changes:

Allows macrobenchmarks to run via flutter run.
Splits macrobenchmarking between "orchestration logic" and "app serving" (served on separate ports on the same machine to keep the scheme consistent with the flutter build path).
Adds an intercepted entrypoint for web benchmarks. We can't pass flags to the app since it's not supported, so I've hard-coded the orchestration server's port.
Adding logic to connect to an existing Chrome debugger instance (vs spawning one) for benchmarks.

eyebrowsoffire

LGTM! (with one nitpick)

eyebrowsoffire · 2025-04-25T16:49:45Z

+        await flutterRunProcess.stdin.flush();
+        // Give the process a couple of seconds to exit and run shutdown hooks
+        // before sending kill signal.
+        await Future<void>.delayed(const Duration(seconds: 2));


Instead of unconditionally waiting and killing every time, instead we could do like:

await flutterRunProcess.exitCode.timeout(const Duration(seconds: 2), onTimeout: () => flutterRunProcess.kill(io.ProcessSignal.sigint));

Or something like that.

Sounds good - added! Also added some Chrome flags that'll let the process run backgrounded.

…o ddc_benchmarks_fix

auto-submit · 2025-04-28T17:58:08Z

autosubmit label was removed for flutter/flutter/167692, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

…ter/flutter#167692)

Notable changes: * Allows macrobenchmarks to run via `flutter run`. * Splits macrobenchmarking between "orchestration logic" and "app serving" (served on separate ports on the same machine to keep the scheme consistent with the `flutter build` path). * Adds an intercepted entrypoint for web benchmarks. We can't pass flags to the app since it's not supported, so I've hard-coded the orchestration server's port. * Adding logic to connect to an existing Chrome debugger instance (vs spawning one) for benchmarks.

…ter/flutter#167692)

Adding support for macrobenchmarking with "flutter run"

00e5fc5

Markzipan requested a review from matanlurey as a code owner April 23, 2025 22:53

Markzipan added 5 commits April 23, 2025 15:55

Merge remote-tracking branch 'origin/main' into ddc_benchmarks_fix

b95b727

fixing todo

11ff780

fixing header

2b3c01c

Merge branch 'master' into ddc_benchmarks_fix

b200add

Merge branch 'master' into ddc_benchmarks_fix

809138d

eyebrowsoffire approved these changes Apr 25, 2025

View reviewed changes

Markzipan added 3 commits April 25, 2025 15:16

Adding background chrome flags and updating exit logic

5035844

Merge branch 'ddc_benchmarks_fix' of github.com:Markzipan/flutter int…

bd52b5d

…o ddc_benchmarks_fix

Merge branch 'master' into ddc_benchmarks_fix

0155333

kevmoo reviewed Apr 25, 2025

View reviewed changes

Comment thread dev/benchmarks/macrobenchmarks/lib/web_benchmarks.dart

eyebrowsoffire approved these changes Apr 28, 2025

View reviewed changes

Merge branch 'master' into ddc_benchmarks_fix

6f350be

yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025

Merge branch 'master' into ddc_benchmarks_fix

f1270d4

yjbanov approved these changes Apr 28, 2025

View reviewed changes

yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025

auto-submit Bot added this pull request to the merge queue Apr 28, 2025

Merged via the queue into flutter:master with commit 2a3e27f Apr 29, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2025

engine-flutter-autoroll mentioned this pull request Apr 29, 2025

Roll Flutter from cfb887cd5f41 to 04616f8dde3f (137 revisions) flutter/packages#9172

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

681aff0

…ter/flutter#167692)

engine-flutter-autoroll mentioned this pull request Apr 29, 2025

Roll Flutter from cfb887cd5f41 to a46bf190ef7d (138 revisions) flutter/packages#9173

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

21d17a6

…ter/flutter#167692)

engine-flutter-autoroll mentioned this pull request Apr 29, 2025

Roll Flutter from cfb887cd5f41 to a46bf190ef7d (138 revisions) flutter/packages#9174

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

c4b0e2d

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

d94a48b

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

e975b77

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

3e5272c

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

78783e3

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

ce7470b

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

019eaad

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

9187733

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

e9f1772

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

1c6eac3

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

4e4329c

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

122da85

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

28c999f

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

6ec2c10

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

c3e7706

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

9ae1136

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

0f25e86

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

af283f1

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

dafe3e4

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

8f1dc6e

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

b724e63

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

5c9cd4b

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

eef1876

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

a399ecc

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

624528b

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

7ccccd0

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

90be805

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

81ebec8

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

f7defe8

…ter/flutter#167692)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

2a3e27f Adding support for macrobenchmarking with "flutter run" (flut…

22240ae

…ter/flutter#167692)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding support for macrobenchmarking with "flutter run"#167692

Adding support for macrobenchmarking with "flutter run"#167692
auto-submit[bot] merged 11 commits into
flutter:masterfrom
Markzipan:ddc_benchmarks_fix

Markzipan commented Apr 23, 2025 •

edited

Loading

Uh oh!

eyebrowsoffire left a comment •

edited

Loading

Uh oh!

eyebrowsoffire Apr 25, 2025

Uh oh!

Markzipan Apr 25, 2025

Uh oh!

Uh oh!

auto-submit Bot commented Apr 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Markzipan commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eyebrowsoffire left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eyebrowsoffire Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

Markzipan Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auto-submit Bot commented Apr 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Markzipan commented Apr 23, 2025 •

edited

Loading

eyebrowsoffire left a comment •

edited

Loading