Skip to content

Ignore stdout in WindowsTest.LaunchMainHasNoOutput #167583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 22, 2025
Merged

Ignore stdout in WindowsTest.LaunchMainHasNoOutput #167583

auto-submit merged 1 commit into from
Apr 22, 2025

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Apr 22, 2025

The stdout stream may receive expected output printed by Dart (specifically the message announcing the URL where the Dart VM service is listening)

See #167418

@jason-simmons
Ignore stdout in WindowsTest.LaunchMainHasNoOutput
9f1fa56 
The stdout stream may receive expected output printed by Dart (specifically
the message announcing the URL where the Dart VM service is listening)

See flutter#167418
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-windows Building on or for Windows specifically a: desktop Running on desktop labels Apr 22, 2025
@knopp
Copy link
Member

knopp commented Apr 22, 2025 •
edited
Loading

So, this makes sense, the default implementation of log_message_callback is using std::cout, and windows embedder doesn't override it, so it should appear in the rdbuf, but I've repeated the test 10000 times today and it never failed even though it should, so this does bother me a bit.

@knopp
Copy link
Member

knopp commented Apr 22, 2025

I see. In my case the VMService announcement is always printed after stdout_capture.Stop();. I think maybe better way to fix this would be to have a proper dart entry point and then wait until signalled and check that stdout only contains the vmservice announcement?

@knopp
Copy link
Member

knopp commented Apr 22, 2025

Actually, the VMService announcement gets printed after main, I'm not sure if there is a way to reliably wait for it except watching stdout. So maybe it's not really worth doing that.

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 22, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 22, 2025
Merged via the queue into flutter:master with commit cddd4ac Apr 22, 2025
179 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 22, 2025
@knopp knopp mentioned this pull request Apr 23, 2025
Merged
9 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
736b4a0 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
a87a768 
…lutter#167583)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2025
Closed
@loic-sharma
Copy link
Member

loic-sharma commented Apr 23, 2025

Thanks @jason-simmons!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
ccf6239 
…lutter#167583)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
8bf4502 
…lutter#167583)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
055be27 
…lutter#167583)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
0e72604 
…lutter#167583)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
2046239 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
a4e2d00 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
de16aca 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
0da7150 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
13e544b 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
5a6dfe9 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
82efc13 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
5946194 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
f4398fb 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
9dcc8bb 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
a887ffb 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
190068e 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
cae6e7f 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
712d9a1 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
7e5a462 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
51d41ac 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
b1e1bc9 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
73475c5 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
032adbc 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
ed26b67 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
6d20bbb 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
bf2a3d3 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
3adb4ac 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
f7a601a 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
e7d2593 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
ef7bac2 
…lutter#167583)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@jason-simmons @romanejaquez
Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter#167583)
96b4c1c 
The stdout stream may receive expected output printed by Dart
(specifically the message announcing the URL where the Dart VM service
is listening)

See flutter#167418
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
ffc2893 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
e13c124 
…lutter#167583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
cddd4ac Ignore stdout in WindowsTest.LaunchMainHasNoOutput (flutter/f…
d8ae04b 
…lutter#167583)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knopp knopp knopp approved these changes

@loic-sharma loic-sharma Awaiting requested review from loic-sharma

Assignees

No one assigned

Labels

a: desktop Running on desktop engine flutter/engine related. See also e: labels. platform-windows Building on or for Windows specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jason-simmons @knopp @loic-sharma