Skip to content

Forward mnemonics for compiled actions.#167511

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
chinmaygarde:mnemonic
Apr 28, 2025
Merged

Forward mnemonics for compiled actions.#167511
auto-submit[bot] merged 1 commit into
flutter:masterfrom
chinmaygarde:mnemonic

Conversation

@chinmaygarde

@chinmaygarde chinmaygarde commented Apr 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Previously, mnemonics specified in templates that used compiled_action and compiled_action_foreach would not be forwarded. This made actions like ImpellerC invocation unable to tag themselves. As Ninja builds progressed, only a mysterious ACTION label would be emitted for all ImpellerC edges. Now, the edges tag themselves.

@chinmaygarde
Forward mnemonics for compiled actions.
7d78b89 
Previously, mnemonics specific in templates that used compiled_action
and compiled_action_foreach would not be forwarded. This made actions
like ImpellerC invocation unable to tag themselves. As Ninja builds
progressed, only a mysterious ACTION label would be emitted for all
ImpellerC edges. Now, the edges tag themselves.
@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Apr 21, 2025
@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025
@auto-submit auto-submit Bot added this pull request to the merge queue Apr 28, 2025
Merged via the queue into flutter:master with commit c37156e Apr 28, 2025
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025
@chinmaygarde chinmaygarde deleted the mnemonic branch April 28, 2025 19:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
a39cc31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
d4a271b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
0e36e99
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
e20dee1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
22e82d7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
49406c6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
691d04d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
4b9dab9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
a76c4bf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
4eb9392
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
616ede2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
254ee10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
69017b4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
cbd6f01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
20cc61d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
a191c4b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
4ce4d57
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
2f04fde
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
2b0a225
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
ebe9663
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
a25a782
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
d80c12d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
3fbcba0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
60cfefb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
f784ab2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
24083b8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
4c40d78
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
64348e3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
dadc56d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
69c6136
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
e428d69
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
9f58153
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
6f2e377
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
fb22f52
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
634f0b1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
356514f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
b97c5ba
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
63595ca
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
0d5e6fd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
d4c0543
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@chinmaygarde @romanejaquez
Forward mnemonics for compiled actions. (flutter#167511)
a352aa4 
Previously, mnemonics specified in templates that used compiled_action
and compiled_action_foreach would not be forwarded. This made actions
like ImpellerC invocation unable to tag themselves. As Ninja builds
progressed, only a mysterious ACTION label would be emitted for all
ImpellerC edges. Now, the edges tag themselves.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
b2cd7fb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
5717923
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
c37156e Forward mnemonics for compiled actions. (flutter/flutter#167511)
cc71c17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chinmaygarde @jason-simmons