Skip to content

Move from getByName to getByType in gradle when fetching androidApp extension. #167415

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
reidbaker:i_165882_type_safe_getandroidappextension
Apr 21, 2025
Merged

Move from getByName to getByType in gradle when fetching androidApp extension. #167415
auto-submit[bot] merged 1 commit into
flutter:masterfrom
reidbaker:i_165882_type_safe_getandroidappextension

Conversation

@reidbaker

@reidbaker reidbaker commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

Fixes #165882

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@reidbaker reidbaker requested a review from gmackall April 18, 2025 18:34
@github-actions github-actions Bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 18, 2025
@reidbaker reidbaker requested a review from a team April 18, 2025 18:35
@AbdeMohlbi

AbdeMohlbi commented Apr 18, 2025

Copy link
Copy Markdown
Member

I like how groovy encourage using getByName while kotlin encourage getByType 📈📉

@reidbaker

reidbaker commented Apr 21, 2025

Copy link
Copy Markdown
Contributor Author

I like how groovy encourage using getByName while kotlin encourage getByType 📈📉

Yeah it is funny. I think it reflects the difference in the philosophy between the langauges. Groovy having very loose typesafety and preferring dynamic lookup makes sense to them. Whereas Kotlin with its strong typesafety, inheritance and aversion to casting prefers the typesafe approach.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2025
@auto-submit auto-submit Bot added this pull request to the merge queue Apr 21, 2025
@reidbaker reidbaker changed the title Move from getByName to getByType Move from getByName to getByType in gradle when fetching androidApp extension. Apr 21, 2025
Merged via the queue into flutter:master with commit 81db537 Apr 21, 2025
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
e8e3db2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
27d2df3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
62b0aa1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
ec44452
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
7800888
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
caab9d3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
122f282
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
0c44a47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
4c64d52
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
913f533
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
3f9be45
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
0c2161e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
be6575d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
e82b943
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
7f043c5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
f13ff5b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
c0401ac
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
bf0139b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
75f280a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
45148a0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
1fee0ea
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
e753485
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
83f098d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
3f407a9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
d708ea6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
4e5df39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
8862643
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
dcffc5f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
82cb535
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
323c06a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
f20831e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
c31f361
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
7720597
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
d3e5824
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
ec90c85
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
187f03b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
543b17d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
81db537 Move from getByName to getByType (flutter/flutter#167415)
f207127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmackall gmackall gmackall approved these changes

Assignees

No one assigned

Labels

platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update getAndroidExtensionOrNull to use findByType

3 participants

@reidbaker @AbdeMohlbi @gmackall