Refine developer message for announcement use#167127
Conversation
d0e88bd to
b7f3b73
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
gmackall
left a comment
There was a problem hiding this comment.
I think this is better but still feel that we should make it clear in this message alone that users might be seeing this warning as an indirect result of widgets they are using.
If you are unsure of why you are seeing this warning, it is possible that some Flutter widgets in use in your project are calling...
or similar
I changed it to this, lmk what you think: |
|
Sure, that lgtm |
b7f3b73 to
fb90649
Compare
|
test-exempt: Not supported by platform infrastructure. |
|
@ash2moon can this be merged? |
|
Yep, thanks for checking up on this! Just added the autosubmit but it looks like the tree is broken. Will autosubmit automatically submit once the tree is green again? |
Yes, it will |
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> Updates the developer message to include the flutter topline tracking bug to reduce confusion when using Flutter widgets that use announce. Example output from logcat: ``` Using AnnounceSemanticsEvent for accessibility is deprecated on Android. Migrate to using semantic properties for a more robust and accessible user experience. Flutter: If you are unsure why you are seeing this bug, it might be because you are using a widget that calls this method. See flutter#165510 for more details. Android documentation: https://developer.android.com/reference/android/view/View#announceForAccessibility(java.lang.CharSequence) ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Updates the developer message to include the flutter topline tracking bug to reduce confusion when using Flutter widgets that use announce.
Example output from logcat:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.