Skip to content

[web] denull some of text_editing.dart#166595

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
yjbanov:denull-text-editing
Apr 28, 2025
Merged

[web] denull some of text_editing.dart#166595
auto-submit[bot] merged 3 commits into
flutter:masterfrom
yjbanov:denull-text-editing

Conversation

@yjbanov

@yjbanov yjbanov commented Apr 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

According to

flutter/packages/flutter/lib/src/services/text_input.dart

Line 1086 in 485d6b8

Map<String, dynamic> toJSON() {
, the framework never sends null values for any of the fields. So there's no need for the engine to do all the null handling.

@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-web Web applications specifically labels Apr 4, 2025
eyebrowsoffire
eyebrowsoffire approved these changes Apr 7, 2025
View reviewed changes

@eyebrowsoffire eyebrowsoffire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yjbanov yjbanov force-pushed the denull-text-editing branch from 0ca501c to 488ba15 Compare April 17, 2025 21:10
mdebbar
mdebbar approved these changes Apr 18, 2025
View reviewed changes

@mdebbar mdebbar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Some tests are still unhappy. Probably a test still passing null in a framework message.

@yjbanov yjbanov force-pushed the denull-text-editing branch from 488ba15 to 68812d7 Compare April 21, 2025 21:29
@yjbanov yjbanov force-pushed the denull-text-editing branch from 947f42a to 6dc3bbd Compare April 22, 2025 21:35
@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 22, 2025
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2025
@auto-submit

auto-submit Bot commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/166595, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025
@auto-submit auto-submit Bot added this pull request to the merge queue Apr 28, 2025
Merged via the queue into flutter:master with commit c790bb1 Apr 28, 2025
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
70be1b5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
fb8a6ae
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
bdd4876
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
ece2835
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
49ea9f1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
9ffd2cf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
2b73ea7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
3d98b91
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
35bb3f4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
0e682c4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
e0e7e6a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
ba9ca5e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
fb1f994
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
b42816d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
510d22e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
dc58faf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
a491def
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
d67e232
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
744d5eb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
cab2dd4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
458fd58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
dd130ea
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
aa9e694
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
9187644
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
21e782b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
e3696a9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
dbac492
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
a0f59a5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
54fe5f4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
b933f9e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
4fb7281
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@yjbanov @mdebbar @romanejaquez
[web] denull some of text_editing.dart (flutter#166595)
ae675b7 
According to
https://github.com/flutter/flutter/blob/485d6b8ae388bd16186e78c37d21d6f505d155e2/packages/flutter/lib/src/services/text_input.dart#L1086,
the framework never sends null values for any of the fields. So there's
no need for the engine to do all the null handling.

---------

Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
449d997
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
e98aede
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
c790bb1 [web] denull some of text_editing.dart (flutter/flutter#166595)
e111796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdebbar mdebbar mdebbar approved these changes
@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yjbanov @mdebbar @eyebrowsoffire