Skip to content

Reland "[skwasm] Dynamic Threading" #166454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 2, 2025
Merged

Reland "[skwasm] Dynamic Threading" #166454

auto-submit merged 1 commit into from
Apr 2, 2025

Conversation

@eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented Apr 2, 2025

This is a reland of #164748, which was reverted here: #165350

It was reverted due to some issues in the flutter packages roller: #165347

The unit test in flutter/packages was modified to be more deterministic and less affected by minor timing differences: flutter/packages#8920

So this is basically being relanded without any significant changes, since the downstream tests have been fixed.

@eyebrowsoffire
Reland "[skwasm] Dynamic Threading"
2095101 
This is a reland of flutter#164748, which was
reverted here: flutter#165350

It was reverted due to some issues in the flutter packages roller: flutter#165347

The unit test in flutter/packages was modified to be more deterministic and less affected by minor timing differences: flutter/packages#8920

So this is basically being relanded without any significant changes, since the downstream tests have been fixed.
@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 2, 2025

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Apr 2, 2025
@eyebrowsoffire
Copy link
Contributor Author

eyebrowsoffire commented Apr 2, 2025

And to reiterate what was said in the original PR, this PR doesn't need to add more unit tests, since this doesn't actually change any functionality. Existing unit tests should be sufficient to ensure things are still working as expected after the change.

@eyebrowsoffire eyebrowsoffire requested a review from yjbanov April 2, 2025 17:01
@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 2, 2025
@matanlurey matanlurey removed this pull request from the merge queue due to a manual request Apr 2, 2025
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025
@eyebrowsoffire eyebrowsoffire added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Apr 2, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 2, 2025
Merged via the queue into flutter:master with commit 34ea67b Apr 2, 2025
175 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
34ea67b Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
873a9a5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
34ea67b Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
9338562
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
34ea67b Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
1c75c12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
34ea67b Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
6a0abd0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
34ea67b Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
685b820
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
34ea67b Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
8d075d7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
34ea67b Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
7f3830e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions) (#8996)
267ac7b 
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions)

flutter/flutter@a0b1b32...02f13c3

2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538)
2025-04-03 magder@google.com Update docs to debug the Android embedder (flutter/flutter#166170)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525)
2025-04-03 matej.knopp@gmail.com [macOS] Implement merged UI and platform thread (flutter/flutter#162883)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527)
2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514)
2025-04-03 dacoharkes@google.com [native_assets] Roll dependencies (flutter/flutter#166282)
2025-04-03 bruno.leroux@gmail.com Fix read only TextField focus traversal on macOS (flutter/flutter#166056)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499)
2025-04-03 34465683+rkishan516@users.noreply.github.com Migrate to Theme.brightnessOf method (flutter/flutter#163950)
2025-04-03 34465683+rkishan516@users.noreply.github.com Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393)
2025-04-03 victorsanniay@gmail.com Deprecate ExpansionTileController (flutter/flutter#166368)
2025-04-03 kalathiyadimil@gmail.com Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790)
2025-04-03 matanlurey@users.noreply.github.com Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455)
2025-04-03 katelovett@google.com Skip flaking scheduler test (flutter/flutter#166471)
2025-04-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166043)
2025-04-02 yjbanov@google.com [a11y] add SemanticsValidationResult (flutter/flutter#165935)
2025-04-02 58529443+srujzs@users.noreply.github.com Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295)
2025-04-02 engine-flutter-autoroll@skia.org Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484)
2025-04-02 30870216+gaaclarke@users.noreply.github.com Started pixel aligning hairlines (flutter/flutter#166351)
2025-04-02 47866232+chunhtai@users.noreply.github.com Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467)
2025-04-02 jacksongardner@google.com Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
2025-04-02 dkwingsmt@users.noreply.github.com [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045)
2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: Hero animation for page transition (flutter/flutter#164469)
2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675)
2025-04-02 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383)
2025-04-02 jonahwilliams@google.com [Impeller] cache for text shadows. (flutter/flutter#166228)
2025-04-02 34871572+gmackall@users.noreply.github.com Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
2025-04-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474)
2025-04-02 mit@google.com Update Roadmap (flutter/flutter#166332)
2025-04-02 matanlurey@users.noreply.github.com Update `CODEOWNERS` (flutter/flutter#166444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
@brian-superlist
Copy link

brian-superlist commented Apr 9, 2025 •
edited
Loading

@eyebrowsoffire Heya, sorry to necro this one, but we need to upgrade to one of the latest version of flutter for a project we're working on at Superlist. We noticed a big regression in performance with the tip of master and I performed a git bisect.

This commit turned out to be the culprit:

[34ea67b] Reland "[skwasm] Dynamic Threading" (#166454)

This drastically reduces performance for our web app on wasm mode (low fps). Happy to share more details or even a private / non-public demo over email or some other forum if you need more info.

If this is expected and you're working on updates, no worries :) Just wanted to flag early.

@eyebrowsoffire
Copy link
Contributor Author

eyebrowsoffire commented Apr 9, 2025

@eyebrowsoffire Heya, sorry to necro this one, but we need to upgrade to one of the latest version of flutter for a project we're working on at Superlist. We noticed a big regression in performance with the tip of master and I performed a git bisect.

This commit turned out to be the culprit:

[34ea67b] Reland "[skwasm] Dynamic Threading" (#166454)

This drastically reduces performance for our web app on wasm mode (low fps). Happy to share more details or even a private / non-public demo over email or some other forum if you need more info.

If this is expected and you're working on updates, no worries :) Just wanted to flag early.

@brian-superlist Thanks for letting me know. A performance regression is not expected with this change. Would you mind filing an issue against flutter/flutter and assigning me to it to track this? It would be very helpful to get a Chrome profile of you reproducing the slowness, and ideally one from before the regression that is doing the same thing so I can compare.

@brian-superlist brian-superlist mentioned this pull request Apr 10, 2025
Closed
@brian-superlist
Copy link

brian-superlist commented Apr 10, 2025

Thanks! New issues with repro steps here: #166905

CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions) (#8996)
57f42e1 
Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions)

flutter/flutter@a0b1b32...02f13c3

2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from d10d5af to 95f8e65 (3 revisions) (flutter/flutter#166542)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538)
2025-04-03 magder@google.com Update docs to debug the Android embedder (flutter/flutter#166170)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525)
2025-04-03 matej.knopp@gmail.com [macOS] Implement merged UI and platform thread (flutter/flutter#162883)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527)
2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 0d5d57b to d10d5af (31 revisions) (flutter/flutter#166457)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514)
2025-04-03 dacoharkes@google.com [native_assets] Roll dependencies (flutter/flutter#166282)
2025-04-03 bruno.leroux@gmail.com Fix read only TextField focus traversal on macOS (flutter/flutter#166056)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499)
2025-04-03 34465683+rkishan516@users.noreply.github.com Migrate to Theme.brightnessOf method (flutter/flutter#163950)
2025-04-03 34465683+rkishan516@users.noreply.github.com Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393)
2025-04-03 victorsanniay@gmail.com Deprecate ExpansionTileController (flutter/flutter#166368)
2025-04-03 kalathiyadimil@gmail.com Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790)
2025-04-03 matanlurey@users.noreply.github.com Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455)
2025-04-03 katelovett@google.com Skip flaking scheduler test (flutter/flutter#166471)
2025-04-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166043)
2025-04-02 yjbanov@google.com [a11y] add SemanticsValidationResult (flutter/flutter#165935)
2025-04-02 58529443+srujzs@users.noreply.github.com Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295)
2025-04-02 engine-flutter-autoroll@skia.org Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484)
2025-04-02 30870216+gaaclarke@users.noreply.github.com Started pixel aligning hairlines (flutter/flutter#166351)
2025-04-02 47866232+chunhtai@users.noreply.github.com Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467)
2025-04-02 jacksongardner@google.com Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
2025-04-02 dkwingsmt@users.noreply.github.com [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045)
2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: Hero animation for page transition (flutter/flutter#164469)
2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675)
2025-04-02 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383)
2025-04-02 jonahwilliams@google.com [Impeller] cache for text shadows. (flutter/flutter#166228)
2025-04-02 34871572+gmackall@users.noreply.github.com Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
2025-04-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474)
2025-04-02 mit@google.com Update Roadmap (flutter/flutter#166332)
2025-04-02 matanlurey@users.noreply.github.com Update `CODEOWNERS` (flutter/flutter#166444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
34ea67b Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
831a0c6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
34ea67b Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
231ba21
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
34ea67b Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
0b91e3e
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions) (flutter#8996)
13118fd 
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions)

flutter/flutter@a0b1b32...02f13c3

2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538)
2025-04-03 magder@google.com Update docs to debug the Android embedder (flutter/flutter#166170)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525)
2025-04-03 matej.knopp@gmail.com [macOS] Implement merged UI and platform thread (flutter/flutter#162883)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527)
2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514)
2025-04-03 dacoharkes@google.com [native_assets] Roll dependencies (flutter/flutter#166282)
2025-04-03 bruno.leroux@gmail.com Fix read only TextField focus traversal on macOS (flutter/flutter#166056)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499)
2025-04-03 34465683+rkishan516@users.noreply.github.com Migrate to Theme.brightnessOf method (flutter/flutter#163950)
2025-04-03 34465683+rkishan516@users.noreply.github.com Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393)
2025-04-03 victorsanniay@gmail.com Deprecate ExpansionTileController (flutter/flutter#166368)
2025-04-03 kalathiyadimil@gmail.com Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790)
2025-04-03 matanlurey@users.noreply.github.com Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455)
2025-04-03 katelovett@google.com Skip flaking scheduler test (flutter/flutter#166471)
2025-04-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166043)
2025-04-02 yjbanov@google.com [a11y] add SemanticsValidationResult (flutter/flutter#165935)
2025-04-02 58529443+srujzs@users.noreply.github.com Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295)
2025-04-02 engine-flutter-autoroll@skia.org Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484)
2025-04-02 30870216+gaaclarke@users.noreply.github.com Started pixel aligning hairlines (flutter/flutter#166351)
2025-04-02 47866232+chunhtai@users.noreply.github.com Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467)
2025-04-02 jacksongardner@google.com Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
2025-04-02 dkwingsmt@users.noreply.github.com [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045)
2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: Hero animation for page transition (flutter/flutter#164469)
2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675)
2025-04-02 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383)
2025-04-02 jonahwilliams@google.com [Impeller] cache for text shadows. (flutter/flutter#166228)
2025-04-02 34871572+gmackall@users.noreply.github.com Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
2025-04-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474)
2025-04-02 mit@google.com Update Roadmap (flutter/flutter#166332)
2025-04-02 matanlurey@users.noreply.github.com Update `CODEOWNERS` (flutter/flutter#166444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@eyebrowsoffire
Reland "[skwasm] Dynamic Threading" (flutter#166454)
43ca43a 
This is a reland of flutter#164748,
which was reverted here: flutter#165350

It was reverted due to some issues in the flutter packages roller:
flutter#165347

The unit test in flutter/packages was modified to be more deterministic
and less affected by minor timing differences:
flutter/packages#8920

So this is basically being relanded without any significant changes,
since the downstream tests have been fixed.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions) (flutter#8996)
174ab15 
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions)

flutter/flutter@a0b1b32...02f13c3

2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538)
2025-04-03 magder@google.com Update docs to debug the Android embedder (flutter/flutter#166170)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525)
2025-04-03 matej.knopp@gmail.com [macOS] Implement merged UI and platform thread (flutter/flutter#162883)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527)
2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514)
2025-04-03 dacoharkes@google.com [native_assets] Roll dependencies (flutter/flutter#166282)
2025-04-03 bruno.leroux@gmail.com Fix read only TextField focus traversal on macOS (flutter/flutter#166056)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499)
2025-04-03 34465683+rkishan516@users.noreply.github.com Migrate to Theme.brightnessOf method (flutter/flutter#163950)
2025-04-03 34465683+rkishan516@users.noreply.github.com Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393)
2025-04-03 victorsanniay@gmail.com Deprecate ExpansionTileController (flutter/flutter#166368)
2025-04-03 kalathiyadimil@gmail.com Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790)
2025-04-03 matanlurey@users.noreply.github.com Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455)
2025-04-03 katelovett@google.com Skip flaking scheduler test (flutter/flutter#166471)
2025-04-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166043)
2025-04-02 yjbanov@google.com [a11y] add SemanticsValidationResult (flutter/flutter#165935)
2025-04-02 58529443+srujzs@users.noreply.github.com Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295)
2025-04-02 engine-flutter-autoroll@skia.org Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484)
2025-04-02 30870216+gaaclarke@users.noreply.github.com Started pixel aligning hairlines (flutter/flutter#166351)
2025-04-02 47866232+chunhtai@users.noreply.github.com Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467)
2025-04-02 jacksongardner@google.com Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
2025-04-02 dkwingsmt@users.noreply.github.com [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045)
2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: Hero animation for page transition (flutter/flutter#164469)
2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675)
2025-04-02 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383)
2025-04-02 jonahwilliams@google.com [Impeller] cache for text shadows. (flutter/flutter#166228)
2025-04-02 34871572+gmackall@users.noreply.github.com Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
2025-04-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474)
2025-04-02 mit@google.com Update Roadmap (flutter/flutter#166332)
2025-04-02 matanlurey@users.noreply.github.com Update `CODEOWNERS` (flutter/flutter#166444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions) (flutter#8996)
eba64e6 
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions)

flutter/flutter@a0b1b32...02f13c3

2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538)
2025-04-03 magder@google.com Update docs to debug the Android embedder (flutter/flutter#166170)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525)
2025-04-03 matej.knopp@gmail.com [macOS] Implement merged UI and platform thread (flutter/flutter#162883)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527)
2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514)
2025-04-03 dacoharkes@google.com [native_assets] Roll dependencies (flutter/flutter#166282)
2025-04-03 bruno.leroux@gmail.com Fix read only TextField focus traversal on macOS (flutter/flutter#166056)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499)
2025-04-03 34465683+rkishan516@users.noreply.github.com Migrate to Theme.brightnessOf method (flutter/flutter#163950)
2025-04-03 34465683+rkishan516@users.noreply.github.com Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393)
2025-04-03 victorsanniay@gmail.com Deprecate ExpansionTileController (flutter/flutter#166368)
2025-04-03 kalathiyadimil@gmail.com Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790)
2025-04-03 matanlurey@users.noreply.github.com Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455)
2025-04-03 katelovett@google.com Skip flaking scheduler test (flutter/flutter#166471)
2025-04-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166043)
2025-04-02 yjbanov@google.com [a11y] add SemanticsValidationResult (flutter/flutter#165935)
2025-04-02 58529443+srujzs@users.noreply.github.com Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295)
2025-04-02 engine-flutter-autoroll@skia.org Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484)
2025-04-02 30870216+gaaclarke@users.noreply.github.com Started pixel aligning hairlines (flutter/flutter#166351)
2025-04-02 47866232+chunhtai@users.noreply.github.com Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467)
2025-04-02 jacksongardner@google.com Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
2025-04-02 dkwingsmt@users.noreply.github.com [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045)
2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: Hero animation for page transition (flutter/flutter#164469)
2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675)
2025-04-02 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383)
2025-04-02 jonahwilliams@google.com [Impeller] cache for text shadows. (flutter/flutter#166228)
2025-04-02 34871572+gmackall@users.noreply.github.com Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
2025-04-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474)
2025-04-02 mit@google.com Update Roadmap (flutter/flutter#166332)
2025-04-02 matanlurey@users.noreply.github.com Update `CODEOWNERS` (flutter/flutter#166444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@eyebrowsoffire @romanejaquez
Reland "[skwasm] Dynamic Threading" (flutter#166454)
617aec3 
This is a reland of flutter#164748,
which was reverted here: flutter#165350

It was reverted due to some issues in the flutter packages roller:
flutter#165347

The unit test in flutter/packages was modified to be more deterministic
and less affected by minor timing differences:
flutter/packages#8920

So this is basically being relanded without any significant changes,
since the downstream tests have been fixed.
@eyebrowsoffire eyebrowsoffire deleted the reland_skwasm_dynamic_threads branch December 12, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eyebrowsoffire @brian-superlist @yjbanov