Skip to content

Reverts "[Impeller] remove transfer barriers from render pass, drop blit, tighten up graphics on level 3. (#165584)" #165898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Mar 25, 2025
Merged

Reverts "[Impeller] remove transfer barriers from render pass, drop blit, tighten up graphics on level 3. (#165584)" #165898

jonahwilliams merged 1 commit into from
Mar 25, 2025

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Mar 25, 2025

Reverts: #165584

Initiated by: jonahwilliams

Reason for reverting: render pass compatibility issue.

Original PR Author: jonahwilliams

Reviewed By: {gaaclarke}

This change reverts the following previous change:
The change to fix PowerVR barriers regressed Mali (see #165538)

We need to tighten the barriers to remove the transfer barrier to get back mali performance. however, this requires us to drop the usage of the blit for onscreen restore. not a huge loss imo.

At any rate, all of these changes should be visible in benchmarks.

Revert "[Impeller] remove transfer barriers from render pass, drop bl…
91436c7 
…it, tighten up graphics on level 3. (#165584)"

This reverts commit 33cf3b6.
@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Mar 25, 2025
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 25, 2025
@auto-submit
Copy link
Contributor Author

auto-submit bot commented Mar 25, 2025

auto label is removed for flutter/flutter/165898, Failed to enqueue flutter/flutter/165898 with HTTP 400: GraphQL mutate failed.

@auto-submit auto-submit bot removed the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Mar 25, 2025
@jonahwilliams jonahwilliams added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Mar 25, 2025
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 25, 2025

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@jonahwilliams jonahwilliams added this pull request to the merge queue Mar 25, 2025
Merged via the queue into master with commit 8893670 Mar 25, 2025
127 of 178 checks passed
@jonahwilliams jonahwilliams deleted the revert_33cf3b65bca8aee9fd18ba792caf4e95d53d0c4f branch March 25, 2025 17:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
a32856c 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
7fa448e 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
adba299 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
eaf24b4 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
fb0e392 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
fd9ed9b 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
679c7aa 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
bba6085 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
8852039 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
8795642 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
958c64b 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
8d46b5f 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
c697cab 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
ee17826 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
4cba7e7 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
c24eb06 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
49348b9 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
abc0405 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
e8c2f09 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
3678dc4 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
60a1d30 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
a856a92 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
148ae5c 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
6188bf9 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
000ce4c 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
1b4af9e 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
02f0226 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
be0ba1b 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
4c44428 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
da5fb67 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
b015a0a 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
cc75610 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
7da28bf 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
e741530 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
d265aa5 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
8893670 Reverts "[Impeller] remove transfer barriers from render pass…
1968f78 
…, drop blit, tighten up graphics on level 3. (#165584)" (flutter/flutter#165898)
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@auto-submit
Reverts "[Impeller] remove transfer barriers from render pass, drop b…
4d0a9e7 
…lit, tighten up graphics on level 3. (flutter#165584)" (flutter#165898)

<!-- start_original_pr_link -->
Reverts: flutter#165584
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: render pass compatibility issue.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {gaaclarke}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
The change to fix PowerVR barriers regressed Mali (see
flutter#165538)

We need to tighten the barriers to remove the transfer barrier to get
back mali performance. however, this requires us to drop the usage of
the blit for onscreen restore. not a huge loss imo.

At any rate, all of these changes should be visible in benchmarks.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@auto-submit @romanejaquez
Reverts "[Impeller] remove transfer barriers from render pass, drop b…
af3b22d 
…lit, tighten up graphics on level 3. (flutter#165584)" (flutter#165898)

<!-- start_original_pr_link -->
Reverts: flutter#165584
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: render pass compatibility issue.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {gaaclarke}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
The change to fix PowerVR barriers regressed Mali (see
flutter#165538)

We need to tighten the barriers to remove the transfer barrier to get
back mali performance. however, this requires us to drop the usage of
the blit for onscreen restore. not a huge loss imo.

At any rate, all of these changes should be visible in benchmarks.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

@jonahwilliams jonahwilliams

Labels

e: impeller Impeller rendering backend issues and features requests emergency Jump the queue; land PR in front of all others; only use for emergencies engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fluttergithubbot @jonahwilliams