Skip to content

Add Remaining Changelog entries for 3.29.2 #165101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Mar 13, 2025
Merged

Add Remaining Changelog entries for 3.29.2 #165101

auto-submit merged 4 commits into from
Mar 13, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 13, 2025 •
edited by reidbaker
Loading

Changelog for #165075, the dart stable change and for #165080

@jonahwilliams jonahwilliams mentioned this pull request Mar 13, 2025
Merged
@jonahwilliams jonahwilliams added the cp: stable cherry pick this pull request to stable release candidate branch label Mar 13, 2025
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 13, 2025

autosubmit label was removed for flutter/flutter/165101, because Pull request flutter/flutter/165101 is not in a mergeable state.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025
@reidbaker reidbaker changed the title Add Changelog entry for fallback behavior change Add Remaining Changelog entries for 3.29.2 Mar 13, 2025
@reidbaker
Copy link
Contributor

reidbaker commented Mar 13, 2025

Failing build is https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/1624819/overview

../../../flutter/impeller/renderer/backend/vulkan/command_pool_vk_unittests.cc:110: Failure
Expected equality of these values:
  std::count(called->begin(), called->end(), "vkCreateCommandPool")
    Which is: 2
  1u
    Which is: 1

�[0;31m[  FAILED  ] �[mCommandPoolRecyclerVKTest.ReclaimMakesCommandPoolAvailable (2 ms)
�[0;32m[----------] �[m1 test from CommandPoolRecyclerVKTest (2 ms total)

�[0;32m[----------] �[mGlobal test environment tear-down
�[0;32m[==========] �[m1 test from 1 test suite ran. (3 ms total)
�[0;32m[  PASSED  ] �[m0 tests.
�[0;31m[  FAILED  ] �[m1 test, listed below:
�[0;31m[  FAILED  ] �[mCommandPoolRecyclerVKTest.ReclaimMakesCommandPoolAvailable

 1 FAILED TEST

@reidbaker
Copy link
Contributor

reidbaker commented Mar 13, 2025

Failing build is https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/1624819/overview

../../../flutter/impeller/renderer/backend/vulkan/command_pool_vk_unittests.cc:110: Failure
Expected equality of these values:
  std::count(called->begin(), called->end(), "vkCreateCommandPool")
    Which is: 2
  1u
    Which is: 1

�[0;31m[  FAILED  ] �[mCommandPoolRecyclerVKTest.ReclaimMakesCommandPoolAvailable (2 ms)
�[0;32m[----------] �[m1 test from CommandPoolRecyclerVKTest (2 ms total)

�[0;32m[----------] �[mGlobal test environment tear-down
�[0;32m[==========] �[m1 test from 1 test suite ran. (3 ms total)
�[0;32m[  PASSED  ] �[m0 tests.
�[0;31m[  FAILED  ] �[m1 test, listed below:
�[0;31m[  FAILED  ] �[mCommandPoolRecyclerVKTest.ReclaimMakesCommandPoolAvailable

 1 FAILED TEST

This was a flake that failed 2/3 times but passed on the 3rd.

@auto-submit auto-submit bot merged commit 135f1a5 into flutter:flutter-3.29-candidate.0 Mar 13, 2025
150 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
135f1a5 Add Remaining Changelog entries for 3.29.2 (flutter/flutter#1…
1a83b1a 
…65101)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
135f1a5 Add Remaining Changelog entries for 3.29.2 (flutter/flutter#1…
cca516b 
…65101)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
135f1a5 Add Remaining Changelog entries for 3.29.2 (flutter/flutter#1…
d2e2f1e 
…65101)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
135f1a5 Add Remaining Changelog entries for 3.29.2 (flutter/flutter#1…
28e9ec6 
…65101)
@WyvernPirate WyvernPirate mentioned this pull request Apr 3, 2025
Merged
@reidbaker reidbaker mentioned this pull request Apr 4, 2025
Merged
9 tasks
Fintasys pushed a commit to Fintasys/flutter that referenced this pull request May 14, 2025
@Fintasys
Add Remaining Changelog entries for 3.29.2 (flutter#165101)
225e365 
Changelog for flutter#165075, the dart stable change and for flutter#165080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App cp: stable cherry pick this pull request to stable release candidate branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @reidbaker @jtmcdole