-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Fixes rendering text rotated 180 degrees #165008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jonahwilliams we probably want to cherry-pick this. Unfortunately it collides with the refactor we just landed. The fix is easy though so we can bring it over, it will just take a bit of massaging. |
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you open a cherry pick PR for this?
Once this lands. I'll have to change the goldens file at a minimum. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cherry-pick of #165008 ## Impacted Users Impeller users. ## Impact Description Text that is rotated 180 degrees exactly will render as if it is scaled by {-1, 1} instead of {-1, -1}. ## Workaround You can rotate text 180.001 degrees instead but the fidelity will be less. ## Risk If it's wrong it could break all text rendering. There are golden tests for it. ## Test Coverage Golden tests (which are not run on release branches) ## Validation Steps #164958 has reproduction code
cherry-pick of flutter#165008 Impeller users. Text that is rotated 180 degrees exactly will render as if it is scaled by {-1, 1} instead of {-1, -1}. You can rotate text 180.001 degrees instead but the fidelity will be less. If it's wrong it could break all text rendering. There are golden tests for it. Golden tests (which are not run on release branches) flutter#164958 has reproduction code
fixes flutter#164958 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
fixes #164958
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.