[CP-stable] Add empty io.flutter.app.FlutterApplication to give deprecation notice, and un-break projects that have not migrated #164730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Contributor
|
autosubmit label was removed for flutter/flutter/164730, because - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
autosubmit label was removed for flutter/flutter/164730, because Pull request flutter/flutter/164730 is not in a mergeable state. |
2cee248
into
flutter:flutter-3.29-candidate.0
150 checks passed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2025
…ve deprecation notice, and un-break projects that have not migrated (flutter/flutter#164730)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2025
…ve deprecation notice, and un-break projects that have not migrated (flutter/flutter#164730)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2025
…ve deprecation notice, and un-break projects that have not migrated (flutter/flutter#164730)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 3, 2025
…ve deprecation notice, and un-break projects that have not migrated (flutter/flutter#164730)
9 tasks
Fintasys
pushed a commit
to Fintasys/flutter
that referenced
this pull request
May 14, 2025
…cation notice, and un-break projects that have not migrated (flutter#164730) This is just the engine portion of flutter#164343. I.e., it does not contain the test change. Copied from the original cherry pick pr: This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? flutter#164024 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples flutter#164024: Add back an empty `io.flutter.app.FlutterApplication` for Android apps that reference that class post v2 embedder migration ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) The class does not provide any additional funcitonality, but it class was removed without sufficient notice in the breaking changes section of the Flutter documentation. As such, consumers of this class were broken without sufficient time to migrate. ### Workaround: Is there a workaround for this issue? Flutter projects which need a custom `Application` can instead simply extend an `android.app.Application`. There is no reason to extend a `FlutterApplication`. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Either make a flutter app which depends on this class, or run the spell check integration tests: ``` # from the .../flutter/dev/devicelab directory ../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t spell_check_test ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the engine portion of #164343. I.e., it does not contain the test change.
Copied from the original cherry pick pr:
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#164024
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
#164024: Add back an empty
io.flutter.app.FlutterApplicationfor Android apps that reference that class post v2 embedder migrationImpact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
The class does not provide any additional funcitonality, but it class was removed without sufficient notice in the breaking changes section of the Flutter documentation. As such, consumers of this class were broken without sufficient time to migrate.
Workaround:
Is there a workaround for this issue?
Flutter projects which need a custom
Applicationcan instead simply extend anandroid.app.Application. There is no reason to extend aFlutterApplication.Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Either make a flutter app which depends on this class, or run the spell check integration tests: