-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Run run_debug_test_android and run_release_test in prod #164231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 1 commit into
flutter:master
from
jmagman:run_debug_test_android-bringup
Mar 3, 2025
Merged
Run run_debug_test_android and run_release_test in prod #164231
auto-submit
merged 1 commit into
flutter:master
from
jmagman:run_debug_test_android-bringup
Mar 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbaker
approved these changes
Feb 27, 2025
jmagman
added a commit
that referenced
this pull request
Mar 3, 2025
)" This reverts commit 3bb5bf4.
Member
Author
|
Reason for revert: Passed a few times but is continuing to fail in prod https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8721388050458438721/+/u/run_run_release_test/stdout |
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
)" This reverts commit 3bb5bf4.
9 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
…4231)" (#164512) <!-- start_original_pr_link --> Reverts: #164231 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: jmagman <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Passed a few times but is continuing to fail in prod https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8721388050458438721/+/u/run_run_release_test/stdout <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: jmagman <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {reidbaker} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: `run_debug_test_android` and `run_release_test` were both consistently failing because of stray stderr logging that Xcode simctl (simulator command line tool) wasn't installed. #163895 removed that logging, and these tests are now passing: https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_mokey%20run_debug_test_android/1373/overview https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_mokey%20run_release_test/3467/overview They were originally marked bringup because they were flaky (like 10%) but while in bringup went to 100% failure due to the Xcode install issue. It looks like they really weren't flaky any more before the Xcode install issues, but erroneously the flaky issue was closed but the test wasn't marked unflaky #153830 (comment). Moving out of bringup. Fixes #161655 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_debug_test_androidandrun_release_testwere both consistently failing because of stray stderr logging that Xcode simctl (simulator command line tool) wasn't installed. #163895 removed that logging, and these tests are now passing:https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_mokey%20run_debug_test_android/1373/overview
https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_mokey%20run_release_test/3467/overview
They were originally marked bringup because they were flaky (like 10%) but while in bringup went to 100% failure due to the Xcode install issue. It looks like they really weren't flaky any more before the Xcode install issues, but erroneously the flaky issue was closed but the test wasn't marked unflaky #153830 (comment).
Moving out of bringup.
Fixes #161655
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.