Skip to content

Update gradle memory properties in example and test projects #163798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 21, 2025
Merged

Update gradle memory properties in example and test projects #163798

auto-submit merged 1 commit into from
Feb 21, 2025

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 20, 2025 •
edited
Loading

Match the example and integration test apps to the the properties in the flutter create template, updated in #156201.

We discussed perhaps making this an auto-migration for existing Flutter apps (if they've never edited the template from the old values), but it probably makes sense for devs to manage this themselves depending on how beefy the machine they are running on is.

Filed #163801 to show a nicer message when the user hits this so they can manage java.lang.OutOfMemoryError: Java heap space errors themselves.

Speculatively hoping this helps with the Java heap space build test flakes #163121 (comment)

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman requested a review from matanlurey as a code owner February 20, 2025 23:49
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Feb 20, 2025
matanlurey
matanlurey approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Thanks!

This was referenced Feb 21, 2025
Closed
Closed
Closed
@jmagman jmagman requested a review from gmackall February 21, 2025 18:33
gmackall
gmackall approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

I still find it odd that our ci hits this issue so frequently, but developers don't hit it locally (and didn't when our template matched the 4gb we are moving away from here). But regardless, our ci matching our templates makes sense

@jmagman
Copy link
Member Author

jmagman commented Feb 21, 2025

I still find it odd that our ci hits this issue so frequently, but developers don't hit it locally (and didn't when our template matched the 4gb we are moving away from here).

@gmackall I also don't really understand why ReservedCodeCacheSize was needed.

our ci matching our templates makes sense

This is why I'm not looking into the details of the properties too closely, but we should probably do more due diligence to see if bumping actually makes sense for real Flutter apps when the templates are updated, going forward.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 21, 2025
Merged via the queue into flutter:master with commit 404655a Feb 21, 2025
176 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
90e1bd0 
…lutter/flutter#163798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
786f884 
…lutter/flutter#163798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
5e6b5d3 
…lutter/flutter#163798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
bb88715 
…lutter/flutter#163798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
2e7b83b 
…lutter/flutter#163798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
73276de 
…lutter/flutter#163798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
228e00a 
…lutter/flutter#163798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
d7245b5 
…lutter/flutter#163798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
0f811a1 
…lutter/flutter#163798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
3fd92aa 
…lutter/flutter#163798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
5c1bc7b 
…lutter/flutter#163798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
@gnprice gnprice mentioned this pull request Feb 26, 2025
Closed
@harri35 harri35 mentioned this pull request Feb 26, 2025
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
889da00 
…lutter/flutter#163798)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
c96a649 
…lutter/flutter#163798)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
749f03f 
…lutter/flutter#163798)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
76eb872 
…lutter/flutter#163798)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
62882de 
…lutter/flutter#163798)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
160c0c4 
…lutter/flutter#163798)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
caf182e 
…lutter/flutter#163798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 27, 2025
@engine-flutter-autoroll
Manual roll Flutter from 043b719 to 1659206 (19 revisions) (#8728)
01d3d5c 
Manual roll requested by stuartmorgan@google.com

flutter/flutter@043b719...1659206

2025-02-24 engine-flutter-autoroll@skia.org Roll Skia from 3dfb3fee52e1 to 28017200173a (2 revisions) (flutter/flutter#163981)
2025-02-24 51940183+Sameri11@users.noreply.github.com Add integration test for Gradle-initiated android builds with flavors (flutter/flutter#163737)
2025-02-23 engine-flutter-autoroll@skia.org Roll Skia from 72f949950adb to 3dfb3fee52e1 (1 revision) (flutter/flutter#163959)
2025-02-23 engine-flutter-autoroll@skia.org Roll Skia from 4bee660601de to 72f949950adb (1 revision) (flutter/flutter#163948)
2025-02-22 engine-flutter-autoroll@skia.org Roll Skia from cca9328df6ca to 4bee660601de (1 revision) (flutter/flutter#163927)
2025-02-22 engine-flutter-autoroll@skia.org Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) (flutter/flutter#163912)
2025-02-22 engine-flutter-autoroll@skia.org Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) (flutter/flutter#163910)
2025-02-22 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] include more tests in the fuchsia builders (flutter/flutter#163800)
2025-02-21 dkwingsmt@users.noreply.github.com [Engine] Add RoundSuperellipse to drawing OP (flutter/flutter#160883)
2025-02-21 34871572+gmackall@users.noreply.github.com [remake] Restore old back handling for FlutterFragmentActivity (flutter/flutter#161545)
2025-02-21 magder@google.com Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" (flutter/flutter#163878)
2025-02-21 magder@google.com Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" (flutter/flutter#163880)
2025-02-21 engine-flutter-autoroll@skia.org Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) (flutter/flutter#163885)
2025-02-21 magder@google.com Revert "Marks Windows_mokey native_assets_android to be flaky" (flutter/flutter#163881)
2025-02-21 magder@google.com Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup (flutter/flutter#163883)
2025-02-21 engine-flutter-autoroll@skia.org Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) (flutter/flutter#163789)
2025-02-21 matanlurey@users.noreply.github.com Enable `linux_android_emulator_tests` on presubmit. (flutter/flutter#163879)
2025-02-21 magder@google.com Update gradle memory properties in example and test projects (flutter/flutter#163798)
2025-02-21 jmccandless@google.com Secure paste milestone 2 (flutter/flutter#159013)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@harri35 harri35 mentioned this pull request Mar 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
2d50afc 
…lutter/flutter#163798)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
202870b 
…lutter/flutter#163798)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
404655a Update gradle memory properties in example and test projects (f…
b2923b3 
…lutter/flutter#163798)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 043b719 to 1659206 (19 revisions) (flutter#8728
4126d89 
)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@043b719...1659206

2025-02-24 engine-flutter-autoroll@skia.org Roll Skia from 3dfb3fee52e1 to 28017200173a (2 revisions) (flutter/flutter#163981)
2025-02-24 51940183+Sameri11@users.noreply.github.com Add integration test for Gradle-initiated android builds with flavors (flutter/flutter#163737)
2025-02-23 engine-flutter-autoroll@skia.org Roll Skia from 72f949950adb to 3dfb3fee52e1 (1 revision) (flutter/flutter#163959)
2025-02-23 engine-flutter-autoroll@skia.org Roll Skia from 4bee660601de to 72f949950adb (1 revision) (flutter/flutter#163948)
2025-02-22 engine-flutter-autoroll@skia.org Roll Skia from cca9328df6ca to 4bee660601de (1 revision) (flutter/flutter#163927)
2025-02-22 engine-flutter-autoroll@skia.org Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) (flutter/flutter#163912)
2025-02-22 engine-flutter-autoroll@skia.org Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) (flutter/flutter#163910)
2025-02-22 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] include more tests in the fuchsia builders (flutter/flutter#163800)
2025-02-21 dkwingsmt@users.noreply.github.com [Engine] Add RoundSuperellipse to drawing OP (flutter/flutter#160883)
2025-02-21 34871572+gmackall@users.noreply.github.com [remake] Restore old back handling for FlutterFragmentActivity (flutter/flutter#161545)
2025-02-21 magder@google.com Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" (flutter/flutter#163878)
2025-02-21 magder@google.com Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" (flutter/flutter#163880)
2025-02-21 engine-flutter-autoroll@skia.org Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) (flutter/flutter#163885)
2025-02-21 magder@google.com Revert "Marks Windows_mokey native_assets_android to be flaky" (flutter/flutter#163881)
2025-02-21 magder@google.com Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup (flutter/flutter#163883)
2025-02-21 engine-flutter-autoroll@skia.org Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) (flutter/flutter#163789)
2025-02-21 matanlurey@users.noreply.github.com Enable `linux_android_emulator_tests` on presubmit. (flutter/flutter#163879)
2025-02-21 magder@google.com Update gradle memory properties in example and test projects (flutter/flutter#163798)
2025-02-21 jmccandless@google.com Secure paste milestone 2 (flutter/flutter#159013)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 043b719 to 1659206 (19 revisions) (flutter#8728
cf6b436 
)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@043b719...1659206

2025-02-24 engine-flutter-autoroll@skia.org Roll Skia from 3dfb3fee52e1 to 28017200173a (2 revisions) (flutter/flutter#163981)
2025-02-24 51940183+Sameri11@users.noreply.github.com Add integration test for Gradle-initiated android builds with flavors (flutter/flutter#163737)
2025-02-23 engine-flutter-autoroll@skia.org Roll Skia from 72f949950adb to 3dfb3fee52e1 (1 revision) (flutter/flutter#163959)
2025-02-23 engine-flutter-autoroll@skia.org Roll Skia from 4bee660601de to 72f949950adb (1 revision) (flutter/flutter#163948)
2025-02-22 engine-flutter-autoroll@skia.org Roll Skia from cca9328df6ca to 4bee660601de (1 revision) (flutter/flutter#163927)
2025-02-22 engine-flutter-autoroll@skia.org Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) (flutter/flutter#163912)
2025-02-22 engine-flutter-autoroll@skia.org Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) (flutter/flutter#163910)
2025-02-22 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] include more tests in the fuchsia builders (flutter/flutter#163800)
2025-02-21 dkwingsmt@users.noreply.github.com [Engine] Add RoundSuperellipse to drawing OP (flutter/flutter#160883)
2025-02-21 34871572+gmackall@users.noreply.github.com [remake] Restore old back handling for FlutterFragmentActivity (flutter/flutter#161545)
2025-02-21 magder@google.com Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" (flutter/flutter#163878)
2025-02-21 magder@google.com Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" (flutter/flutter#163880)
2025-02-21 engine-flutter-autoroll@skia.org Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) (flutter/flutter#163885)
2025-02-21 magder@google.com Revert "Marks Windows_mokey native_assets_android to be flaky" (flutter/flutter#163881)
2025-02-21 magder@google.com Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup (flutter/flutter#163883)
2025-02-21 engine-flutter-autoroll@skia.org Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) (flutter/flutter#163789)
2025-02-21 matanlurey@users.noreply.github.com Enable `linux_android_emulator_tests` on presubmit. (flutter/flutter#163879)
2025-02-21 magder@google.com Update gradle memory properties in example and test projects (flutter/flutter#163798)
2025-02-21 jmccandless@google.com Secure paste milestone 2 (flutter/flutter#159013)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@gmackall gmackall gmackall approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @matanlurey @gmackall