Conditionally release image textures (i.e. release platform view textures only) #163692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| manual, | ||
|
|
||
| /** | ||
| * The surface may be reset if the app enters the background. |
Contributor
There was a problem hiding this comment.
This has to be will and not may, because if the image is cleared and the surface is not reset, we'll get the bug you're trying to fix.
| jlong texture_id, | ||
| jobject image_texture_entry) { | ||
| jobject image_texture_entry, | ||
| jboolean reset_on_gr_context_destroyed) { |
Contributor
There was a problem hiding this comment.
nit: call this something unrelated to gr_context which is a Skia concept only
| const fml::jni::ScopedJavaGlobalRef<jobject>& image_texture_entry, | ||
| const std::shared_ptr<PlatformViewAndroidJNI>& jni_facade); | ||
| const std::shared_ptr<PlatformViewAndroidJNI>& jni_facade, | ||
| const ImageLifecycle lifecycle = ImageLifecycle::kReset); |
Contributor
There was a problem hiding this comment.
Here and elsewhere I would probably leave this without a default value. its important that we don't ever forget to pass it, as IIRC there is not a safe default: that is, not disposing the image when the surface is an error and disposing the image when the surface is retained leads to a blank screen.
Contributor
|
Oh and tests too, naturally :) |
jonahwilliams
suggested changes
Feb 20, 2025
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
Using request changes to indicate I would like changes made
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 28, 2025
Fixes #163561 Fixes #156488 Fixes #156489 Fixes #163520 Forked from #163692 Only release background image readers on Android 14. I believe reader disposal is the ultimate cause of #162147 , where older android devices don't seem to handle backgrounding the same way we expect on newer devices. The result of this is a crash in HWUI, which is unexpected. Since we only ever did the background release to work around an ANdroid 14 bug, and because it breaks other functionality like background playback - we should remove it for all targets besides 14.
zhangyuang
pushed a commit
to zhangyuang/flutter-fork
that referenced
this pull request
Jun 9, 2025
…er#165942) Fixes flutter#163561 Fixes flutter#156488 Fixes flutter#156489 Fixes flutter#163520 Forked from flutter#163692 Only release background image readers on Android 14. I believe reader disposal is the ultimate cause of flutter#162147 , where older android devices don't seem to handle backgrounding the same way we expect on newer devices. The result of this is a crash in HWUI, which is unexpected. Since we only ever did the background release to work around an ANdroid 14 bug, and because it breaks other functionality like background playback - we should remove it for all targets besides 14.
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…er#165942) Fixes flutter#163561 Fixes flutter#156488 Fixes flutter#156489 Fixes flutter#163520 Forked from flutter#163692 Only release background image readers on Android 14. I believe reader disposal is the ultimate cause of flutter#162147 , where older android devices don't seem to handle backgrounding the same way we expect on newer devices. The result of this is a crash in HWUI, which is unexpected. Since we only ever did the background release to work around an ANdroid 14 bug, and because it breaks other functionality like background playback - we should remove it for all targets besides 14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163561.
If this is the right approach, I'll clean it up a bit and add a few unit tests.