Skip to content

[Impeller] don't use glFramebufferBlit for onscreen restore. #163327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Feb 14, 2025
Merged

[Impeller] don't use glFramebufferBlit for onscreen restore. #163327

auto-submit merged 2 commits into from
Feb 14, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Feb 14, 2025

With the OpenGLES backend, we use the MSAA render to texture extension. This means that the offscreen textures are multisample and implicitly resolved when sampled from. This implicit resolve does not occur in the blit command used to restore to the onscreen, which can trigger a crash in the GLES driver.

In other backends, the onscreen is also multisample and the blit is OK.

Fixes #163304

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Feb 14, 2025
gaaclarke
gaaclarke approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 14, 2025
Merged via the queue into flutter:master with commit 3e219d1 Feb 14, 2025
175 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2025
@jonahwilliams jonahwilliams deleted the repr_blit_problem branch February 14, 2025 20:46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
43635ab 
…lutter/flutter#163327)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
7d102f1 
…lutter/flutter#163327)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
d547fcc 
…lutter/flutter#163327)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
a9d329c 
…lutter/flutter#163327)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
10a6c5d 
…lutter/flutter#163327)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
7549c86 
…lutter/flutter#163327)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
62f6ff7 
…lutter/flutter#163327)
@jonahwilliams jonahwilliams mentioned this pull request Feb 17, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
ce9dbf8 
…lutter/flutter#163327)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
120b65c 
…lutter/flutter#163327)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
74ace75 
…lutter/flutter#163327)
@jonahwilliams jonahwilliams mentioned this pull request Feb 19, 2025
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
f757756 
…lutter/flutter#163327)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
ed22bf8 
…lutter/flutter#163327)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
3a508cb 
…lutter/flutter#163327)
auto-submit bot pushed a commit that referenced this pull request Feb 19, 2025
[CP][Impeller] Fix crash when using BackdropFilters in certain GLES d…
383d56e 
…rivers. (#163581)

This is a cherry picked of #163345 and #163327 combined, as they both are parts of the same bug.

The issues are:
  #163304
  #163421
  
And potentially others, though we don't have clear repros or stack traces for all of them.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
6498f72 
…lutter/flutter#163327)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
f08b9c2 
…lutter/flutter#163327)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
34a2ca7 
…lutter/flutter#163327)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
5090058 
…lutter/flutter#163327)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
Roll Flutter from e8f34a9 to 39b4951 (95 revisions) (#8663)
5a721da 
Roll Flutter from e8f34a9 to 39b4951 (95 revisions)

flutter/flutter@e8f34a9...39b4951

2025-02-18 fluttergithubbot@gmail.com Marks Windows_arm64 plugin_test_windows to be flaky (flutter/flutter#163123)
2025-02-18 jonahwilliams@google.com [android] use macro definition to shrink repetitive JNI code size. (flutter/flutter#163395)
2025-02-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163474)
2025-02-18 mdebbar@google.com [web] Cleanup everything HTML from the engine (outside html/ folder) (flutter/flutter#162840)
2025-02-18 flar@google.com [Impeller] add support for rational bezier conics to Path (flutter/flutter#163282)
2025-02-18 36861262+QuncCccccc@users.noreply.github.com Change `cardTheme`, `dialogTheme`, and `tabBarTheme` type to `xxxThemeData` (flutter/flutter#157292)
2025-02-18 jason-simmons@users.noreply.github.com Update integration test and benchmark Android .gitignore files to match the current app template (flutter/flutter#163276)
2025-02-18 chinmaygarde@google.com [Impeller] Don't create a redundant typography context. (flutter/flutter#163513)
2025-02-18 engine-flutter-autoroll@skia.org Roll Dart SDK from fcef25f18e4d to 023ac80cef14 (1 revision) (flutter/flutter#163110)
2025-02-18 reidbaker@google.com update module_host_with_custom_build_v2_embedding to target android 35 and to use the latest gradle and agp versions (flutter/flutter#163542)
2025-02-18 jonahwilliams@google.com [Impeller] when binding to READ_FRAMEBUFFER, treat multisampled textures as single sampled. (flutter/flutter#163345)
2025-02-18 sokolovskyi.konstantin@gmail.com Add missing properties to _ArcPaintPredicate. (flutter/flutter#162572)
2025-02-18 engine-flutter-autoroll@skia.org Roll Packages from 8542af3 to cb4fb13 (4 revisions) (flutter/flutter#163544)
2025-02-18 reidbaker@google.com Remove bringup for android_display_cutout (flutter/flutter#163312)
2025-02-18 reidbaker@google.com Create VersionUtils class and unit tests and extract logic out of flutter.groovy (flutter/flutter#163166)
2025-02-18 matanlurey@users.noreply.github.com Invalidate `pod install` output if `.flutter-plugins-dependencies` content changes. (flutter/flutter#163275)
2025-02-18 robert.ancell@canonical.com Replace hard coded numbers with mouse button defines (flutter/flutter#163503)
2025-02-18 engine-flutter-autoroll@skia.org Roll Skia from 9147a9654043 to 6da10829d017 (1 revision) (flutter/flutter#163531)
2025-02-18 engine-flutter-autoroll@skia.org Roll Skia from 92aaa4e20ea7 to 9147a9654043 (2 revisions) (flutter/flutter#163512)
2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 71a160edc9d9 to 92aaa4e20ea7 (1 revision) (flutter/flutter#163488)
2025-02-17 engine-flutter-autoroll@skia.org Roll Packages from 625023a to 8542af3 (21 revisions) (flutter/flutter#163484)
2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 7e3129d5db11 to 71a160edc9d9 (1 revision) (flutter/flutter#163459)
2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 40ce5ef20d22 to 7e3129d5db11 (1 revision) (flutter/flutter#163451)
2025-02-16 engine-flutter-autoroll@skia.org Roll Skia from bb166c85957b to 40ce5ef20d22 (1 revision) (flutter/flutter#163403)
2025-02-15 engine-flutter-autoroll@skia.org Roll Skia from ff94581f1f8a to bb166c85957b (1 revision) (flutter/flutter#163381)
2025-02-15 58529443+srujzs@users.noreply.github.com Move DWDS initialization into the onLoadEndCallback for the DDC library bundle format (flutter/flutter#163338)
2025-02-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Handle MakeGrContext returning null (flutter/flutter#163332)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 13a3b6f34ee8 to ff94581f1f8a (1 revision) (flutter/flutter#163347)
2025-02-14 bkonyi@google.com Fix failing chrome_dev_mode tests (flutter/flutter#163346)
2025-02-14 47866232+chunhtai@users.noreply.github.com Adds all semantics roles (flutter/flutter#163075)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 20924303cc25 to 13a3b6f34ee8 (1 revision) (flutter/flutter#163336)
2025-02-14 bkonyi@google.com [ Widget Preview ] Add experimental support for web-based widget preview environment (flutter/flutter#163154)
2025-02-14 jonahwilliams@google.com [Impeller] don't use glFramebufferBlit for onscreen restore. (flutter/flutter#163327)
2025-02-14 58529443+srujzs@users.noreply.github.com Align web terminal messages with the VM (flutter/flutter#163268)
2025-02-14 victoreronmosele@gmail.com Manually roll customer_testing to enable rfw tests (flutter/flutter#163030)
2025-02-14 ybz975218925@gmail.com Refactor SliverMainAxisGroup for reverse mode. (flutter/flutter#161849)
2025-02-14 30870216+gaaclarke@users.noreply.github.com Tweaked TextContents math to avoid floating point errors (flutter/flutter#162480)
2025-02-14 kevinjchisholm@google.com [release] Update cherry-pick CHANGELOG requirements (flutter/flutter#163318)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 85722a1db585 to 20924303cc25 (2 revisions) (flutter/flutter#163293)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 5a38d23ee247 to 85722a1db585 (1 revision) (flutter/flutter#163286)
2025-02-14 matanlurey@users.noreply.github.com Add `.flutter-plugins-dependencies` to `FlutterBuildSystem`; update logic, add tests. (flutter/flutter#163278)
2025-02-14 jhy03261997@gmail.com Add table related semantics role (flutter/flutter#162339)
2025-02-14 jason-simmons@users.noreply.github.com [Impeller] Call glDebugMessageControlKHR only if the KHR_debug extension is available (flutter/flutter#163273)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 748415976ad1 to 5a38d23ee247 (3 revisions) (flutter/flutter#163271)
2025-02-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Use `transferToImageBitmap` instead of `createImageBitmap` (flutter/flutter#163175)
2025-02-14 jacksongardner@google.com [skwasm] Use `transferToImageBitmap` instead of `createImageBitmap` (flutter/flutter#163251)
...
Fintasys pushed a commit to Fintasys/flutter that referenced this pull request May 14, 2025
@Fintasys
[CP][Impeller] Fix crash when using BackdropFilters in certain GLES d…
261cedb 
…rivers. (flutter#163581)

This is a cherry picked of flutter#163345 and flutter#163327 combined, as they both are parts of the same bug.

The issues are:
  flutter#163304
  flutter#163421

And potentially others, though we don't have clear repros or stack traces for all of them.
CodixNinja pushed a commit to CodixNinja/flutter that referenced this pull request May 15, 2025
[CP][Impeller] Fix crash when using BackdropFilters in certain GLES d…
9d1d0a6 
…rivers. (#163581)

This is a cherry picked of flutter/flutter#163345 and flutter/flutter#163327 combined, as they both are parts of the same bug.

The issues are:
  flutter/flutter#163304
  flutter/flutter#163421
  
And potentially others, though we don't have clear repros or stack traces for all of them.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
1a35d11 
…lutter/flutter#163327)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
7d1b881 
…lutter/flutter#163327)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
3e219d1 [Impeller] don't use glFramebufferBlit for onscreen restore. (f…
f66a760 
…lutter/flutter#163327)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from e8f34a9 to 39b4951 (95 revisions) (flutter#8663)
a34ee44 
Roll Flutter from e8f34a9 to 39b4951 (95 revisions)

flutter/flutter@e8f34a9...39b4951

2025-02-18 fluttergithubbot@gmail.com Marks Windows_arm64 plugin_test_windows to be flaky (flutter/flutter#163123)
2025-02-18 jonahwilliams@google.com [android] use macro definition to shrink repetitive JNI code size. (flutter/flutter#163395)
2025-02-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163474)
2025-02-18 mdebbar@google.com [web] Cleanup everything HTML from the engine (outside html/ folder) (flutter/flutter#162840)
2025-02-18 flar@google.com [Impeller] add support for rational bezier conics to Path (flutter/flutter#163282)
2025-02-18 36861262+QuncCccccc@users.noreply.github.com Change `cardTheme`, `dialogTheme`, and `tabBarTheme` type to `xxxThemeData` (flutter/flutter#157292)
2025-02-18 jason-simmons@users.noreply.github.com Update integration test and benchmark Android .gitignore files to match the current app template (flutter/flutter#163276)
2025-02-18 chinmaygarde@google.com [Impeller] Don't create a redundant typography context. (flutter/flutter#163513)
2025-02-18 engine-flutter-autoroll@skia.org Roll Dart SDK from fcef25f18e4d to 023ac80cef14 (1 revision) (flutter/flutter#163110)
2025-02-18 reidbaker@google.com update module_host_with_custom_build_v2_embedding to target android 35 and to use the latest gradle and agp versions (flutter/flutter#163542)
2025-02-18 jonahwilliams@google.com [Impeller] when binding to READ_FRAMEBUFFER, treat multisampled textures as single sampled. (flutter/flutter#163345)
2025-02-18 sokolovskyi.konstantin@gmail.com Add missing properties to _ArcPaintPredicate. (flutter/flutter#162572)
2025-02-18 engine-flutter-autoroll@skia.org Roll Packages from 8542af3 to cb4fb13 (4 revisions) (flutter/flutter#163544)
2025-02-18 reidbaker@google.com Remove bringup for android_display_cutout (flutter/flutter#163312)
2025-02-18 reidbaker@google.com Create VersionUtils class and unit tests and extract logic out of flutter.groovy (flutter/flutter#163166)
2025-02-18 matanlurey@users.noreply.github.com Invalidate `pod install` output if `.flutter-plugins-dependencies` content changes. (flutter/flutter#163275)
2025-02-18 robert.ancell@canonical.com Replace hard coded numbers with mouse button defines (flutter/flutter#163503)
2025-02-18 engine-flutter-autoroll@skia.org Roll Skia from 9147a9654043 to 6da10829d017 (1 revision) (flutter/flutter#163531)
2025-02-18 engine-flutter-autoroll@skia.org Roll Skia from 92aaa4e20ea7 to 9147a9654043 (2 revisions) (flutter/flutter#163512)
2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 71a160edc9d9 to 92aaa4e20ea7 (1 revision) (flutter/flutter#163488)
2025-02-17 engine-flutter-autoroll@skia.org Roll Packages from 625023a to 8542af3 (21 revisions) (flutter/flutter#163484)
2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 7e3129d5db11 to 71a160edc9d9 (1 revision) (flutter/flutter#163459)
2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 40ce5ef20d22 to 7e3129d5db11 (1 revision) (flutter/flutter#163451)
2025-02-16 engine-flutter-autoroll@skia.org Roll Skia from bb166c85957b to 40ce5ef20d22 (1 revision) (flutter/flutter#163403)
2025-02-15 engine-flutter-autoroll@skia.org Roll Skia from ff94581f1f8a to bb166c85957b (1 revision) (flutter/flutter#163381)
2025-02-15 58529443+srujzs@users.noreply.github.com Move DWDS initialization into the onLoadEndCallback for the DDC library bundle format (flutter/flutter#163338)
2025-02-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Handle MakeGrContext returning null (flutter/flutter#163332)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 13a3b6f34ee8 to ff94581f1f8a (1 revision) (flutter/flutter#163347)
2025-02-14 bkonyi@google.com Fix failing chrome_dev_mode tests (flutter/flutter#163346)
2025-02-14 47866232+chunhtai@users.noreply.github.com Adds all semantics roles (flutter/flutter#163075)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 20924303cc25 to 13a3b6f34ee8 (1 revision) (flutter/flutter#163336)
2025-02-14 bkonyi@google.com [ Widget Preview ] Add experimental support for web-based widget preview environment (flutter/flutter#163154)
2025-02-14 jonahwilliams@google.com [Impeller] don't use glFramebufferBlit for onscreen restore. (flutter/flutter#163327)
2025-02-14 58529443+srujzs@users.noreply.github.com Align web terminal messages with the VM (flutter/flutter#163268)
2025-02-14 victoreronmosele@gmail.com Manually roll customer_testing to enable rfw tests (flutter/flutter#163030)
2025-02-14 ybz975218925@gmail.com Refactor SliverMainAxisGroup for reverse mode. (flutter/flutter#161849)
2025-02-14 30870216+gaaclarke@users.noreply.github.com Tweaked TextContents math to avoid floating point errors (flutter/flutter#162480)
2025-02-14 kevinjchisholm@google.com [release] Update cherry-pick CHANGELOG requirements (flutter/flutter#163318)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 85722a1db585 to 20924303cc25 (2 revisions) (flutter/flutter#163293)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 5a38d23ee247 to 85722a1db585 (1 revision) (flutter/flutter#163286)
2025-02-14 matanlurey@users.noreply.github.com Add `.flutter-plugins-dependencies` to `FlutterBuildSystem`; update logic, add tests. (flutter/flutter#163278)
2025-02-14 jhy03261997@gmail.com Add table related semantics role (flutter/flutter#162339)
2025-02-14 jason-simmons@users.noreply.github.com [Impeller] Call glDebugMessageControlKHR only if the KHR_debug extension is available (flutter/flutter#163273)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 748415976ad1 to 5a38d23ee247 (3 revisions) (flutter/flutter#163271)
2025-02-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Use `transferToImageBitmap` instead of `createImageBitmap` (flutter/flutter#163175)
2025-02-14 jacksongardner@google.com [skwasm] Use `transferToImageBitmap` instead of `createImageBitmap` (flutter/flutter#163251)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from e8f34a9 to 39b4951 (95 revisions) (flutter#8663)
cc6f082 
Roll Flutter from e8f34a9 to 39b4951 (95 revisions)

flutter/flutter@e8f34a9...39b4951

2025-02-18 fluttergithubbot@gmail.com Marks Windows_arm64 plugin_test_windows to be flaky (flutter/flutter#163123)
2025-02-18 jonahwilliams@google.com [android] use macro definition to shrink repetitive JNI code size. (flutter/flutter#163395)
2025-02-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163474)
2025-02-18 mdebbar@google.com [web] Cleanup everything HTML from the engine (outside html/ folder) (flutter/flutter#162840)
2025-02-18 flar@google.com [Impeller] add support for rational bezier conics to Path (flutter/flutter#163282)
2025-02-18 36861262+QuncCccccc@users.noreply.github.com Change `cardTheme`, `dialogTheme`, and `tabBarTheme` type to `xxxThemeData` (flutter/flutter#157292)
2025-02-18 jason-simmons@users.noreply.github.com Update integration test and benchmark Android .gitignore files to match the current app template (flutter/flutter#163276)
2025-02-18 chinmaygarde@google.com [Impeller] Don't create a redundant typography context. (flutter/flutter#163513)
2025-02-18 engine-flutter-autoroll@skia.org Roll Dart SDK from fcef25f18e4d to 023ac80cef14 (1 revision) (flutter/flutter#163110)
2025-02-18 reidbaker@google.com update module_host_with_custom_build_v2_embedding to target android 35 and to use the latest gradle and agp versions (flutter/flutter#163542)
2025-02-18 jonahwilliams@google.com [Impeller] when binding to READ_FRAMEBUFFER, treat multisampled textures as single sampled. (flutter/flutter#163345)
2025-02-18 sokolovskyi.konstantin@gmail.com Add missing properties to _ArcPaintPredicate. (flutter/flutter#162572)
2025-02-18 engine-flutter-autoroll@skia.org Roll Packages from 8542af3 to cb4fb13 (4 revisions) (flutter/flutter#163544)
2025-02-18 reidbaker@google.com Remove bringup for android_display_cutout (flutter/flutter#163312)
2025-02-18 reidbaker@google.com Create VersionUtils class and unit tests and extract logic out of flutter.groovy (flutter/flutter#163166)
2025-02-18 matanlurey@users.noreply.github.com Invalidate `pod install` output if `.flutter-plugins-dependencies` content changes. (flutter/flutter#163275)
2025-02-18 robert.ancell@canonical.com Replace hard coded numbers with mouse button defines (flutter/flutter#163503)
2025-02-18 engine-flutter-autoroll@skia.org Roll Skia from 9147a9654043 to 6da10829d017 (1 revision) (flutter/flutter#163531)
2025-02-18 engine-flutter-autoroll@skia.org Roll Skia from 92aaa4e20ea7 to 9147a9654043 (2 revisions) (flutter/flutter#163512)
2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 71a160edc9d9 to 92aaa4e20ea7 (1 revision) (flutter/flutter#163488)
2025-02-17 engine-flutter-autoroll@skia.org Roll Packages from 625023a to 8542af3 (21 revisions) (flutter/flutter#163484)
2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 7e3129d5db11 to 71a160edc9d9 (1 revision) (flutter/flutter#163459)
2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 40ce5ef20d22 to 7e3129d5db11 (1 revision) (flutter/flutter#163451)
2025-02-16 engine-flutter-autoroll@skia.org Roll Skia from bb166c85957b to 40ce5ef20d22 (1 revision) (flutter/flutter#163403)
2025-02-15 engine-flutter-autoroll@skia.org Roll Skia from ff94581f1f8a to bb166c85957b (1 revision) (flutter/flutter#163381)
2025-02-15 58529443+srujzs@users.noreply.github.com Move DWDS initialization into the onLoadEndCallback for the DDC library bundle format (flutter/flutter#163338)
2025-02-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Handle MakeGrContext returning null (flutter/flutter#163332)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 13a3b6f34ee8 to ff94581f1f8a (1 revision) (flutter/flutter#163347)
2025-02-14 bkonyi@google.com Fix failing chrome_dev_mode tests (flutter/flutter#163346)
2025-02-14 47866232+chunhtai@users.noreply.github.com Adds all semantics roles (flutter/flutter#163075)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 20924303cc25 to 13a3b6f34ee8 (1 revision) (flutter/flutter#163336)
2025-02-14 bkonyi@google.com [ Widget Preview ] Add experimental support for web-based widget preview environment (flutter/flutter#163154)
2025-02-14 jonahwilliams@google.com [Impeller] don't use glFramebufferBlit for onscreen restore. (flutter/flutter#163327)
2025-02-14 58529443+srujzs@users.noreply.github.com Align web terminal messages with the VM (flutter/flutter#163268)
2025-02-14 victoreronmosele@gmail.com Manually roll customer_testing to enable rfw tests (flutter/flutter#163030)
2025-02-14 ybz975218925@gmail.com Refactor SliverMainAxisGroup for reverse mode. (flutter/flutter#161849)
2025-02-14 30870216+gaaclarke@users.noreply.github.com Tweaked TextContents math to avoid floating point errors (flutter/flutter#162480)
2025-02-14 kevinjchisholm@google.com [release] Update cherry-pick CHANGELOG requirements (flutter/flutter#163318)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 85722a1db585 to 20924303cc25 (2 revisions) (flutter/flutter#163293)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 5a38d23ee247 to 85722a1db585 (1 revision) (flutter/flutter#163286)
2025-02-14 matanlurey@users.noreply.github.com Add `.flutter-plugins-dependencies` to `FlutterBuildSystem`; update logic, add tests. (flutter/flutter#163278)
2025-02-14 jhy03261997@gmail.com Add table related semantics role (flutter/flutter#162339)
2025-02-14 jason-simmons@users.noreply.github.com [Impeller] Call glDebugMessageControlKHR only if the KHR_debug extension is available (flutter/flutter#163273)
2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 748415976ad1 to 5a38d23ee247 (3 revisions) (flutter/flutter#163271)
2025-02-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Use `transferToImageBitmap` instead of `createImageBitmap` (flutter/flutter#163175)
2025-02-14 jacksongardner@google.com [skwasm] Use `transferToImageBitmap` instead of `createImageBitmap` (flutter/flutter#163251)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] ImpellerValidationBreak The source sample count (4) must match the destination sample count (1) for blits.

2 participants

@jonahwilliams @gaaclarke