Skip to content

[web] warm-up frame does not block schedule frame #162779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 6, 2025
Merged

[web] warm-up frame does not block schedule frame #162779

auto-submit merged 1 commit into from
Feb 6, 2025

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Feb 6, 2025

Fix the issue with the first frame not rendering, introduced in #162554.

Nobody filed an issue yet. I found it while testing something else.

@yjbanov yjbanov requested review from goderbauer and mdebbar February 6, 2025 00:14
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Feb 6, 2025
harryterkelsen
harryterkelsen approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2025
@yjbanov yjbanov mentioned this pull request Feb 6, 2025
Merged
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 6, 2025

autosubmit label was removed for flutter/flutter/162779, because - The status or check suite Linux firebase_release_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 6, 2025
Merged via the queue into flutter:master with commit d4772e5 Feb 6, 2025
176 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
f679715 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
bc20d54 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
dde50a8 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
2ded458 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
6fd00f2 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
499cd70 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
54dfc32 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
9cb6f9b 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
08ee6db 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
23cd45c 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
cad00cf 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
4a56b76 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
805f33b 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
03065c7 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
8ffb0a9 
…utter#162779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
ab14c9b 
…utter#162779)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
60562fa 
…utter#162779)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
fd11c3b 
…utter#162779)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
1202e1d 
…utter#162779)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
909729b 
…utter#162779)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
5f794c8 
…utter#162779)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
33817e1 
…utter#162779)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
f2299ca 
…utter#162779)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
d4772e5 [web] warm-up frame does not block schedule frame (flutter/fl…
ba32283 
…utter#162779)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harryterkelsen harryterkelsen harryterkelsen approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

@mdebbar mdebbar Awaiting requested review from mdebbar

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yjbanov @harryterkelsen