Skip to content

No, but really increase the timeout to 60 minutes #162680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtmcdole merged 1 commit into from
Feb 4, 2025
Merged

No, but really increase the timeout to 60 minutes #162680

jtmcdole merged 1 commit into from
Feb 4, 2025

Conversation

@jtmcdole
Copy link
Member

@jtmcdole jtmcdole commented Feb 4, 2025

timeout does work for the overall build timeout.
properties["test_timeout_secs"] does the individual steps timeout.

They should both be set.

@jtmcdole
No, but really increase the timeout to 60 minutes
016598e 
"timeout" does build. properties["test_timeout_secs] does the individual steps  timeout.
@jtmcdole jtmcdole added autosubmit Merge PR when tree becomes green via auto submit App emergency Jump the queue; land PR in front of all others; only use for emergencies labels Feb 4, 2025
christopherfujino
christopherfujino approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtmcdole jtmcdole added this pull request to the merge queue Feb 4, 2025
Merged via the queue into master with commit e7bdde6 Feb 4, 2025
155 of 157 checks passed
@jtmcdole jtmcdole deleted the jtmcdole-patch-1 branch February 4, 2025 18:55
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
39ab52f 
…utter#162680)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
f720e3f 
…utter#162680)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
b836c25 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
594da70 
…utter#162680)
This was referenced Feb 5, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
c716360 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
954469c 
…utter#162680)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
4f1a3ca 
…utter#162680)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
33c2f95 
…utter#162680)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
c76b55f 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
abf9f17 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
6b53789 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
70c7675 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
4f8be3f 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
37d2bfd 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
a7d95d8 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
059f4a7 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
a6e37c7 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
1008246 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
458bbf9 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
12e914d 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
323f9d4 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
5727c54 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
4016703 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
12a31f9 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
9fa47c8 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
ca6ac84 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
7fd25c7 
…utter#162680)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
e7bdde6 No, but really increase the timeout to 60 minutes (flutter/fl…
b10e04b 
…utter#162680)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

emergency Jump the queue; land PR in front of all others; only use for emergencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtmcdole @matanlurey @christopherfujino