Update generate_gradle_lockfiles.dart to handle batch updating kotlin Gradle files
#162628
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
1 similar comment
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
ca40803 |
| include ":app" | ||
| '''; | ||
|
|
||
| const String rootGradleKtsFileContent = r''' |
There was a problem hiding this comment.
Please add a dart doc describing how/when to update this string.
There was a problem hiding this comment.
I gave some sort of instructions. These files are not exactly copy and paste versions of the templates, but are close. So I put a comment saying to consider updating them to reflect changes to the templates.
| } | ||
| '''; | ||
|
|
||
| const String settingsGradleKtsFileContent = r''' |
| } | ||
| plugins { | ||
| id("dev.flutter.flutter-plugin-loader") version "1.0.0" |
There was a problem hiding this comment.
Non blocking: Should we share versions in these strings?
There was a problem hiding this comment.
We could, yeah. We should really move all the examples to kotlin, though. I don't think you can even make the templates output a groovy version anymore? Or if you can I don't know how? I only see .kts files here in the app tmpls:
https://github.com/flutter/flutter/tree/master/packages/flutter_tools/templates/app/android-kotlin.tmpl
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
Also removes the only entry from the exclusion script, as this fixes the reason for its exclusion.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.