Add localization for `Back` and `Cancel` buttons in CupertinoNavigationBar #162581

Michae1Weiss · 2025-02-02T16:30:39Z

Description

This PR adds localization support for the "Back" and "Cancel" buttons used in CupertinoNavigationBar.

Changes:

Introduced cancelButtonLabel and backButtonLabel in CupertinoLocalizations.
~~Updated all ARB files with appropriate translations.~~
Modified _NavigationBarStaticComponents and _BackLabel to use these labels.
Ensured all localization tests pass.
Fixed the test Auto back/close button in the packages/flutter/test/cupertino/localizations_test.dart.

Why is this needed?

Currently, the "Back" and "Cancel" (prev. "Close") buttons in CupertinoNavigationBar are hardcoded in English. This update ensures they are properly localized across supported languages.

Tests

One test failed (even before my changes): Saturation is applied before blur

Manual Testing with the `modal_bottom_sheet` Package

I tested the change using my custom mini app and the modal_bottom_sheet package. I verified that the button is correctly translated into German localization.

Before

After

Button Name Change: From "Close" to "Cancel"

I have renamed the button from "Close" to "Cancel" to align with the iOS native naming convention for buttons in modal dialogs.

Example:

Related Issues

CupertinoNavigationBar's "Close", "Back", and "Cancel" buttons are not localized. #48616
CupertinoNavigationBar's "Back" button is not localized #120722

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

MitchellGoodwin · 2025-02-03T19:35:23Z

Drive by comments: the analyze check is failing. Looks like it's just asking for the imports for navbar to be arranged alphabetically.

For the localizations, our process for adding new strings is to just setup the string for localizations and just have it default to an English string for all localization files: https://github.com/flutter/flutter/blob/master/packages/flutter_localizations/README.md

Then once that's merged the rest is handled by Flutter members within Google. A different team within Google that specializes in translations gives us all the localized strings, which we use to generate the files. What did you use to get all the translations? Even if you used Google translate, that's a lot of effort. cc @QuncCccccc

Michae1Weiss · 2025-02-03T21:43:14Z

Thanks for the information, @MitchellGoodwin. I misinterpreted *"until they can be translated" in the README as a step that needed to be done.

For the translations, I used the ones from Material’s cancelButtonLabel and backButtonTooltip, copying them with this Python script.

Would you like me to revert the translations back to English?

I’ll try to fix the import order tomorrow.

QuncCccccc · 2025-02-04T05:21:37Z

Would you like me to revert the translations back to English?

Yes thanks a lot:) Once the change is merged, we will wait until the translation is finished and then back-integrate the translations :)

For the translations, I used the ones from Material’s cancelButtonLabel and backButtonTooltip, copying them with this Python script.

That's impressive! I'm thinking if these two labels are needed for both material and cupertino, should we move these 2 in widget layer? like in widgets_localizations.dart?

Michae1Weiss · 2025-02-04T18:01:21Z

I've reverted the translations to English and also arranged the imports in nav_bar.dart.

@QuncCccccc I scanned both localization files for duplicates and found 13 other 1:1 matches between Material and Cupertino. So it's not just me! :)

Examples:

Match Type	Cupertino Key	Material Key	Value
✅ Same	`anteMeridiemAbbreviation`	`anteMeridiemAbbreviation`	"AM"
✅ Same	`postMeridiemAbbreviation`	`postMeridiemAbbreviation`	"PM"
🔄 Different Name	`todayLabel`	`currentDateLabel`	"Today"
✅ Same	`alertDialogLabel`	`alertDialogLabel`	"Alert"
🔄 Different Name	`tabSemanticsLabel`	`tabLabel`	"Tab $tabIndex of $tabCount"
✅ Same	`cutButtonLabel`	`cutButtonLabel`	"Cut"
✅ Same	`copyButtonLabel`	`copyButtonLabel`	"Copy"
✅ Same	`pasteButtonLabel`	`pasteButtonLabel`	"Paste"
✅ Same	`lookUpButtonLabel`	`lookUpButtonLabel`	"Look Up"
✅ Same	`searchWebButtonLabel`	`searchWebButtonLabel`	"Search Web"
🔄 Different Name	`searchTextFieldPlaceholderLabel`	`searchFieldLabel`	"Search"
✅ Same	`modalBarrierDismissLabel`	`modalBarrierDismissLabel`	"Dismiss"
✅ Same	`menuDismissLabel`	`menuDismissLabel`	"Dismiss menu"

I think moving these shared translations to widgets_localizations.dart is a great idea! It could be a good subject for a future PR :)

victorsanni · 2025-02-19T00:35:17Z

packages/flutter/lib/src/cupertino/localizations.dart

  /// indicate that a tap outside dismisses the context menu.
  String get menuDismissLabel;

+  /// The label for the cancel button in modal views, used in [CupertinoNavigationBar].


Also add the sliver variant, CupertinoSliverNavigationBar.

victorsanni · 2025-02-19T00:35:24Z

packages/flutter/lib/src/cupertino/localizations.dart

+  /// The label for the cancel button in modal views, used in [CupertinoNavigationBar].
+  String get cancelButtonLabel;
+
+  /// The label for the back button, used in [CupertinoNavigationBar].


victorsanni · 2025-02-19T00:39:40Z

packages/flutter_localizations/lib/src/l10n/cupertino_en.arb

+  },
+  "backButtonLabel": "Back",
+  "@backButtonLabel": {
+    "description": "Label for the back button."


Nit: maybe add a usage?

QuncCccccc

LGTM:) Thanks for your contribution! Once we fixed all the comments, we are good to go!🥳

QuncCccccc · 2025-02-19T00:57:59Z

packages/flutter_localizations/lib/src/l10n/cupertino_en.arb

    "description": "Accessibility announcement for the selected hour on a time picker such as '5 o'clock' or '5点'",
    "plural": "hour"
  },
-


I think we can leave these blank lines, just to be consistent with material_en.arb and widgets_en.arb:)

QuncCccccc · 2025-02-19T00:58:46Z

packages/flutter_localizations/lib/src/l10n/cupertino_en.arb

+  "cancelButtonLabel": "Cancel",
+  "@cancelButtonLabel": {
+    "description": "Label for the cancel button in modal views."
+  },


Suggested change

},

},

QuncCccccc · 2025-02-19T00:59:00Z

packages/flutter_localizations/lib/src/l10n/cupertino_en.arb

  "menuDismissLabel": "Dismiss menu",
  "@menuDismissLabel": {
    "description": "Label read out by accessibility tools (TalkBack or VoiceOver) for the area around a menu to indicate that a tap dismisses the menu."
+  },


Suggested change

},

},

Michae1Weiss · 2025-02-19T18:35:42Z

Thanks for the feedback @victorsanni @QuncCccccc ! I've pushed updates that add newlines between translations, update docstrings to include CupertinoSliverNavigationBar, and enhance the description for backButtonLabel.

…onBar

victorsanni

LGTM. Thanks for the PR.

QuncCccccc

LGTM:) Thanks for the contribution!

…NavigationBar (flutter/flutter#162581)

Roll Flutter from 1659206 to 2e570ca (75 revisions) flutter/flutter@1659206...2e570ca 2025-02-27 engine-flutter-autoroll@skia.org Roll Skia from ac08df9c8d82 to e5a33102401c (1 revision) (flutter/flutter#164288) 2025-02-27 engine-flutter-autoroll@skia.org Roll Skia from 6018dff0233a to ac08df9c8d82 (1 revision) (flutter/flutter#164275) 2025-02-27 engine-flutter-autoroll@skia.org Roll Dart SDK from 4a218fbffc80 to fcda71ce147b (1 revision) (flutter/flutter#164276) 2025-02-27 engine-flutter-autoroll@skia.org Roll Skia from 0f2e106c9abc to 6018dff0233a (1 revision) (flutter/flutter#164266) 2025-02-27 robert.ancell@canonical.com Add windowing channel support to Linux embedder (flutter/flutter#163180) 2025-02-27 engine-flutter-autoroll@skia.org Roll Dart SDK from 7fa5901bd8a3 to 4a218fbffc80 (2 revisions) (flutter/flutter#164260) 2025-02-27 engine-flutter-autoroll@skia.org Roll Skia from fdd97386193e to 0f2e106c9abc (4 revisions) (flutter/flutter#164259) 2025-02-27 codefu@google.com Run more builds faster (flutter/flutter#164125) 2025-02-27 737941+loic-sharma@users.noreply.github.com Increase customer test timeout to 60 minutes (flutter/flutter#164239) 2025-02-27 jason-simmons@users.noreply.github.com Reland "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools" (flutter/flutter#164240) 2025-02-27 liama@google.com Use the Dart isolate ownership API on the root isolate (flutter/flutter#163703) 2025-02-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (flutter/flutter#164243) 2025-02-26 robert.ancell@canonical.com Show Linux driver information in flutter doctor (flutter/flutter#163980) 2025-02-26 34871572+gmackall@users.noreply.github.com Implement opacity `FlutterMutator` for hcpp (flutter/flutter#164147) 2025-02-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (flutter/flutter#164232) 2025-02-26 engine-flutter-autoroll@skia.org Roll Skia from 47b84f354604 to fdd97386193e (8 revisions) (flutter/flutter#164221) 2025-02-26 jonahwilliams@google.com [Impeller] Reland: move AHB check into Flutter main, don't disable ImageReader on 29. (flutter/flutter#164201) 2025-02-26 engine-flutter-autoroll@skia.org Roll Dart SDK from 80865748abe0 to 7fa5901bd8a3 (3 revisions) (flutter/flutter#164226) 2025-02-26 68449066+zijiehe-google-com@users.noreply.github.com Update fuchsia_test_scripts_version to the latest version (flutter/flutter#164123) 2025-02-26 brackenavaron@gmail.com Guard against zero item extent for carousel (flutter/flutter#163310) 2025-02-26 jonahwilliams@google.com [Impeller] work around for crashy Nexus 5 Driver. (flutter/flutter#164040) 2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (#163890)" (flutter/flutter#164209) 2025-02-26 48155875+Michae1Weiss@users.noreply.github.com Add localization for `Back` and `Cancel` buttons in CupertinoNavigationBar (flutter/flutter#162581) 2025-02-26 30870216+gaaclarke@users.noreply.github.com Added compilation failure if a max ubo size is exceeded (flutter/flutter#164038) 2025-02-26 engine-flutter-autoroll@skia.org Roll Skia from 5336e20498d9 to 47b84f354604 (2 revisions) (flutter/flutter#164188) 2025-02-26 jason-simmons@users.noreply.github.com Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (flutter/flutter#163890) 2025-02-26 engine-flutter-autoroll@skia.org Roll Skia from 3ce6f25dc13e to 5336e20498d9 (9 revisions) (flutter/flutter#164174) 2025-02-26 engine-flutter-autoroll@skia.org Roll Dart SDK from b8292dfeaa67 to 80865748abe0 (9 revisions) (flutter/flutter#164168) 2025-02-26 dkwingsmt@users.noreply.github.com [Engine] Remove dead code for RoundedSuperellipse (flutter/flutter#164163) 2025-02-26 jonahwilliams@google.com [Impeller] detect mediatek soc and fall back to GLES. (flutter/flutter#164126) 2025-02-26 jonahwilliams@google.com [Impeller] make DLOG into LOG for startup errors. (flutter/flutter#164110) 2025-02-26 15619084+vashworth@users.noreply.github.com Intercept error when iOS 18.4 crashes with JIT mode and give guided error (flutter/flutter#164072) 2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (#164109)" (flutter/flutter#164166) 2025-02-26 zanderso@users.noreply.github.com Run new gallery transition perf benchmark on Galaxy S24 (flutter/flutter#163665) 2025-02-26 jonahwilliams@google.com [Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (flutter/flutter#164109) 2025-02-26 chris@bracken.jp [iOS] Add platform view to integration_test example (flutter/flutter#164144) 2025-02-26 dominik@honnef.co Fix minor issues in documentation of WidgetsApp (flutter/flutter#163942) 2025-02-26 louisehsu@google.com Fix extra numbers showing up when enabling VoiceControl (flutter/flutter#163593) 2025-02-26 cloud@pathconnected.net Set SliverResizingHeader's maxScrollObstructionExtent to minExtent (flutter/flutter#162955) 2025-02-26 engine-flutter-autoroll@skia.org Roll Dart SDK from aea6fff33f06 to b8292dfeaa67 (1 revision) (flutter/flutter#163973) 2025-02-26 flar@google.com [DisplayList] Delete all legacy Skia-oriented method overloads in DlCanvas (flutter/flutter#164054) 2025-02-25 polinach@google.com Clean up leak tracker instrumentation tech debt. (flutter/flutter#164070) 2025-02-25 magder@google.com Revert "Marks Linux_pixel_7pro service_extensions_test to be flaky" (flutter/flutter#163882) 2025-02-25 magder@google.com Check if simctl is installed before trying to list devices or runtimes (flutter/flutter#163895) 2025-02-25 magder@google.com Update dragDevices doc to include default PointerDeviceKind.trackpad (flutter/flutter#163898) 2025-02-25 reidbaker@google.com Update multiple flutters benchmark test to latest gradle and agp and gradle defined dependencies (flutter/flutter#164029) ...

…NavigationBar (flutter/flutter#162581)

Roll Flutter from 1659206 to 2e570ca (75 revisions) flutter/flutter@1659206...2e570ca 2025-02-27 engine-flutter-autoroll@skia.org Roll Skia from ac08df9c8d82 to e5a33102401c (1 revision) (flutter/flutter#164288) 2025-02-27 engine-flutter-autoroll@skia.org Roll Skia from 6018dff0233a to ac08df9c8d82 (1 revision) (flutter/flutter#164275) 2025-02-27 engine-flutter-autoroll@skia.org Roll Dart SDK from 4a218fbffc80 to fcda71ce147b (1 revision) (flutter/flutter#164276) 2025-02-27 engine-flutter-autoroll@skia.org Roll Skia from 0f2e106c9abc to 6018dff0233a (1 revision) (flutter/flutter#164266) 2025-02-27 robert.ancell@canonical.com Add windowing channel support to Linux embedder (flutter/flutter#163180) 2025-02-27 engine-flutter-autoroll@skia.org Roll Dart SDK from 7fa5901bd8a3 to 4a218fbffc80 (2 revisions) (flutter/flutter#164260) 2025-02-27 engine-flutter-autoroll@skia.org Roll Skia from fdd97386193e to 0f2e106c9abc (4 revisions) (flutter/flutter#164259) 2025-02-27 codefu@google.com Run more builds faster (flutter/flutter#164125) 2025-02-27 737941+loic-sharma@users.noreply.github.com Increase customer test timeout to 60 minutes (flutter/flutter#164239) 2025-02-27 jason-simmons@users.noreply.github.com Reland "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools" (flutter/flutter#164240) 2025-02-27 liama@google.com Use the Dart isolate ownership API on the root isolate (flutter/flutter#163703) 2025-02-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (flutter/flutter#164243) 2025-02-26 robert.ancell@canonical.com Show Linux driver information in flutter doctor (flutter/flutter#163980) 2025-02-26 34871572+gmackall@users.noreply.github.com Implement opacity `FlutterMutator` for hcpp (flutter/flutter#164147) 2025-02-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (flutter/flutter#164232) 2025-02-26 engine-flutter-autoroll@skia.org Roll Skia from 47b84f354604 to fdd97386193e (8 revisions) (flutter/flutter#164221) 2025-02-26 jonahwilliams@google.com [Impeller] Reland: move AHB check into Flutter main, don't disable ImageReader on 29. (flutter/flutter#164201) 2025-02-26 engine-flutter-autoroll@skia.org Roll Dart SDK from 80865748abe0 to 7fa5901bd8a3 (3 revisions) (flutter/flutter#164226) 2025-02-26 68449066+zijiehe-google-com@users.noreply.github.com Update fuchsia_test_scripts_version to the latest version (flutter/flutter#164123) 2025-02-26 brackenavaron@gmail.com Guard against zero item extent for carousel (flutter/flutter#163310) 2025-02-26 jonahwilliams@google.com [Impeller] work around for crashy Nexus 5 Driver. (flutter/flutter#164040) 2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (#163890)" (flutter/flutter#164209) 2025-02-26 48155875+Michae1Weiss@users.noreply.github.com Add localization for `Back` and `Cancel` buttons in CupertinoNavigationBar (flutter/flutter#162581) 2025-02-26 30870216+gaaclarke@users.noreply.github.com Added compilation failure if a max ubo size is exceeded (flutter/flutter#164038) 2025-02-26 engine-flutter-autoroll@skia.org Roll Skia from 5336e20498d9 to 47b84f354604 (2 revisions) (flutter/flutter#164188) 2025-02-26 jason-simmons@users.noreply.github.com Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (flutter/flutter#163890) 2025-02-26 engine-flutter-autoroll@skia.org Roll Skia from 3ce6f25dc13e to 5336e20498d9 (9 revisions) (flutter/flutter#164174) 2025-02-26 engine-flutter-autoroll@skia.org Roll Dart SDK from b8292dfeaa67 to 80865748abe0 (9 revisions) (flutter/flutter#164168) 2025-02-26 dkwingsmt@users.noreply.github.com [Engine] Remove dead code for RoundedSuperellipse (flutter/flutter#164163) 2025-02-26 jonahwilliams@google.com [Impeller] detect mediatek soc and fall back to GLES. (flutter/flutter#164126) 2025-02-26 jonahwilliams@google.com [Impeller] make DLOG into LOG for startup errors. (flutter/flutter#164110) 2025-02-26 15619084+vashworth@users.noreply.github.com Intercept error when iOS 18.4 crashes with JIT mode and give guided error (flutter/flutter#164072) 2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (#164109)" (flutter/flutter#164166) 2025-02-26 zanderso@users.noreply.github.com Run new gallery transition perf benchmark on Galaxy S24 (flutter/flutter#163665) 2025-02-26 jonahwilliams@google.com [Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (flutter/flutter#164109) 2025-02-26 chris@bracken.jp [iOS] Add platform view to integration_test example (flutter/flutter#164144) 2025-02-26 dominik@honnef.co Fix minor issues in documentation of WidgetsApp (flutter/flutter#163942) 2025-02-26 louisehsu@google.com Fix extra numbers showing up when enabling VoiceControl (flutter/flutter#163593) 2025-02-26 cloud@pathconnected.net Set SliverResizingHeader's maxScrollObstructionExtent to minExtent (flutter/flutter#162955) 2025-02-26 engine-flutter-autoroll@skia.org Roll Dart SDK from aea6fff33f06 to b8292dfeaa67 (1 revision) (flutter/flutter#163973) 2025-02-26 flar@google.com [DisplayList] Delete all legacy Skia-oriented method overloads in DlCanvas (flutter/flutter#164054) 2025-02-25 polinach@google.com Clean up leak tracker instrumentation tech debt. (flutter/flutter#164070) 2025-02-25 magder@google.com Revert "Marks Linux_pixel_7pro service_extensions_test to be flaky" (flutter/flutter#163882) 2025-02-25 magder@google.com Check if simctl is installed before trying to list devices or runtimes (flutter/flutter#163895) 2025-02-25 magder@google.com Update dragDevices doc to include default PointerDeviceKind.trackpad (flutter/flutter#163898) 2025-02-25 reidbaker@google.com Update multiple flutters benchmark test to latest gradle and agp and gradle defined dependencies (flutter/flutter#164029) ...

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository labels Feb 2, 2025

Michae1Weiss mentioned this pull request Feb 2, 2025

Support CupertinoSliverNavigationBar.search with condensed large title #159120

Merged

9 tasks

Michae1Weiss force-pushed the cupertino-add-cancel-back-localization branch from d7c5d00 to ea8e077 Compare February 4, 2025 22:24

Piinks requested a review from victorsanni February 5, 2025 19:28

Michae1Weiss force-pushed the cupertino-add-cancel-back-localization branch 5 times, most recently from 247ee8f to 39d1f56 Compare February 13, 2025 08:49

victorsanni reviewed Feb 19, 2025

View reviewed changes

victorsanni requested a review from QuncCccccc February 19, 2025 00:43

QuncCccccc reviewed Feb 19, 2025

View reviewed changes

Michae1Weiss force-pushed the cupertino-add-cancel-back-localization branch 2 times, most recently from 71631f9 to 4cf0049 Compare February 19, 2025 18:33

Michae1Weiss added 8 commits February 20, 2025 16:57

Add localization for 'Back' and 'Cancel' buttons in CupertinoNavigati…

c92a97b

…onBar

Revert translations to English

3df9554

Arrange imports alphabetically in nav_bar

7a65881

Format nav_bar

a8068e7

Localize _CancelButton

5d962fb

Cache CupertinoLocalizations in build methods

d942dc8

Fix missing CupertinoLocalizations error in tests

ab4a43e

Add usage note for backButtonLabel, update docs and ARB formatting

2305ead

Michae1Weiss force-pushed the cupertino-add-cancel-back-localization branch from 4cf0049 to 2305ead Compare February 20, 2025 15:57

dkwingsmt requested review from QuncCccccc and victorsanni February 25, 2025 19:41

victorsanni approved these changes Feb 25, 2025

View reviewed changes

QuncCccccc approved these changes Feb 25, 2025

View reviewed changes

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 26, 2025

auto-submit bot added this pull request to the merge queue Feb 26, 2025

Merged via the queue into flutter:master with commit af15a1e Feb 26, 2025
176 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 26, 2025

engine-flutter-autoroll mentioned this pull request Feb 26, 2025

Roll Flutter from 911aa7547ed7 to af15a1eb7684 (75 revisions) flutter/packages#8721

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

af15a1e Add localization for Back and Cancel buttons in Cupertino…

140818c

…NavigationBar (flutter/flutter#162581)

engine-flutter-autoroll mentioned this pull request Feb 26, 2025

Roll Flutter from 911aa7547ed7 to 0b96fa88fd83 (77 revisions) flutter/packages#8722

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

af15a1e Add localization for Back and Cancel buttons in Cupertino…

520801e

…NavigationBar (flutter/flutter#162581)

engine-flutter-autoroll mentioned this pull request Feb 27, 2025

Roll Flutter from 16592066d70b to 2e570ca393c8 (75 revisions) flutter/packages#8731

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025

af15a1e Add localization for Back and Cancel buttons in Cupertino…

be0ffe9

…NavigationBar (flutter/flutter#162581)

Piinks mentioned this pull request Mar 7, 2025

Flutter Notable Commits - 2025 #161460

Open

victorsanni mentioned this pull request Apr 3, 2025

CupertinoNavigationBar's "Close", "Back", and "Cancel" buttons are not localized. #48616

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

af15a1e Add localization for Back and Cancel buttons in Cupertino…

b898290

…NavigationBar (flutter/flutter#162581)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

af15a1e Add localization for Back and Cancel buttons in Cupertino…

ae6c6ab

…NavigationBar (flutter/flutter#162581)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

af15a1e Add localization for Back and Cancel buttons in Cupertino…

e9fd81e

…NavigationBar (flutter/flutter#162581)

Add localization for Back and Cancel buttons in CupertinoNavigationBar #162581

Add localization for Back and Cancel buttons in CupertinoNavigationBar #162581

Uh oh!

Conversation

Michae1Weiss commented Feb 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes:

Why is this needed?

Tests

Manual Testing with the modal_bottom_sheet Package

Before

After

Button Name Change: From "Close" to "Cancel"

Example:

Related Issues

Pre-launch Checklist

Uh oh!

MitchellGoodwin commented Feb 3, 2025

Uh oh!

Michae1Weiss commented Feb 3, 2025

Uh oh!

QuncCccccc commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Michae1Weiss commented Feb 4, 2025

Uh oh!

victorsanni Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

Michae1Weiss commented Feb 19, 2025

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add localization for `Back` and `Cancel` buttons in CupertinoNavigationBar #162581

Add localization for `Back` and `Cancel` buttons in CupertinoNavigationBar #162581

Michae1Weiss commented Feb 2, 2025 •

edited

Loading

Manual Testing with the `modal_bottom_sheet` Package

QuncCccccc commented Feb 4, 2025 •

edited

Loading