Skip to content

Fix DropdownMenu example RenderFlex overflowed error #162558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Feb 7, 2025
Merged

Fix DropdownMenu example RenderFlex overflowed error #162558

auto-submit merged 4 commits into from
Feb 7, 2025

Conversation

@huycozy
Copy link
Member

@huycozy huycozy commented Feb 1, 2025

Fix #162506

before after
Screen.Recording.2025-01-31.at.16.20.40.mov

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@huycozy huycozy self-assigned this Feb 1, 2025
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Feb 1, 2025
@huynguyennovem huynguyennovem force-pushed the fix_dropdownmenu_sample_overflowerror branch from fc5d5b1 to c745de1 Compare February 2, 2025 04:07
PurplePolyhedron
PurplePolyhedron reviewed Feb 2, 2025
View reviewed changes
Copy link
Contributor

@PurplePolyhedron PurplePolyhedron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrolling is a valid choice. I personally think wrapping could fit a small screen better, but the implementation is complex so it could take focus away from the DropdownMenu example.

bleroux
bleroux reviewed Feb 6, 2025
View reviewed changes
TahaTesser
TahaTesser requested changes Feb 6, 2025
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased this comment

@huycozy
Fix DropdownMenu example enderFlex overflowed error
36703d0 
Signed-off-by: huycozy <huy@nevercode.io>
@huycozy
fixup: correct assertion
f7ca2af 
Signed-off-by: huycozy <huy@nevercode.io>
@huycozy
fixup: Rephrase comments
83beef0 
Signed-off-by: huycozy <huy@nevercode.io>
@huycozy
fixup: Analysis issue: remove unuse import
fa90d76 
Signed-off-by: huycozy <huy@nevercode.io>
@huynguyennovem huynguyennovem force-pushed the fix_dropdownmenu_sample_overflowerror branch from decf8dc to fa90d76 Compare February 7, 2025 03:33
bleroux
bleroux approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huycozy huycozy added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 7, 2025

autosubmit label was removed for flutter/flutter/162558, because This PR has not met approval requirements for merging. Changes were requested by {TahaTesser}, please make the needed changes and resubmit this PR.
The PR author is a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

TahaTesser
TahaTesser approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 7, 2025
Merged via the queue into flutter:master with commit 44203b6 Feb 7, 2025
45 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2025
@huycozy huycozy deleted the fix_dropdownmenu_sample_overflowerror branch February 7, 2025 11:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
fc44407 
…/flutter#162558)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
584c0c5 
…/flutter#162558)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
0fd0083 
…/flutter#162558)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
e3b87f9 
…/flutter#162558)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
a3b7d6b 
…/flutter#162558)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
b5170f6 
…/flutter#162558)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
017af71 
…/flutter#162558)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
03c43a3 
…/flutter#162558)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
e414983 
…/flutter#162558)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
4fc42ba 
…/flutter#162558)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
b19e028 
…/flutter#162558)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
002f180 
…/flutter#162558)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
8a98303 
…/flutter#162558)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
5907f3d 
…/flutter#162558)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
bddeb54 
…/flutter#162558)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
fe77156 
…/flutter#162558)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
e13b374 
…/flutter#162558)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
bd1e36c 
…/flutter#162558)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
67a65b3 
…/flutter#162558)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
44203b6 Fix DropdownMenu example RenderFlex overflowed error (flutter…
afa4cd1 
…/flutter#162558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bleroux bleroux bleroux approved these changes

@TahaTesser TahaTesser TahaTesser approved these changes

+1 more reviewer

@PurplePolyhedron PurplePolyhedron PurplePolyhedron left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@huycozy huycozy

Labels

d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DropdownMenu's example encounters layout error when being putted in small frame (docs page)

4 participants

@huycozy @bleroux @TahaTesser @PurplePolyhedron