Skip to content

[web] Unskip some paragraph tests that are passing now #162537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdebbar merged 3 commits into from
Feb 3, 2025
Merged

[web] Unskip some paragraph tests that are passing now #162537

mdebbar merged 3 commits into from
Feb 3, 2025

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jan 31, 2025

Closes #83129
Closes #61020
Closes #61021

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 31, 2025
eyebrowsoffire
eyebrowsoffire approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM!

@mdebbar mdebbar added this pull request to the merge queue Feb 3, 2025
Merged via the queue into flutter:master with commit a612fda Feb 3, 2025
76 checks passed
@mdebbar mdebbar deleted the unskip_paragraph_tests branch February 3, 2025 21:05
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
4c6daff 
…er/flutter#162537)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
af8f160 
…er/flutter#162537)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
7fdbd5d 
…er/flutter#162537)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
c390775 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
9aecb68 
…er/flutter#162537)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
1c4c20b 
…er/flutter#162537)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
18c4178 
…er/flutter#162537)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
726d925 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
8136128 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
5ab51f7 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
1342cc2 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
bac9b47 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
25b30fa 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
6317180 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
18fb938 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
3b10861 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
29f4130 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
b8c6a80 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
09eab50 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
b3c4b2c 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
3b7030b 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
c2000b2 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
9c53ba8 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
b299ff9 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
2251f21 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
2c00719 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
e731136 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
da7546b 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
8444e14 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
d6c0a98 
…er/flutter#162537)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
a612fda [web] Unskip some paragraph tests that are passing now (flutt…
c458dd8 
…er/flutter#162537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

editable_test.dart not font-hermetic on web [Web] Key simulation does not work on web [Web] RenderParagraph fails to drawFrame in broken tests

2 participants

@mdebbar @eyebrowsoffire