Skip to content

[semantics] Use a switch over a map to enumerate checks #162424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 6 commits into from
Feb 4, 2025
Merged

[semantics] Use a switch over a map to enumerate checks #162424

auto-submit merged 6 commits into from
Feb 4, 2025

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Jan 30, 2025 •
edited
Loading

  • eliminates a const map and a typedef
  • leverage switch + enum language check to ensure coverage
  • eliminates a runtime null check
  • Can make the check class private

@kevmoo
[semantics] Use a switch over a map to enumerate checks
639995a 
- eliminates a const map and a typedef
- leverage switch + enum language check to ensure coverage
- eliminates a runtime null check
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Jan 30, 2025
@kevmoo kevmoo requested a review from chunhtai January 30, 2025 01:30
@kevmoo
Copy link
Contributor Author

kevmoo commented Jan 30, 2025

Assuming tests pass, I think this is a cleaner impl. Thoughts?

chunhtai
chunhtai approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 30, 2025

autosubmit label was removed for flutter/flutter/162424, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 30, 2025

autosubmit label was removed for flutter/flutter/162424, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 30, 2025

autosubmit label was removed for flutter/flutter/162424, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 31, 2025

autosubmit label was removed for flutter/flutter/162424, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 4, 2025

autosubmit label was removed for flutter/flutter/162424, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 4, 2025
Merged via the queue into master with commit 61865ec Feb 4, 2025
82 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
b5a20e3 
…ter/flutter#162424)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
08b2d01 
…ter/flutter#162424)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
5abfda8 
…ter/flutter#162424)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
d149131 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
db02bcd 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
993f985 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
e85ad68 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
8395159 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
a4cf3d9 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
79da8fa 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
d6f1213 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
3920d86 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
bf2832d 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
4bf4149 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
b29a1cf 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
f4bb264 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
6d2a297 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
266be73 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
31231a0 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
4782cc4 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
4bae751 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
099d4a2 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
4c6e85a 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
bf9652f 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
ee10c34 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
022382e 
…ter/flutter#162424)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
61865ec [semantics] Use a switch over a map to enumerate checks (flut…
770a557 
…ter/flutter#162424)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevmoo @chunhtai