Skip to content

[web] Remove HTML from the engine's test suites #162404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 9 commits into from
Feb 3, 2025
Merged

[web] Remove HTML from the engine's test suites #162404

auto-submit merged 9 commits into from
Feb 3, 2025

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jan 29, 2025

  • Remove html bundles/suites from configs and CI.
  • Delete html test files.
  • Replace the isHtml helper with false and refactor accordingly.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Jan 29, 2025
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 29, 2025

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162404 at sha e38da0a

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jan 29, 2025
yjbanov
yjbanov approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 31, 2025

autosubmit label was removed for flutter/flutter/162404, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 3, 2025
Merged via the queue into flutter:master with commit 041d524 Feb 3, 2025
177 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
ba64cf4 
…ter#162404)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
2888bba 
…ter#162404)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
bed9c4e 
…ter#162404)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
c5721aa 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
61e64b5 
…ter#162404)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
91ba35f 
…ter#162404)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
eec7259 
…ter#162404)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
0aab4f6 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
5a1b53f 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
f673e75 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
fdfa412 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
29f3a21 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
4e02535 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
66f0e0b 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
090e043 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
85596c3 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
d609822 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
8df29ea 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
cbf5c6a 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
a58235d 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
367da28 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
7287b62 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
bb7d439 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
1574d44 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
4e9beca 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
f6cff15 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
9027b97 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
501673a 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
ef9302f 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
9aa42e2 
…ter#162404)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
041d524 [web] Remove HTML from the engine's test suites (flutter/flut…
8220bf3 
…ter#162404)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdebbar @yjbanov