Skip to content

Revert "Marks Mac_benchmark flutter_gallery_macos__compile to be flaky" #162039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Feb 12, 2025
Merged

Revert "Marks Mac_benchmark flutter_gallery_macos__compile to be flaky" #162039

auto-submit merged 2 commits into from
Feb 12, 2025

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 22, 2025

Reverts #160496

This is no longer flaky.

Closes #160495

@jmagman jmagman requested a review from cbracken January 22, 2025 22:29
@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025
@jmagman jmagman mentioned this pull request Jan 22, 2025
Closed
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 22, 2025

auto label is removed for flutter/flutter/162039, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025
@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 12, 2025
Merged via the queue into master with commit 3011859 Feb 12, 2025
157 of 158 checks passed
@auto-submit auto-submit bot deleted the revert-160496-5lI7ZT3ikn branch February 12, 2025 21:20
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
8b89abc 
… be flaky" (flutter/flutter#162039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
4f834ab 
… be flaky" (flutter/flutter#162039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
a127ee3 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
f8cb4f8 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
f5cf1a2 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
c392875 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
f2e3829 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
7b5c5de 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
4972769 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
dd24ceb 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
bb1ff28 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
eb06dda 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
71e3304 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
0ab2249 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
5ac592e 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
52a96df 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
3f69b1c 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
9f6b050 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
c2c119f 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
000dc12 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
cdcd955 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
65d8950 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
cd32f8c 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
c5c2f60 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
0f83404 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
ec333ed 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
dc36418 
… be flaky" (flutter/flutter#162039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
3011859 Revert "Marks Mac_benchmark flutter_gallery_macos__compile to…
aae5fb6 
… be flaky" (flutter/flutter#162039)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mac_benchmark flutter_gallery_macos__compile is 2.15% flaky

2 participants

@jmagman @cbracken