Skip to content

route CLI command usage information through the logger instead of using print #161533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Jan 16, 2025
Merged

route CLI command usage information through the logger instead of using print #161533

auto-submit merged 5 commits into from
Jan 16, 2025

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Jan 13, 2025 •
edited
Loading

Fixes #158532

Pre-launch checklist

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 13, 2025
@andrewkolos andrewkolos force-pushed the use-logger-for-printUsage branch from 66eee69 to cf9a3c8 Compare January 13, 2025 21:58
@andrewkolos andrewkolos marked this pull request as ready for review January 13, 2025 23:11
@andrewkolos andrewkolos requested a review from bkonyi January 13, 2025 23:13
@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 16, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jan 16, 2025
matanlurey
matanlurey approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

Merged via the queue into flutter:master with commit 5a3541c Jan 16, 2025
165 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 16, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2025
@engine-flutter-autoroll
5a3541c route CLI command usage information through the logger instea…
f591570 
…d of using `print` (flutter/flutter#161533)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2025
@engine-flutter-autoroll
5a3541c route CLI command usage information through the logger instea…
6460fd2 
…d of using `print` (flutter/flutter#161533)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2025
@engine-flutter-autoroll
5a3541c route CLI command usage information through the logger instea…
f305b1d 
…d of using `print` (flutter/flutter#161533)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 18, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2025
@engine-flutter-autoroll
5a3541c route CLI command usage information through the logger instea…
3ab73e5 
…d of using `print` (flutter/flutter#161533)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2025
@engine-flutter-autoroll
5a3541c route CLI command usage information through the logger instea…
4a42dba 
…d of using `print` (flutter/flutter#161533)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 20, 2025
@engine-flutter-autoroll
Roll Flutter from 5517cc9 to b9e86a5 (22 revisions) (#8458)
6dee381 
flutter/flutter@5517cc9...b9e86a5

2025-01-18 737941+loic-sharma@users.noreply.github.com Fix link to Linux custom embedder artifacts (flutter/flutter#161699)
2025-01-18 matanlurey@users.noreply.github.com Remove tests, GLFW examples, and non-artifact builds from `linux_host_engine`. (flutter/flutter#161786)
2025-01-18 jonahwilliams@google.com [Impeller] when mips are disabled, also disable from sampler options. (flutter/flutter#161765)
2025-01-18 lukepighetti@gmail.com revert removing Twitter, retain BlueSky (flutter/flutter#161803)
2025-01-17 yjbanov@google.com fix reorderable_list_test.dart (flutter/flutter#161836)
2025-01-17 kevinjchisholm@google.com [Release] Update the cherry-pick process. (flutter/flutter#161771)
2025-01-17 victorsanniay@gmail.com Reland "#143249 Autocomplete options width" (flutter/flutter#161695)
2025-01-17 a-siva@users.noreply.github.com Roll Dart to Version 3.8.0-1.0.dev (flutter/flutter#161781)
2025-01-17 jonahwilliams@google.com [Impeller] use 3 fences to synchronize AHB swapchains (like we do for KHR). (flutter/flutter#161767)
2025-01-17 jonahwilliams@google.com [Impeller] remove Adreno denylist entries. (flutter/flutter#161740)
2025-01-17 robert.ancell@canonical.com Refactor event redispatching (flutter/flutter#161701)
2025-01-17 jonahwilliams@google.com [Impellerc] correctly pad arrays of vec3s in reflector. (flutter/flutter#161697)
2025-01-17 jason-simmons@users.noreply.github.com Initialize dartLoader.rootDirectories so the Web stack trace mapper can convert package source paths (flutter/flutter#160383)
2025-01-16 robert.ancell@canonical.com Make fl_keyboard_manager_handle_event async (flutter/flutter#161637)
2025-01-16 kevmoo@users.noreply.github.com Update social links in readme (flutter/flutter#161778)
2025-01-16 robert.ancell@canonical.com Remove some stray printf debugging (flutter/flutter#161706)
2025-01-16 58529443+srujzs@users.noreply.github.com Set meta tag in default index (flutter/flutter#161493)
2025-01-16 andrewrkolos@gmail.com remove usage of `Usage` from build system (flutter/flutter#160663)
2025-01-16 andrewrkolos@gmail.com route CLI command usage information through the logger instead of using `print` (flutter/flutter#161533)
2025-01-16 matanlurey@users.noreply.github.com Enable duplicate `linux_host_engine_test`. (flutter/flutter#161613)
2025-01-16 58190796+MitchellGoodwin@users.noreply.github.com Do not block vertical drag gestures in CupertinoSheetRoute body (flutter/flutter#161696)
2025-01-16 jonahwilliams@google.com [Impeller] Update partial repaint to use a fullsize onscreen. (flutter/flutter#161626)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5a3541c route CLI command usage information through the logger instea…
975e429 
…d of using `print` (flutter/flutter#161533)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5a3541c route CLI command usage information through the logger instea…
f9b049a 
…d of using `print` (flutter/flutter#161533)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
5a3541c route CLI command usage information through the logger instea…
a5a28bf 
…d of using `print` (flutter/flutter#161533)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from 5517cc9 to b9e86a5 (22 revisions) (flutter#8458)
a16f287 
flutter/flutter@5517cc9...b9e86a5

2025-01-18 737941+loic-sharma@users.noreply.github.com Fix link to Linux custom embedder artifacts (flutter/flutter#161699)
2025-01-18 matanlurey@users.noreply.github.com Remove tests, GLFW examples, and non-artifact builds from `linux_host_engine`. (flutter/flutter#161786)
2025-01-18 jonahwilliams@google.com [Impeller] when mips are disabled, also disable from sampler options. (flutter/flutter#161765)
2025-01-18 lukepighetti@gmail.com revert removing Twitter, retain BlueSky (flutter/flutter#161803)
2025-01-17 yjbanov@google.com fix reorderable_list_test.dart (flutter/flutter#161836)
2025-01-17 kevinjchisholm@google.com [Release] Update the cherry-pick process. (flutter/flutter#161771)
2025-01-17 victorsanniay@gmail.com Reland "#143249 Autocomplete options width" (flutter/flutter#161695)
2025-01-17 a-siva@users.noreply.github.com Roll Dart to Version 3.8.0-1.0.dev (flutter/flutter#161781)
2025-01-17 jonahwilliams@google.com [Impeller] use 3 fences to synchronize AHB swapchains (like we do for KHR). (flutter/flutter#161767)
2025-01-17 jonahwilliams@google.com [Impeller] remove Adreno denylist entries. (flutter/flutter#161740)
2025-01-17 robert.ancell@canonical.com Refactor event redispatching (flutter/flutter#161701)
2025-01-17 jonahwilliams@google.com [Impellerc] correctly pad arrays of vec3s in reflector. (flutter/flutter#161697)
2025-01-17 jason-simmons@users.noreply.github.com Initialize dartLoader.rootDirectories so the Web stack trace mapper can convert package source paths (flutter/flutter#160383)
2025-01-16 robert.ancell@canonical.com Make fl_keyboard_manager_handle_event async (flutter/flutter#161637)
2025-01-16 kevmoo@users.noreply.github.com Update social links in readme (flutter/flutter#161778)
2025-01-16 robert.ancell@canonical.com Remove some stray printf debugging (flutter/flutter#161706)
2025-01-16 58529443+srujzs@users.noreply.github.com Set meta tag in default index (flutter/flutter#161493)
2025-01-16 andrewrkolos@gmail.com remove usage of `Usage` from build system (flutter/flutter#160663)
2025-01-16 andrewrkolos@gmail.com route CLI command usage information through the logger instead of using `print` (flutter/flutter#161533)
2025-01-16 matanlurey@users.noreply.github.com Enable duplicate `linux_host_engine_test`. (flutter/flutter#161613)
2025-01-16 58190796+MitchellGoodwin@users.noreply.github.com Do not block vertical drag gestures in CupertinoSheetRoute body (flutter/flutter#161696)
2025-01-16 jonahwilliams@google.com [Impeller] Update partial repaint to use a fullsize onscreen. (flutter/flutter#161626)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 5517cc9 to b9e86a5 (22 revisions) (flutter#8458)
f0c6add 
flutter/flutter@5517cc9...b9e86a5

2025-01-18 737941+loic-sharma@users.noreply.github.com Fix link to Linux custom embedder artifacts (flutter/flutter#161699)
2025-01-18 matanlurey@users.noreply.github.com Remove tests, GLFW examples, and non-artifact builds from `linux_host_engine`. (flutter/flutter#161786)
2025-01-18 jonahwilliams@google.com [Impeller] when mips are disabled, also disable from sampler options. (flutter/flutter#161765)
2025-01-18 lukepighetti@gmail.com revert removing Twitter, retain BlueSky (flutter/flutter#161803)
2025-01-17 yjbanov@google.com fix reorderable_list_test.dart (flutter/flutter#161836)
2025-01-17 kevinjchisholm@google.com [Release] Update the cherry-pick process. (flutter/flutter#161771)
2025-01-17 victorsanniay@gmail.com Reland "#143249 Autocomplete options width" (flutter/flutter#161695)
2025-01-17 a-siva@users.noreply.github.com Roll Dart to Version 3.8.0-1.0.dev (flutter/flutter#161781)
2025-01-17 jonahwilliams@google.com [Impeller] use 3 fences to synchronize AHB swapchains (like we do for KHR). (flutter/flutter#161767)
2025-01-17 jonahwilliams@google.com [Impeller] remove Adreno denylist entries. (flutter/flutter#161740)
2025-01-17 robert.ancell@canonical.com Refactor event redispatching (flutter/flutter#161701)
2025-01-17 jonahwilliams@google.com [Impellerc] correctly pad arrays of vec3s in reflector. (flutter/flutter#161697)
2025-01-17 jason-simmons@users.noreply.github.com Initialize dartLoader.rootDirectories so the Web stack trace mapper can convert package source paths (flutter/flutter#160383)
2025-01-16 robert.ancell@canonical.com Make fl_keyboard_manager_handle_event async (flutter/flutter#161637)
2025-01-16 kevmoo@users.noreply.github.com Update social links in readme (flutter/flutter#161778)
2025-01-16 robert.ancell@canonical.com Remove some stray printf debugging (flutter/flutter#161706)
2025-01-16 58529443+srujzs@users.noreply.github.com Set meta tag in default index (flutter/flutter#161493)
2025-01-16 andrewrkolos@gmail.com remove usage of `Usage` from build system (flutter/flutter#160663)
2025-01-16 andrewrkolos@gmail.com route CLI command usage information through the logger instead of using `print` (flutter/flutter#161533)
2025-01-16 matanlurey@users.noreply.github.com Enable duplicate `linux_host_engine_test`. (flutter/flutter#161613)
2025-01-16 58190796+MitchellGoodwin@users.noreply.github.com Do not block vertical drag gestures in CupertinoSheetRoute body (flutter/flutter#161696)
2025-01-16 jonahwilliams@google.com [Impeller] Update partial repaint to use a fullsize onscreen. (flutter/flutter#161626)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@bkonyi bkonyi bkonyi approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FlutterCommand.usage should write to Logger by default, not global print.

3 participants

@andrewkolos @matanlurey @bkonyi