-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Fix: Ensure CupertinoAlertDialog divider spans full width and resolve #161490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Ensure CupertinoAlertDialog divider spans full width and resolve #161490
Conversation
…s divider color (flutter#158522) The `_Divider` in CupertinoAlertDialog did not span the full width and the `dividerColor` was not resolved correctly. This fix uses a `SizedBox` with `double.infinity` as the width for the divider and ensures that the `dividerColor` is properly applied. Fixes flutter#158522
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hey @dev-lup, thanks for the contribution! There are some failing checks here, can you take a look? |
|
This will also need a test, and a signed CLA, please see the bot comments above. |
|
hi @Piinks , I signed the CLA, will write the test and let you know, thanks for reply |
|
hi @Piinks, I pushed test as well, I checked the failing tests but could not able to understand them, please check if you can guide me through. |
|
The customer test failure should have nothing to do with your PR and updating to the latest main should likely solve it. There are some format issues. Can you run the autoformatter? https://docs.flutter.dev/tools/formatting |
dkwingsmt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for investigating!
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
looks like there are some format error, can you run formatter on the code? or just turn on auto format |
|
on running auto format it changes more then my code. |
|
Can you check out the "Linux analyse" details and check out the errors? |
|
something like this is failing, can you tell me what may went wrong. |
|
If you click into the details you should see the following: (I've copied it out for you) |
|
thanks for helping me, but on running dart format packages/flutter/test/cupertino/dialog_test.dart packages/flutter/lib/src/cupertino/dialog.dart its changing more code then I am expecting. I am attaching git diff for you to check. |
|
Sorry, I'm not sure either. Haven't used the autoformatter much since the autoformating change. Can you manually edit the files or pick the files from the git changes? |
|
I can try formatting the code according to the formatter. Thanks |
1c9044d to
3a8a97f
Compare
Fix: Ensure CupertinoAlertDialog divider spans full width and resolves divider color (#158522)
The
_Dividerin CupertinoAlertDialog did not span the full width and thedividerColorwas not resolved correctly. This fix uses aSizedBoxwithdouble.infinityas the width for the divider and ensures that thedividerColoris properly applied.Fixes #158522
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.