Remove the word normalized, remove minimum/maximum. #161106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
reviewed
Jan 3, 2025
| : this._fromARGBC(value >> 24, value >> 16, value >> 8, value, ColorSpace.sRGB); | ||
|
|
||
| /// Construct a color with normalized color components from `0.0` to `1.0`. | ||
| /// Construct a color with color components with a minimum value of `0.0`. |
Member
There was a problem hiding this comment.
You can't say minimum value of 0.0 either, the numbers go negative in extended SRGB.
| /// components to be be supported. The values will be normalized relative to | ||
| /// the [ColorSpace] argument. | ||
| /// Color components allows arbitrary bit depths for color components to be be | ||
| /// supported. The values are interpted relative to the [ColorSpace] argument. |
Member
There was a problem hiding this comment.
Suggested change
| /// supported. The values are interpted relative to the [ColorSpace] argument. | |
| /// supported. The values are interpreted relative to the [ColorSpace] argument. |
| /// | ||
| /// A value of `0.0` represents no red in this color. A value of `1.0` | ||
| /// represents the maximum amount of red. | ||
| /// A value of `0.0` represents no red in this color. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2025
guidezpl
reviewed
Jan 14, 2025
| /// | ||
| /// A value of `0.0` means this color is fully transparent. A value of `1.0` | ||
| /// means this color is fully opaque. | ||
| /// The alpha channel of this color. |
Member
There was a problem hiding this comment.
I think it was more clear before, if incorrect. I think we should provide some guidance on what each of a, r, and g mean and what are their bounds. Maybe something like:
For example, in the sRGB color space, where 0 is the maximum value and 255 is the minimum, a would be a value between 0 and 1.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-submit feedback from #160798 (review).