Skip to content

update repo to be forward compatible with shelf_web_socket v3.0#161101

Merged
devoncarew merged 2 commits into
flutter:masterfrom
devoncarew:update_shelf_web_socket
Jan 6, 2025
Merged

update repo to be forward compatible with shelf_web_socket v3.0#161101
devoncarew merged 2 commits into
flutter:masterfrom
devoncarew:update_shelf_web_socket

Conversation

@devoncarew

@devoncarew devoncarew commented Jan 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • update the engine and flutter_tools to be forward compatible with the upcoming shelf_web_socket v3.0

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

flutter-dashboard Bot commented Jan 3, 2025

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. engine flutter/engine related. See also e: labels. labels Jan 3, 2025
@devoncarew devoncarew added this pull request to the merge queue Jan 6, 2025
Merged via the queue into flutter:master with commit f00de04 Jan 6, 2025
@devoncarew devoncarew deleted the update_shelf_web_socket branch January 6, 2025 20:45
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
3daca79 
….0 (flutter/flutter#161101)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
647052f 
….0 (flutter/flutter#161101)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
af12201 
….0 (flutter/flutter#161101)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
64ace78 
….0 (flutter/flutter#161101)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
e111a56 
….0 (flutter/flutter#161101)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
34afd7d 
….0 (flutter/flutter#161101)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
3639fc9 
….0 (flutter/flutter#161101)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
e53bfa3 
….0 (flutter/flutter#161101)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
affeb0c 
….0 (flutter/flutter#161101)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
f799c04 
….0 (flutter/flutter#161101)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
05e5c86 
….0 (flutter/flutter#161101)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
fffa853 
….0 (flutter/flutter#161101)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
749c4bf 
….0 (flutter/flutter#161101)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
ac3f00c 
….0 (flutter/flutter#161101)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
78176b9 
….0 (flutter/flutter#161101)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
2b09c0a 
….0 (flutter/flutter#161101)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
f00de04 update repo to be forward compatible with shelf_web_socket v3…
eac5e5b 
….0 (flutter/flutter#161101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@matanlurey matanlurey matanlurey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devoncarew @matanlurey