Only bundle assets and plugins from transitive closure of dependencies #160443

sigurdm · 2024-12-17T15:25:04Z

Fixes dart-lang/pub#4486
Fixes dart-lang/pub#4473
Fixes #79261
Fixes #160142
Fixes #155242

Use the new .dart_tool/package_graph.json file to compute the dependency graph. Determining

which are transitive dependencies of the main app's direct and dev-dependencies, (not other packages from the workspace)
which of these are only in the transitive set of the direct dependencies

Bundles assets from dev_dependencies when running flutter test, but not otherwise.

sigurdm · 2025-01-10T16:33:03Z

I think all local tests are passing now. (perhaps we should refactor some tests, so package_config.json doesn't have to be created uniquely for so many tests....)

Not sure what happens in the customer tests, but I think it might be unrelated to this change.

bkonyi

Initial quick review. Wil give this another pass later.

packages/flutter_tools/lib/src/asset.dart

packages/flutter_tools/lib/src/compute_dev_dependencies.dart

packages/flutter_tools/lib/src/flutter_manifest.dart

packages/flutter_tools/lib/src/plugins.dart

packages/flutter_tools/lib/src/asset.dart

packages/flutter_tools/lib/src/compute_dev_dependencies.dart

packages/flutter_tools/lib/src/flutter_plugins.dart

sigurdm · 2025-01-21T09:58:46Z

Gentle ping on this one

gabrielgarciagava · 2025-01-22T08:37:26Z

@spydon I know you are one of the melos maintainers. I would suggest you to keep track of this pull request. I would say this is a blocker to release the workspaces support to melos.

spydon · 2025-01-22T08:46:31Z

@spydon I know you are one of the melos maintainers. I would suggest you to keep track of this pull request. I would say this is a blocker to release the workspaces support to melos.

Thanks, I'm already subscribed to it. I've created one of the issues above. :)

andrewkolos

LGTM with nits

packages/flutter_tools/lib/src/compute_dev_dependencies.dart

packages/flutter_tools/test/general.shard/web/compile_web_test.dart

packages/flutter_tools/test/general.shard/compute_dev_dependencies_test.dart

sigurdm · 2025-01-24T13:41:53Z

Do you think you could help me out with the customer_testing tests?

I cannot understand how my change could cause errors like:

 00:11 +8: /b/s/w/ir/x/t/flutter_customer_testing.super_editor.UDMNRS/tests/super_text_layout/test/super_text_test.dart: SuperText RenderSuperTextLayout calculates line count for one line of text
| ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
| The following TestFailure was thrown running a test:
| Expected: <1>
|   Actual: <2>
|
| When the exception was thrown, this was the stack:
| #4      main.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (file:///b/s/w/ir/x/t/flutter_customer_testing.super_editor.UDMNRS/tests/super_text_layout/test/super_text_test.dart:203:11)
| <asynchronous suspension>
| #5      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:193:15)
| <asynchronous suspension>
| #6      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1064:5)
| <asynchronous suspension>
| <asynchronous suspension>
| (elided one frame from package:stack_trace)

But also I don't want to land this with red tests I don't understand...

andrewkolos · 2025-01-27T05:20:01Z

From what I can tell, the tests depend on the Roboto font being available (src). Before, it was getting bundled from the golden_toolkit package.

To verify yourself, clone the super_editor repo and navigate to the failing test (https://github.com/superlistapp/super_editor/blob/dc7013f2f9be145d655e891eb2502baf2d6795a1/super_text_layout/test/super_text_test.dart#L192). To see what assets are getting bundled within the test code, add

final assets = (await AssetManifest.loadFromAssetBundle(rootBundle))
  .listAssets();
print(assets.join('\n'));

When on master, I see

packages/golden_toolkit/fonts/Roboto-Regular.ttf

which I don't see when I have this PR checked out.

sigurdm · 2025-01-28T11:04:16Z

I understand now, thanks!

The super_text_layout package dev_depends on golden_toolkit which has the font as an asset. This PR does not allow you to use assets from your dev_dependencies.

So in general when testing, you might want to use assets from your dev_dependencies, but not when building for deployment I had not really realized that.

I see three ways forward:

We teach flutter_tool to bundle different assets when testing?
I wonder if this is realistic? Not sure exactly what this would require. @andrewkolos @bkonyi
We could also revert that part of this PR, so that you still bundle all assets from dev_dependencies (would no longer solve package assets declared under dev_dependency shouldn't be included in release bundle #79261)
We could also require all assets to come from dependencies, and update the customer test to have golden_toolkit in its dependencies

andrewkolos · 2025-01-28T18:35:13Z

So in general when testing, you might want to use assets from your dev_dependencies, but not when building for deployment I had not really realized that.

Yeah, I was thinking the same. There are probably edge cases where including a font from a dev dependency would unexpectedly cause a test to pass (i.e. the font was meant to be included from a regular dependency or the assets section in your pubspec); but I expect such a case would be extremely rare. That is to say, I think it is fine to continue to include assets from dev dependencies in tests—at least for now.

bkonyi · 2025-01-30T16:14:55Z

I think including assets from dev dependencies in tests is fine since I assume our main concern here is reducing bundle size in shipped applications.

packages/flutter_tools/lib/src/asset.dart

packages/flutter_tools/lib/src/compute_dev_dependencies.dart

sigurdm · 2025-01-31T09:30:08Z

Attached g3fix https://critique.corp.google.com/cl/721374511

bkonyi · 2025-01-31T15:24:30Z

Thanks for addressing the comments! LGTM!

sigurdm · 2025-02-03T12:47:43Z

Seems #161826 and #161343 are interferring with this.

@camsim99 do you know the desired semantics around plugins and assets from dev-dependencies? Should they be included in debug builds but not in release? Or should they be included for testing only (or not at all)?

camsim99 · 2025-02-03T22:41:27Z

Seems #161826 and #161343 are interferring with this.

@camsim99 do you know the desired semantics around plugins and assets from dev-dependencies? Should they be included in debug builds but not in release? Or should they be included for testing only (or not at all)?

My understanding is that we are working towards what I think #79261 proposes, i.e. assets from dev dependencies should be included in debug builds but not release. The changes I made are irrespective to testing I think. cc @matanlurey for input

matanlurey

So the reason this failing is because the feature that @camsim99 and I implemented, which is, to omit plugins specified in dev_dependencies from release mode apps, looks like was broken as a result of the refactoring in this PR.

I can try cloning it locally and debug a bit tomorrow morning if you are still stuck, but as a starting point:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8723951633781029105/+/u/run_test.dart_for_tool_tests_shard_and_subshard_general/stdout "plugins injectPlugins in release mode excludes dev dependencies from MacOS plugin registrant"
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8723951633490693953/+/u/run_android_release_builds_exclude_dev_dependencies_test/stdout "android_release_builds_exclude_dev_dependencies_test"

Not directly related: It's nice that this code was refactored to be synchronous and read the file system instead of shelling out to pub deps, but this was a large refactoring and in the future I should be included as a PR reviewer as someone who has to also maintain and understand these changes.

matanlurey

Had a chance to do a longer review. Still needs more work, and I still think it makes sense to break this up into 2+ PRs.

packages/flutter_tools/lib/src/asset.dart

packages/flutter_tools/lib/src/compute_dev_dependencies.dart

packages/flutter_tools/test/general.shard/compute_dev_dependencies_test.dart

packages/flutter_tools/test/general.shard/plugins_test.dart

…endencies (flutter/flutter#160443)

…ependencies (flutter/flutter#160443)

…endencies (flutter/flutter#160443)

Roll Flutter from 9a78af5 to 33cdd8e (60 revisions) flutter/flutter@9a78af5...33cdd8e 2025-05-21 34465683+rkishan516@users.noreply.github.com Feat: Add persistentFooterDecoration for scaffold (flutter/flutter#167524) 2025-05-21 34270884+ferraridamiano@users.noreply.github.com Removed repeated entry in `CHANGELOG.md` (flutter/flutter#165273) 2025-05-21 dacoharkes@google.com [native assets] Graduate to preview (flutter/flutter#169194) 2025-05-21 jonahwilliams@google.com [Impeller] disable gl ext render to texture on vivante. (flutter/flutter#169153) 2025-05-21 mu7ammadkamel@hotmail.com fix(widget_inspector): add null check for flex factor property to prevent exception (flutter/flutter#167890) 2025-05-21 polinach@google.com Unpin leak_tracker. (flutter/flutter#169079) 2025-05-21 69134234+sutes-work@users.noreply.github.com runtime/dart: fuchsia::io::MODE_TYPE_FILE -> V_TYPE_FILE (flutter/flutter#168952) 2025-05-21 matanlurey@users.noreply.github.com Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter/flutter#169156) 2025-05-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#169181) 2025-05-20 ybz975218925@gmail.com Fix the issue with Tooltip (flutter/flutter#168546) 2025-05-20 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#169073) 2025-05-20 matanlurey@users.noreply.github.com Add documentation for experimental branches, update artifacts. (flutter/flutter#169109) 2025-05-20 kevmoo@users.noreply.github.com [flutter_tool] Remove unused environment flags in JS compiler (flutter/flutter#169097) 2025-05-20 bkonyi@google.com Add support for hiding widget subtrees from the widget inspector (flutter/flutter#169007) 2025-05-20 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from jsZSHIOmQAs3URvWU... to _tkqOQZ2qB5CxDe57... (flutter/flutter#169113) 2025-05-20 matanlurey@users.noreply.github.com Skip running `Linux fuchsia_test` on non-master channel. (flutter/flutter#169106) 2025-05-19 engine-flutter-autoroll@skia.org Roll Skia from c97451da059f to 13a299964c9f (61 revisions) (flutter/flutter#169099) 2025-05-19 maRci002@users.noreply.github.com Shared element transition for predictive back (flutter/flutter#154718) 2025-05-19 58529443+srujzs@users.noreply.github.com Fix DDC library bundle format test files to correctly pass flags (flutter/flutter#169095) 2025-05-19 8847263+littleGnAl@users.noreply.github.com Clean up redundant new line in the GPUSurfaceGLSkia constructor initializer list (flutter/flutter#169031) 2025-05-19 737941+loic-sharma@users.noreply.github.com Fix keyboard_hot_restart_ios flakes (flutter/flutter#168518) 2025-05-19 mohellebiabdessalem@gmail.com fix android studio lint about lambda argument (flutter/flutter#168901) 2025-05-19 8847263+littleGnAl@users.noreply.github.com Fix typo in gpu_surface_gl_impeller.cc (flutter/flutter#168395) 2025-05-19 emmanuelferdman@gmail.com Modernize system executable detection across components (flutter/flutter#169018) 2025-05-19 56335976+stuuupidcat@users.noreply.github.com Update documentation for `Size` and `Rect` classes (flutter/flutter#168031) 2025-05-19 48603081+TahaTesser@users.noreply.github.com Update the `RangeSlider` widget to the 2024 Material Design appearance (flutter/flutter#163736) 2025-05-19 engine-flutter-autoroll@skia.org Roll Packages from 58d4016 to af0b9a9 (5 revisions) (flutter/flutter#169075) 2025-05-19 sigurdm@google.com Only bundle assets and plugins from transitive closure of dependencies (flutter/flutter#160443) 2025-05-19 15619084+vashworth@users.noreply.github.com Make FlutterGeneratedPluginSwiftPackage an Xcode root package (flutter/flutter#168789) 2025-05-19 huy@nevercode.io docs: Update deprecation message for Slider.year2023 (flutter/flutter#169053) 2025-05-18 chris@bracken.jp macOS: port ResizeSynchronizer to Swift (flutter/flutter#168959) 2025-05-17 engine-flutter-autoroll@skia.org Roll Dart SDK from dc323ec0c1a3 to 7c40eba6bf77 (3 revisions) (flutter/flutter#169024) 2025-05-17 parlough@gmail.com [tool] Remove unused `reportNullSafety` getter (flutter/flutter#168484) 2025-05-17 jsimionato@google.com Add flag to skip bundling extension safe builds in frameworks for DDM (flutter/flutter#168955) 2025-05-16 47866232+chunhtai@users.noreply.github.com Fixes Navigator calls onPopInvokedWithResult when onPopPage return false (flutter/flutter#168567) 2025-05-16 34871572+gmackall@users.noreply.github.com [hcpp/hc] Fix talkback for HC and HCPP Android platform views (flutter/flutter#168939) 2025-05-16 jonahwilliams@google.com [Impeller] separate immutable sampler descriptors. (flutter/flutter#169011) 2025-05-16 51901607+O-Hannonen@users.noreply.github.com TextField magnifier stuck on long press cancel (flutter/flutter#167881) 2025-05-16 bruno.leroux@gmail.com Fix Chip delete button semantic bounds (flutter/flutter#168310) 2025-05-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Jj-iDG5uPOsFgY2_H... to XtPp9bBW49iDJ0wbA... (flutter/flutter#169009) 2025-05-16 bkonyi@google.com [ Widget Preview ] Refactor `@Preview()` detection and code generation (flutter/flutter#168307) 2025-05-16 engine-flutter-autoroll@skia.org Roll Packages from 2dff621 to 58d4016 (2 revisions) (flutter/flutter#168999) 2025-05-16 matanlurey@users.noreply.github.com Remove `unittests` from `windows_host_engine` GN targets. (flutter/flutter#168991) 2025-05-16 jessy.yameogo@gmail.com Fix bug with debugging support code not getting injected on edge devices (flutter/flutter#168073) 2025-05-16 engine-flutter-autoroll@skia.org Roll Dart SDK from a1db62a5dd14 to dc323ec0c1a3 (4 revisions) (flutter/flutter#168989) 2025-05-16 58190796+MitchellGoodwin@users.noreply.github.com Resolve Cupertino textstyle in MaterialBasedCupertinoThemeData (flutter/flutter#167597) ...

gabrielgarciagava · 2025-05-23T08:33:56Z

@sigurdm I suppose this PR could not land on the current flutter stable release, right?
Do you have any idea if this is going to be cherry-picked to the current stable version or will we need to wait for the next stable release? :')

Roll Flutter from 9a78af5 to 33cdd8e (60 revisions) flutter/flutter@9a78af5...33cdd8e 2025-05-21 34465683+rkishan516@users.noreply.github.com Feat: Add persistentFooterDecoration for scaffold (flutter/flutter#167524) 2025-05-21 34270884+ferraridamiano@users.noreply.github.com Removed repeated entry in `CHANGELOG.md` (flutter/flutter#165273) 2025-05-21 dacoharkes@google.com [native assets] Graduate to preview (flutter/flutter#169194) 2025-05-21 jonahwilliams@google.com [Impeller] disable gl ext render to texture on vivante. (flutter/flutter#169153) 2025-05-21 mu7ammadkamel@hotmail.com fix(widget_inspector): add null check for flex factor property to prevent exception (flutter/flutter#167890) 2025-05-21 polinach@google.com Unpin leak_tracker. (flutter/flutter#169079) 2025-05-21 69134234+sutes-work@users.noreply.github.com runtime/dart: fuchsia::io::MODE_TYPE_FILE -> V_TYPE_FILE (flutter/flutter#168952) 2025-05-21 matanlurey@users.noreply.github.com Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter/flutter#169156) 2025-05-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#169181) 2025-05-20 ybz975218925@gmail.com Fix the issue with Tooltip (flutter/flutter#168546) 2025-05-20 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#169073) 2025-05-20 matanlurey@users.noreply.github.com Add documentation for experimental branches, update artifacts. (flutter/flutter#169109) 2025-05-20 kevmoo@users.noreply.github.com [flutter_tool] Remove unused environment flags in JS compiler (flutter/flutter#169097) 2025-05-20 bkonyi@google.com Add support for hiding widget subtrees from the widget inspector (flutter/flutter#169007) 2025-05-20 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from jsZSHIOmQAs3URvWU... to _tkqOQZ2qB5CxDe57... (flutter/flutter#169113) 2025-05-20 matanlurey@users.noreply.github.com Skip running `Linux fuchsia_test` on non-master channel. (flutter/flutter#169106) 2025-05-19 engine-flutter-autoroll@skia.org Roll Skia from c97451da059f to 13a299964c9f (61 revisions) (flutter/flutter#169099) 2025-05-19 maRci002@users.noreply.github.com Shared element transition for predictive back (flutter/flutter#154718) 2025-05-19 58529443+srujzs@users.noreply.github.com Fix DDC library bundle format test files to correctly pass flags (flutter/flutter#169095) 2025-05-19 8847263+littleGnAl@users.noreply.github.com Clean up redundant new line in the GPUSurfaceGLSkia constructor initializer list (flutter/flutter#169031) 2025-05-19 737941+loic-sharma@users.noreply.github.com Fix keyboard_hot_restart_ios flakes (flutter/flutter#168518) 2025-05-19 mohellebiabdessalem@gmail.com fix android studio lint about lambda argument (flutter/flutter#168901) 2025-05-19 8847263+littleGnAl@users.noreply.github.com Fix typo in gpu_surface_gl_impeller.cc (flutter/flutter#168395) 2025-05-19 emmanuelferdman@gmail.com Modernize system executable detection across components (flutter/flutter#169018) 2025-05-19 56335976+stuuupidcat@users.noreply.github.com Update documentation for `Size` and `Rect` classes (flutter/flutter#168031) 2025-05-19 48603081+TahaTesser@users.noreply.github.com Update the `RangeSlider` widget to the 2024 Material Design appearance (flutter/flutter#163736) 2025-05-19 engine-flutter-autoroll@skia.org Roll Packages from 58d4016 to af0b9a9 (5 revisions) (flutter/flutter#169075) 2025-05-19 sigurdm@google.com Only bundle assets and plugins from transitive closure of dependencies (flutter/flutter#160443) 2025-05-19 15619084+vashworth@users.noreply.github.com Make FlutterGeneratedPluginSwiftPackage an Xcode root package (flutter/flutter#168789) 2025-05-19 huy@nevercode.io docs: Update deprecation message for Slider.year2023 (flutter/flutter#169053) 2025-05-18 chris@bracken.jp macOS: port ResizeSynchronizer to Swift (flutter/flutter#168959) 2025-05-17 engine-flutter-autoroll@skia.org Roll Dart SDK from dc323ec0c1a3 to 7c40eba6bf77 (3 revisions) (flutter/flutter#169024) 2025-05-17 parlough@gmail.com [tool] Remove unused `reportNullSafety` getter (flutter/flutter#168484) 2025-05-17 jsimionato@google.com Add flag to skip bundling extension safe builds in frameworks for DDM (flutter/flutter#168955) 2025-05-16 47866232+chunhtai@users.noreply.github.com Fixes Navigator calls onPopInvokedWithResult when onPopPage return false (flutter/flutter#168567) 2025-05-16 34871572+gmackall@users.noreply.github.com [hcpp/hc] Fix talkback for HC and HCPP Android platform views (flutter/flutter#168939) 2025-05-16 jonahwilliams@google.com [Impeller] separate immutable sampler descriptors. (flutter/flutter#169011) 2025-05-16 51901607+O-Hannonen@users.noreply.github.com TextField magnifier stuck on long press cancel (flutter/flutter#167881) 2025-05-16 bruno.leroux@gmail.com Fix Chip delete button semantic bounds (flutter/flutter#168310) 2025-05-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Jj-iDG5uPOsFgY2_H... to XtPp9bBW49iDJ0wbA... (flutter/flutter#169009) 2025-05-16 bkonyi@google.com [ Widget Preview ] Refactor `@Preview()` detection and code generation (flutter/flutter#168307) 2025-05-16 engine-flutter-autoroll@skia.org Roll Packages from 2dff621 to 58d4016 (2 revisions) (flutter/flutter#168999) 2025-05-16 matanlurey@users.noreply.github.com Remove `unittests` from `windows_host_engine` GN targets. (flutter/flutter#168991) 2025-05-16 jessy.yameogo@gmail.com Fix bug with debugging support code not getting injected on edge devices (flutter/flutter#168073) 2025-05-16 engine-flutter-autoroll@skia.org Roll Dart SDK from a1db62a5dd14 to dc323ec0c1a3 (4 revisions) (flutter/flutter#168989) 2025-05-16 58190796+MitchellGoodwin@users.noreply.github.com Resolve Cupertino textstyle in MaterialBasedCupertinoThemeData (flutter/flutter#167597) ...

davidnwaneri · 2025-07-10T09:03:23Z

When will it be possible to have this fix on stable

spydon · 2025-07-10T09:08:07Z

When will it be possible to have this fix on stable

Since it's in beta now I would guess that it will land in stable around the end of August.

…endencies (flutter/flutter#160443)

flutter/flutter#160443

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 17, 2024

sigurdm mentioned this pull request Dec 17, 2024

pub workspace mixes plugins between projects #155242

Closed

bkonyi requested review from andrewkolos and bkonyi December 19, 2024 21:28

sigurdm force-pushed the only_bundle_assets_from_dependencies branch from 1024789 to 95ce951 Compare December 20, 2024 09:15

sigurdm changed the title ~~Only bundle assets from transitive closure of dependencies~~ Only bundle assets and plugins from transitive closure of dependencies Dec 20, 2024

github-actions bot added the a: desktop Running on desktop label Jan 9, 2025

sigurdm mentioned this pull request Jan 10, 2025

Don't force uses-material-design: true for root pubspec dart-lang/pub#4486

Closed

bkonyi reviewed Jan 13, 2025

View reviewed changes

sigurdm requested a review from bkonyi January 14, 2025 13:07

andrewkolos approved these changes Jan 23, 2025

View reviewed changes

bkonyi approved these changes Jan 30, 2025

View reviewed changes

packages/flutter_tools/lib/src/asset.dart Outdated Show resolved Hide resolved

packages/flutter_tools/lib/src/compute_dev_dependencies.dart Outdated Show resolved Hide resolved

xvrh mentioned this pull request Jan 31, 2025

dependency issues with new dart workspace #162451

Closed

spydon mentioned this pull request Feb 3, 2025

request: pub workspaces invertase/melos#747

Closed

1 task

matanlurey requested changes Feb 4, 2025

View reviewed changes

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

b23840d Only bundle assets and plugins from transitive closure of dep…

9ba4fdc

…endencies (flutter/flutter#160443)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to 534b250a562c (58 revisions) flutter/packages#9303

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

b23840d04 Only bundle assets and plugins from transitive closure of d…

a170018

…ependencies (flutter/flutter#160443)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to f7354da75b27 (59 revisions) flutter/packages#9304

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

b23840d Only bundle assets and plugins from transitive closure of dep…

a19e55b

…endencies (flutter/flutter#160443)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to 33cdd8ef31dc (60 revisions) flutter/packages#9305

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

b23840d Only bundle assets and plugins from transitive closure of dep…

1e76fbf

…endencies (flutter/flutter#160443)

Piinks mentioned this pull request May 23, 2025

Flutter Notable Commits - 2025 #161460

Open

matanlurey mentioned this pull request Jun 3, 2025

Multiple apps in a dart workspace project will get each others assets #169956

Closed

felangel mentioned this pull request Jun 10, 2025

[feat] Generate per-package pubspec.lock in workspaces dart-lang/pub#4594

Open

spydon mentioned this pull request Jul 10, 2025

How to make melos run the command from the root of the workspace? invertase/melos#918

Closed

darshankawar mentioned this pull request Jul 29, 2025

Dart Workspaces: Transitive dependencies leak across apps causing unintended permissions and native code inclusion #172845

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

b23840d Only bundle assets and plugins from transitive closure of dep…

dbc4291

…endencies (flutter/flutter#160443)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

b23840d Only bundle assets and plugins from transitive closure of dep…

e4deb65

…endencies (flutter/flutter#160443)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

b23840d Only bundle assets and plugins from transitive closure of dep…

26fa38a

…endencies (flutter/flutter#160443)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

b23840d Only bundle assets and plugins from transitive closure of dep…

4f8b4c0

…endencies (flutter/flutter#160443)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

b23840d Only bundle assets and plugins from transitive closure of dep…

d8e5e69

…endencies (flutter/flutter#160443)

crasowas mentioned this pull request Aug 19, 2025

MissingPluginException when using pub workspace #173842

Closed

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Sep 9, 2025

Remote deps() in Pub

943bcd1

flutter/flutter#160443

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Sep 11, 2025

Remove FakePubWithPrimedDeps

3a6b44d

flutter/flutter#160443

emakar mentioned this pull request Sep 12, 2025

Patrol is built into a release app, even when it is a dev_dependency leancodepl/patrol#681

Open

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Sep 19, 2025

Remote deps() in Pub

24d5113

flutter/flutter#160443

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Sep 19, 2025

Remove FakePubWithPrimedDeps

52b13da

flutter/flutter#160443

sigurdm mentioned this pull request Oct 9, 2025

Support --no-pub flag on pub remove (and potentially other subcommands) dart-lang/pub#4681

Open

Only bundle assets and plugins from transitive closure of dependencies #160443

Only bundle assets and plugins from transitive closure of dependencies #160443

Uh oh!

Conversation

sigurdm commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sigurdm commented Jan 10, 2025

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sigurdm commented Jan 21, 2025

Uh oh!

gabrielgarciagava commented Jan 22, 2025

Uh oh!

spydon commented Jan 22, 2025

Uh oh!

andrewkolos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sigurdm commented Jan 24, 2025

Uh oh!

andrewkolos commented Jan 27, 2025

Uh oh!

sigurdm commented Jan 28, 2025

Uh oh!

andrewkolos commented Jan 28, 2025

Uh oh!

bkonyi commented Jan 30, 2025

Uh oh!

Uh oh!

Uh oh!

sigurdm commented Jan 31, 2025

Uh oh!

bkonyi commented Jan 31, 2025

Uh oh!

sigurdm commented Feb 3, 2025

Uh oh!

camsim99 commented Feb 3, 2025

Uh oh!

matanlurey left a comment

Choose a reason for hiding this comment

Uh oh!

matanlurey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gabrielgarciagava commented May 23, 2025

Uh oh!

davidnwaneri commented Jul 10, 2025

Uh oh!

spydon commented Jul 10, 2025

Uh oh!

Reviewers

sigurdm commented Dec 17, 2024 •

edited

Loading