Skip to content

CupertinoTextField accessibility behavior on Linux should match TextField #159823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Dec 10, 2024
Merged

CupertinoTextField accessibility behavior on Linux should match TextField #159823

auto-submit merged 1 commit into from
Dec 10, 2024

Conversation

@Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented Dec 5, 2024

While going through TextField and CupertinoTextField I noticed #94898 and #129652 did not make it over to CupertinoTextField. This PR brings over those changes to CupertinoTextField. On Linux after this change the CupertinoTextField now focuses when gaining a11y focus, and unfocuses when losing a11y focus.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Dec 5, 2024
@Renzo-Olivares Renzo-Olivares changed the title CupertinoTextField accessibility behavior should match TextField on Linux CupertinoTextField accessibility behavior on Linux should match TextField Dec 5, 2024
justinmc
justinmc approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

Do you think it would be possible to define this Semantics stuff at the EditableText level so it's not duplicated across TextField and CupertinoTextField? That's the real core of the problem here. Not for this PR but I'm just curious for the future.

@Renzo-Olivares
Copy link
Contributor Author

Renzo-Olivares commented Dec 10, 2024

I think that's a great idea! I had that same thought when catching this. I'll try to investigate how possible that is, and also see what else we can move down to EditableText safely so we can avoid this problem of applying changes to both styled TextFields as much as possible.

@Renzo-Olivares Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 10, 2024
@auto-submit auto-submit bot added this pull request to the merge queue Dec 10, 2024
Merged via the queue into flutter:master with commit 119f170 Dec 10, 2024
79 of 80 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 10, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
119f170 CupertinoTextField accessibility behavior on Linux should m…
b87ab7f 
…atch `TextField` (flutter/flutter#159823)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
119f170 CupertinoTextField accessibility behavior on Linux should m…
d7f9fa9 
…atch `TextField` (flutter/flutter#159823)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
119f170 CupertinoTextField accessibility behavior on Linux should m…
4284333 
…atch `TextField` (flutter/flutter#159823)
@reidbaker reidbaker mentioned this pull request Dec 13, 2024
Closed
11 tasks
@Piinks Piinks mentioned this pull request Dec 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
119f170 CupertinoTextField accessibility behavior on Linux should m…
af48d89 
…atch `TextField` (flutter/flutter#159823)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
119f170 CupertinoTextField accessibility behavior on Linux should m…
18adafa 
…atch `TextField` (flutter/flutter#159823)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
119f170 CupertinoTextField accessibility behavior on Linux should m…
7c86a41 
…atch `TextField` (flutter/flutter#159823)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
119f170 CupertinoTextField accessibility behavior on Linux should m…
1cb6f15 
…atch `TextField` (flutter/flutter#159823)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
119f170 CupertinoTextField accessibility behavior on Linux should m…
f9ce552 
…atch `TextField` (flutter/flutter#159823)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Renzo-Olivares @justinmc