Make sure flutter update-packages --verify-only has a non-zero exit code
#15962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This appears to have broken Travis and Appveyor at head. |
Contributor
|
Reverted |
Contributor
Author
|
I continue to be reminded that travis is not tap 🥇 |
Member
|
Not having TAP is the best (possibly only) way to truly appreciate the miracle of TAP. |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
… code (flutter#15962) * make sure --verify-only logs error messages and fix typo * ensure non zero exit code * undo random pubspec change
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
…ero exit code (flutter#15962)" (flutter#16089) This reverts commit cfda7a6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes typo in message. Required to make analysis fail for flutter build