Cleanup MenuAnchor and Improve DropdownMenu tests readability #158175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmc
approved these changes
Nov 5, 2024
Comment on lines
-447
to
+446
| child: | ||
| _MenuAnchorScope( | ||
| child: _MenuAnchorScope( |
Contributor
There was a problem hiding this comment.
I don't know how this weird formatting got everywhere but thanks for fixing it!
Contributor
|
auto label is removed for flutter/flutter/158175, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 6, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 6, 2024
flutter/flutter@29d40f7...73546b3 2024-11-06 32538273+ValentinVignal@users.noreply.github.com Add test for `image.loading_builder.0.dart` (flutter/flutter#158248) 2024-11-06 kustermann@google.com Make flutter_tools use newest package:{native_assets_builder,native_assets_cli,native_toolchain_c} (flutter/flutter#158214) 2024-11-06 bruno.leroux@gmail.com Fix RawScrollbar examples and desktop test (flutter/flutter#158237) 2024-11-06 bruno.leroux@gmail.com Cleanup MenuAnchor and Improve DropdownMenu tests readability (flutter/flutter#158175) 2024-11-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from a3741d6248b7 to f03f11300a9d (2 revisions) (flutter/flutter#158222) 2024-11-06 louisehsu@google.com Update error message for Cocoapods support for synchronized groups/folders (flutter/flutter#158206) 2024-11-06 matanlurey@users.noreply.github.com Restore skipped iOS test by looping over `FakeAsync` elapse. (flutter/flutter#158204) 2024-11-06 41366638+kirya355@users.noreply.github.com fix: ensure draggable_scrollable_sheet respects shouldCloseOnMinExten� (flutter/flutter#156338) 2024-11-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from e5e06c97c33c to a3741d6248b7 (14 revisions) (flutter/flutter#158218) 2024-11-06 matanlurey@users.noreply.github.com Forward fix `CupertinoDynamicColor` by adding `toARGB32()`. (flutter/flutter#158145) 2024-11-05 matanlurey@users.noreply.github.com Remove unused `enableObservatory` flag. (flutter/flutter#158202) 2024-11-05 matanlurey@users.noreply.github.com Remove observatory related TODO that is already fixed. (flutter/flutter#158205) 2024-11-05 nate.w5687@gmail.com Factor out "shaker" class (flutter/flutter#157748) 2024-11-05 fluttergithubbot@gmail.com Marks Mac_benchmark animated_complex_opacity_perf_macos__e2e_summary to be flaky (flutter/flutter#157424) 2024-11-05 andrewrkolos@gmail.com Increase subsharding for `Linux tool_integration_tests` (flutter/flutter#158196) 2024-11-05 32538273+ValentinVignal@users.noreply.github.com Add test for `raw_scrollbar.2.dart` (flutter/flutter#158161) 2024-11-05 andrewrkolos@gmail.com use root directory as the default for rootOverride in Cache.test constructor (flutter/flutter#158201) 2024-11-05 magder@google.com Kill interactive script job `xcdevice observe` processes on tool/daemon shutdown (flutter/flutter#157646) 2024-11-05 34465683+rkishan516@users.noreply.github.com Fix: Gap between prefix and suffix icon and input field in input deco� (flutter/flutter#152069) 2024-11-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from f56401062e42 to e5e06c97c33c (1 revision) (flutter/flutter#158194) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some typos on
MenuAnchorand improve the readability of aDropdownMenutest utility function.@justinmc I'm still considering creating a test utils file for DropdownMenu but there are few utilities and I'm worried that helper functions in utils file will cripple completion results (not a big deal because it is just for people working on the framework) but I think this should be used carefully. For instance the function
getButtonMaterialwould have to be renamed to something less generic if exposed more broadly (getMenuItemButtonMaterialfor instance).