[CP-beta]Prevent flutter build ios-framework --xcframework from copying Flutter.xcframework.dSYM into the App.framework folder.
#158131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tter.xcframework.dSYM` into the `App.framework` folder. (flutter#157394) Fixes flutter#157359 Prevents Flutter.xcframework.dSYM from being copied into the App.framework folder. I am not 100% positive if there are cases where it's valid to have multiple dSYMs in that folder, so I'm just string matching and filtering out `Flutter.xcframework.dSYM`
Author
|
@LouiseHsu please fill out the PR description above, afterwards the release team will review this request. |
Contributor
|
The cherry pick to stable is here #158125 |
5 tasks
jmagman
approved these changes
Nov 4, 2024
…e7c1c35327bfbf44a550d933
Contributor
|
@LouiseHsu this cherry-pick request has failing tests. |
…e7c1c35327bfbf44a550d933
Contributor
i think its getting blocked by this #158120 |
5 tasks
…e7c1c35327bfbf44a550d933
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…from copying `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#158131)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
…from copying `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#158131)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#157359
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
Prevents
flutter build ios-framework --xcframeworkfrom copying an extraneous Flutter.xcframework.dSYM into the App.framework folderImpact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
Previously,
flutter build ios-framework --xcframeworkwould fail witherror: Multiple commands produce '......./BuildProductsPath/Release-iphoneos/Flutter.framework.dSYM/Contents'.Is there a workaround for this issue?
The workaround is to delete
App.xcframework/ios-arm64/dSYMs/Flutter.framework.dSYM.Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Try to build any example app with
flutter build ios-framework --xcframework, then inspect the App.framework folder. It should only includeApp.framework.dSYM, and notFlutter.xcframework.dSYM