Add test for raw_scrollbar.1.dart
#158069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bleroux
approved these changes
Nov 3, 2024
Contributor
bleroux
left a comment
There was a problem hiding this comment.
LGTM! with a small suggestion
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
1461b4e to
a0d3e87
Compare
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
a0d3e87 to
bea5f99
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 4, 2024
flutter/flutter@f86b777...8591d0c 2024-11-04 32538273+ValentinVignal@users.noreply.github.com Remove null from flex documentation (flutter/flutter#158086) 2024-11-04 32538273+ValentinVignal@users.noreply.github.com Add test for `raw_scrollbar.1.dart` (flutter/flutter#158069) 2024-11-04 32538273+ValentinVignal@users.noreply.github.com Add test for `interactive_viewer.constrained.0.dart` (flutter/flutter#158044) 2024-11-03 polinach@google.com Revert "Add and plumb `useImplicitPubspecResolution` across `flutter_tools`." (flutter/flutter#158076) 2024-11-03 polinach@google.com Revert "Add a warning/additional handlers for parsing`synthetic-package`." (flutter/flutter#158078) 2024-11-03 jiten.pateljp2001@gmail.com Fixes typos & spelling error in changelog.md file (flutter/flutter#157438) 2024-11-02 32538273+ValentinVignal@users.noreply.github.com Add test for `raw_scrollbar.0.dart` (flutter/flutter#157989) 2024-11-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 38b6165f137d to 05cb5d7f7939 (4 revisions) (flutter/flutter#158038) 2024-11-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7dfdcacd8ae4 to 38b6165f137d (5 revisions) (flutter/flutter#158034) 2024-11-02 matanlurey@users.noreply.github.com Delete unused references to dev.flutter.plugins.e2e. (flutter/flutter#158031) 2024-11-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7b176f4f25da to 7dfdcacd8ae4 (1 revision) (flutter/flutter#158021) 2024-11-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3a090b46dd35 to 7b176f4f25da (2 revisions) (flutter/flutter#158018) 2024-11-01 737941+loic-sharma@users.noreply.github.com Make SwiftPM integration tests even MORE idiomatic (flutter/flutter#158014) 2024-11-01 737941+loic-sharma@users.noreply.github.com Improve consistency of code snippets in basic.dart (flutter/flutter#158015) 2024-11-01 matanlurey@users.noreply.github.com Remove unnecessary `kCliAnimationsFeatureName` that is available as `.configSetting`. (flutter/flutter#158013) 2024-11-01 737941+loic-sharma@users.noreply.github.com Make the SwiftPM integration tests more idiomatic (flutter/flutter#157971) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #130459
It adds a test for
examples/api/lib/widgets/scrollbar/raw_scrollbar.1.dartPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.