Add test for notification.0.dart
#157909
Merged
Add test for notification.0.dart
#157909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleroux
approved these changes
Oct 31, 2024
Contributor
bleroux
left a comment
There was a problem hiding this comment.
LGTM! Great work 👍
Some very minor nits
Comment on lines
47
to
48
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
Extra line
Comment on lines
73
to
74
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
Extra line
Comment on lines
96
to
97
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
Extra line
e85de23 to
aeed09c
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 1, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 1, 2024
flutter/flutter@0fe6153...f86b777 2024-11-01 engine-flutter-autoroll@skia.org Roll Packages from 7cc1caa to 796afa3 (15 revisions) (flutter/flutter#158003) 2024-11-01 fluttergithubbot@gmail.com Marks Linux_pixel_7pro service_extensions_test to be flaky (flutter/flutter#157853) 2024-11-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0a0d5c9be6ff to 3a090b46dd35 (1 revision) (flutter/flutter#157994) 2024-11-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from bacc5e1e73b7 to 0a0d5c9be6ff (3 revisions) (flutter/flutter#157991) 2024-11-01 32538273+ValentinVignal@users.noreply.github.com Add test for `interactive_viewer.transformation_controller.0.dart` (flutter/flutter#157986) 2024-11-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from d7e928911ac2 to bacc5e1e73b7 (1 revision) (flutter/flutter#157982) 2024-11-01 32538273+ValentinVignal@users.noreply.github.com Add test for `notification.0.dart` (flutter/flutter#157909) 2024-11-01 lammenspaolo@gmail.com performance: Override .elementAt in CachingIterable (flutter/flutter#152477) 2024-11-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from cd46383cd55e to d7e928911ac2 (4 revisions) (flutter/flutter#157978) 2024-11-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from bb77cf867aef to cd46383cd55e (11 revisions) (flutter/flutter#157972) 2024-11-01 matanlurey@users.noreply.github.com Add a warning/additional handlers for parsing`synthetic-package`. (flutter/flutter#157934) 2024-10-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from f2154ef3e31c to bb77cf867aef (6 revisions) (flutter/flutter#157960) 2024-10-31 matanlurey@users.noreply.github.com Renames `injectBuildTimePluginFilesForWebPlatform` and removes unused named parameter. (flutter/flutter#157944) 2024-10-31 jonahwilliams@google.com [flutter_driver] use mostly public screenshot API. (flutter/flutter#157888) 2024-10-31 sarbagyastha@gmail.com Made insetPadding configurable for Date Picker Dialog (flutter/flutter#155651) 2024-10-31 bruno.leroux@gmail.com Fix showSnackBar can't access useMaterial3 from the theme (flutter/flutter#157707) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #130459
It adds a test for
examples/api/lib/widgets/notification_listener/notification.0.dartPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.