-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Update CHANGELOG.md to correct ios vs macos issue #157822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@reidbaker perhaps the release process should be updated so the author or TL approver also made a reviewer on the CHANGELOG commit? |
We recently changed the process from release engineer authored changes to cherry pick requestor authored changes. I do think updating the changelog makes sense. The issue most will run into is that it will cause conflicts as each change is landed. |
Co-authored-by: Jenn Magder <magder@google.com>
jmagman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you!
I meant when release engineer sends out the changelog PR they could add the relevant authors as reviewers, or maybe only cc them would be sufficient to not slow down the release engineer. Just a thought, it's not that important. Thank you! |
|
Why can't the version and changelog be released synchronously? Why does it take some time or even require creating an issue to solve it? |
They can if the release engineer (me) does not make a mistake during the release process by shipping a build without the changelog updated. As to the why it takes time that answer is longer than I wish to type but the short version is about the security of the machines that can make a signed build, machine to machine access to signing keys and multi person authorization requirements for generating signed builds. |
flutter/flutter@42132e8...fe71cad 2024-10-30 reidbaker@google.com Update CHANGELOG.md to correct ios vs macos issue (flutter/flutter#157822) 2024-10-30 tessertaha@gmail.com Add ability to customize the default `Slider` padding (flutter/flutter#156143) 2024-10-30 11473691+YeungKC@users.noreply.github.com Fix menu anchor state handling (flutter/flutter#157612) 2024-10-30 32538273+ValentinVignal@users.noreply.github.com Add test for `interactive_viewer.0.dart` (flutter/flutter#157773) 2024-10-30 32538273+ValentinVignal@users.noreply.github.com Add test for `scroll_metrics_notification.0.dart` (flutter/flutter#157768) 2024-10-30 ybz975218925@gmail.com Add boundary feature to the drag gesture. (flutter/flutter#147521) 2024-10-30 nate.w5687@gmail.com Fix `ResizeImage` documentation (flutter/flutter#157619) 2024-10-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 795b5492f1b9 to 999797a2f690 (1 revision) (flutter/flutter#157825) 2024-10-29 magder@google.com Avoid labeling all PRs as 'text-input' (flutter/flutter#157805) 2024-10-29 engine-flutter-autoroll@skia.org Roll Packages from e0c4f55 to 028027e (8 revisions) (flutter/flutter#157813) 2024-10-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 725c8e4bc379 to 795b5492f1b9 (5 revisions) (flutter/flutter#157820) 2024-10-29 matanlurey@users.noreply.github.com Fix and remove a few `no-shuffle` tags in `flutter_tools`. (flutter/flutter#157656) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Pre-launch Checklist
///).