Add hidden --no-implicit-pubspec-resolution flag for one stable release.
#157635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbaker
approved these changes
Oct 28, 2024
| stdio: mockStdio, | ||
| ), | ||
| }); | ||
|
|
Contributor
|
You might choose to leave the definition of this flag around for another release where the flag does nothing since this flag is an opt in to the new behavior and I think undefined flags error. We don't need to decide that now and there are also good arguments for code health. |
Contributor
Author
|
@andrewkolos has been OOO for a few days, I'll have @jonahwilliams spot check this. |
| hide: !verboseHelp, | ||
| ); | ||
|
|
||
| // TODO(matanlurey): Remove after the Q4 2024 stable release; this is intended |
Contributor
There was a problem hiding this comment.
probably Q1 2025 since Q4 has already cut
Contributor
Author
|
@jonahwilliams has an interesting idea on renaming and reusing this flag as a bundle of features versus a 1-off. Will post a new GH issue and go from there. |
--no-emit-legacy-flutter-plugins flag for one stable release.--no-implicit-pubspec-resolution flag for one stable release.
Contributor
Author
|
I am merging this after renaming the flag |
Contributor
|
auto label is removed for flutter/flutter/157635, due to - The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Contributor
|
auto label is removed for flutter/flutter/157635, due to - The status or check suite Linux tool_integration_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
auto label is removed for flutter/flutter/157635, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 31, 2024
Manual roll requested by tarrinneal@google.com flutter/flutter@fe71cad...0fe6153 2024-10-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from c40b0b602822 to f2154ef3e31c (8 revisions) (flutter/flutter#157926) 2024-10-31 47866232+chunhtai@users.noreply.github.com Hides added routes before top-most route finishes pushing (flutter/flutter#156104) 2024-10-31 26356162+BenjiFarquhar@users.noreply.github.com Fix cursor on hover expand/collapse icon (#155207) (flutter/flutter#155209) 2024-10-31 32538273+ValentinVignal@users.noreply.github.com Add test for `media_query_data.system_gesture_insets.0.dart` (flutter/flutter#157854) 2024-10-31 matanlurey@users.noreply.github.com Add and plumb `useImplicitPubspecResolution` across `flutter_tools`. (flutter/flutter#157879) 2024-10-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 090c33aeae83 to c40b0b602822 (1 revision) (flutter/flutter#157896) 2024-10-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9295eeb6d3ce to 090c33aeae83 (4 revisions) (flutter/flutter#157893) 2024-10-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2bd854e23b61 to 9295eeb6d3ce (5 revisions) (flutter/flutter#157882) 2024-10-30 louisehsu@google.com Adds a new helpful tool exit message for SocketExceptions thrown during mdns discovery (flutter/flutter#157638) 2024-10-30 miechoo@users.noreply.github.com Fix `GlowingOverscrollIndicator` examples (flutter/flutter#155203) 2024-10-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 906a7ad88052 to 2bd854e23b61 (1 revision) (flutter/flutter#157878) 2024-10-30 34871572+gmackall@users.noreply.github.com Upgrade templates to AGP 8.7/Gradle 8.10.2 (flutter/flutter#157872) 2024-10-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 57ed5d338e7e to 906a7ad88052 (13 revisions) (flutter/flutter#157875) 2024-10-30 tessertaha@gmail.com Update Material 3 `LinearProgressIndicator` for new visual style (flutter/flutter#154817) 2024-10-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 999797a2f690 to 57ed5d338e7e (5 revisions) (flutter/flutter#157833) 2024-10-30 matanlurey@users.noreply.github.com Add hidden `--no-implicit-pubspec-resolution` flag for one stable release. (flutter/flutter#157635) 2024-10-30 engine-flutter-autoroll@skia.org Roll Packages from 028027e to 7cc1caa (5 revisions) (flutter/flutter#157864) 2024-10-30 stuartmorgan@google.com Mention partial PRs in the contributing docs (flutter/flutter#157863) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #157532.
Work towards #157819.
Because this flag is checked in
FlutterCommand.verifyAndRun, it seemed cleaner to just make it a global flag - particularly because this flag's longevity is unlikely to be longer than a single stable release.