Skip to content

Match framework and engine android emulator versions #157291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Oct 21, 2024
Merged

Match framework and engine android emulator versions #157291

auto-submit merged 2 commits into from
Oct 21, 2024

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Oct 21, 2024 •
edited
Loading

Related to https://buganizer.corp.google.com/issues/371020223

See flutter/engine#55591 where I updated the engine android 35 emulator version.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@reidbaker reidbaker requested review from a team and matanlurey October 21, 2024 19:23
gmackall
gmackall approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming that the framework currently has the older version, and this is therefore an update (otherwise I'd ask: can update the engine emulator version instead?)

@reidbaker
Copy link
Contributor Author

reidbaker commented Oct 21, 2024

LGTM assuming that the framework currently has the older version, and this is therefore an update (otherwise I'd ask: can update the engine emulator version instead?)

Yes this is 2 weeks old and the one I am replacing is 2 months old.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 21, 2024
@auto-submit auto-submit bot merged commit 4e8060e into flutter:master Oct 21, 2024
@reidbaker reidbaker deleted the ig-371020223-android-35-emu-version-update branch October 22, 2024 14:42
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
4e8060e Match framework and engine android emulator versions (flutter…
581d838 
…/flutter#157291)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
4e8060e Match framework and engine android emulator versions (flutter…
bad6c60 
…/flutter#157291)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
4e8060e Match framework and engine android emulator versions (flutter…
494484a 
…/flutter#157291)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
4e8060e Match framework and engine android emulator versions (flutter…
ef3a123 
…/flutter#157291)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
4e8060e Match framework and engine android emulator versions (flutter…
13395b8 
…/flutter#157291)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmackall gmackall gmackall approved these changes

@matanlurey matanlurey Awaiting requested review from matanlurey

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reidbaker @gmackall