Allow customizing entry mode icons in TimePicker #157151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
navaronbracke
left a comment
There was a problem hiding this comment.
This looks good to me. The failing CI task seems unrelated to your PR, though.
Seems like it is also failing for other PR's.
Contributor
Author
|
Thanks for your time and the helpful suggestions @navaronbracke, really appreciate it. |
28e7a6b to
8015fa2
Compare
…m/syedaniq/flutter into fix156942-timepicker-custom-icons
nate-thegrate
approved these changes
Oct 23, 2024
Contributor
nate-thegrate
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the contribution!
Comment on lines
2224
to
2228
| /// {@macro flutter.material.time_picker.switchToInputEntryModeIcon} | ||
| final Icon switchToInputEntryModeIcon; | ||
|
|
||
| /// {@macro flutter.material.time_picker.switchToTimerEntryModeIcon} | ||
| final Icon switchToTimerEntryModeIcon; |
Contributor
There was a problem hiding this comment.
I was going to leave a suggestion here, but since this is set up to mirror the date picker, it's probably best to leave as-is for consistency.
TahaTesser
requested changes
Oct 26, 2024
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 29, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 29, 2024
flutter/flutter@3fb95c7...42132e8 2024-10-29 34871572+gmackall@users.noreply.github.com Reland "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10" (flutter/flutter#157617) 2024-10-29 jonahwilliams@google.com [impeller] re-enable impeller shard. (flutter/flutter#157806) 2024-10-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4cb4478016b5 to 725c8e4bc379 (1 revision) (flutter/flutter#157808) 2024-10-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Avoid labeling 'context' PRs as 'text-input' (#157650)" (flutter/flutter#157812) 2024-10-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from b95da8106b98 to 4cb4478016b5 (1 revision) (flutter/flutter#157792) 2024-10-29 koji.wakamiya@gmail.com Remove unused import from kt plugin template (flutter/flutter#157220) 2024-10-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5fa7a123b14a to b95da8106b98 (1 revision) (flutter/flutter#157787) 2024-10-29 tessertaha@gmail.com Fix `TabBar` tab icons not respecting custom `IconTheme` (flutter/flutter#157724) 2024-10-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c8f0bf4d740 to 5fa7a123b14a (1 revision) (flutter/flutter#157780) 2024-10-29 105786499+syedaniq@users.noreply.github.com Allow customizing entry mode icons in TimePicker (flutter/flutter#157151) 2024-10-29 32538273+ValentinVignal@users.noreply.github.com Add test for `focus_scope.0.dart` (flutter/flutter#157772) 2024-10-29 32538273+ValentinVignal@users.noreply.github.com Add test for `page_storage.0.dart` (flutter/flutter#157770) 2024-10-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from c05af6f939fc to 0c8f0bf4d740 (1 revision) (flutter/flutter#157774) 2024-10-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from b394e0c98fa0 to c05af6f939fc (1 revision) (flutter/flutter#157767) 2024-10-29 32538273+ValentinVignal@users.noreply.github.com Add test for `nested_scroll_view_state.0.dart` (flutter/flutter#157714) 2024-10-29 zanderso@users.noreply.github.com Pin Mac tool_integration_test shards to arm64 (flutter/flutter#157760) 2024-10-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from ed587dcf61fd to b394e0c98fa0 (4 revisions) (flutter/flutter#157766) 2024-10-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 70671baabbba to ed587dcf61fd (10 revisions) (flutter/flutter#157751) 2024-10-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 23b2c6d3b3b1 to 70671baabbba (1 revision) (flutter/flutter#157740) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
when this will get on stable? waiting for it since 3.19.5 (March 28, 2024) |
Contributor
|
It looks like the issue was filed on October 16 and then this contribution was merged on October 29. Feel free to check out https://docs.flutter.dev/release/archive to get an idea of how often stable releases generally take place. The next one will likely be in about 3 months from now. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new properties to the Material Design
TimePicker:switchToInputEntryModeIconandswitchToTimerEntryModeIcon. These allow developers to customize the icons for toggling between dial and input modes, with default icons (Icons.keyboard_outlinedandIcons.access_time) used if none are provided.Fixes #156942
Pre-launch Checklist
///).