Temporarily skip SemanticsFlag test to allow new flag to roll in #157017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lurchfresser
pushed a commit
to Lurchfresser/flutter
that referenced
this pull request
Oct 17, 2024
…tter#157017) This test relies on the enumeration of all engine flags, and it will fail when flutter/engine#55780 adds `SemanticsFlag.hasSelectedState`. So temporarily skip the test to allow the new flag to be added. I will later unskip the test and change it to check for the new flag as well. A step towards flutter#66673
Lurchfresser
pushed a commit
to Lurchfresser/flutter
that referenced
this pull request
Oct 17, 2024
…o roll in (flutter#157061) Same as flutter#157017, but for `CustomPainter`.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 17, 2024
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Oct 17, 2024
Introduce `SemanticsFlag.hasSelectedState` to the engine API. At this point the flag is not backed by any engine functionality. See also: flutter/flutter#66673 (comment) |⚠️ WARNING | |:----------------------------| | Submit _AFTER_ flutter/flutter#157017 and flutter/flutter#157061 land in the framework | A step towards flutter/flutter#66673
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…ngine#55780) Introduce `SemanticsFlag.hasSelectedState` to the engine API. At this point the flag is not backed by any engine functionality. See also: flutter#66673 (comment) |⚠️ WARNING | |:----------------------------| | Submit _AFTER_ flutter#157017 and flutter#157061 land in the framework | A step towards flutter#66673
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test relies on the enumeration of all engine flags, and it will fail when flutter/engine#55780 adds
SemanticsFlag.hasSelectedState. So temporarily skip the test to allow the new flag to be added. I will later unskip the test and change it to check for the new flag as well.A step towards #66673