Add test for selection_container_disabled.0.dart
#156934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selection_container_disabled.0.dartselection_container_disabled.0.dart
bleroux
approved these changes
Oct 16, 2024
Contributor
bleroux
left a comment
There was a problem hiding this comment.
LGTM!
Before merging consider splitting the very long lines.
|
|
||
| expect(find.widgetWithText(AppBar, 'SelectionContainer.disabled Sample'), findsOne); | ||
|
|
||
| final RenderParagraph paragraph1 = tester.renderObject<RenderParagraph>(find.descendant(of: find.text('Selectable text').first, matching: find.byType(RichText))); |
Contributor
There was a problem hiding this comment.
Suggested change
| final RenderParagraph paragraph1 = tester.renderObject<RenderParagraph>(find.descendant(of: find.text('Selectable text').first, matching: find.byType(RichText))); | |
| final RenderParagraph paragraph1 = tester.renderObject<RenderParagraph>( | |
| find.descendant( | |
| of: find.text('Selectable text').first, | |
| matching: find.byType(RichText), | |
| ), | |
| ); |
Contributor
Author
There was a problem hiding this comment.
Sure, I've done it in format: Split long lines :)
|
|
||
| final RenderParagraph paragraph1 = tester.renderObject<RenderParagraph>(find.descendant(of: find.text('Selectable text').first, matching: find.byType(RichText))); | ||
| final Rect paragraph1Rect = tester.getRect(find.text('Selectable text').first); | ||
| final TestGesture gesture = await tester.startGesture(paragraph1Rect.centerLeft, kind: PointerDeviceKind.mouse); |
Contributor
There was a problem hiding this comment.
Suggested change
| final TestGesture gesture = await tester.startGesture(paragraph1Rect.centerLeft, kind: PointerDeviceKind.mouse); | |
| final TestGesture gesture = await tester.startGesture( | |
| paragraph1Rect.centerLeft, | |
| kind: PointerDeviceKind.mouse, | |
| ); |
| await tester.pump(); | ||
| expect(paragraph1.selections.first, const TextSelection(baseOffset: 0, extentOffset: 7)); | ||
|
|
||
| final RenderParagraph paragraph2 = tester.renderObject<RenderParagraph>(find.descendant(of: find.text('Non-selectable text'), matching: find.byType(RichText))); |
| // paragraph2 is in a disabled container. | ||
| expect(paragraph2.selections, isEmpty); | ||
|
|
||
| final RenderParagraph paragraph3 = tester.renderObject<RenderParagraph>(find.descendant(of: find.text('Selectable text').last, matching: find.byType(RichText))); |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 16, 2024
Lurchfresser
pushed a commit
to Lurchfresser/flutter
that referenced
this pull request
Oct 17, 2024
Contributes to flutter#130459 It adds a test for - `examples/api/test/material/selection_container/selection_container_disabled.0_test.dart`
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #130459
It adds a test for
examples/api/test/material/selection_container/selection_container_disabled.0_test.dartPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.